| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 00:10:55 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=279.358471,conversation_content-fragment;desc="conversation_content fragment";dur=798.196143,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=298.88143,nginx;desc="NGINX";dur=1.091419,glb;desc="GLB";dur=100.907483
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=AK4EYWBC2uXFm4nAyk3nnf9nVvm7D6HcQTIkWn7LSlrpYh2uF8Rr5gkBHp4D9uNsY%2BiWyexfPJeqELk8CaNC%2F%2B2RqGpagtM7Y1uAhfLJxzezIv0Xb1L3p4VVKj0GE3PkLdo5RBDtOhHtZJm1dJKqNDl4w8T%2F9OEvbBZTFWRu2cX6kfKNNlMxmFOSnPg7lvNW8VenykX%2B%2BGgNMvcxbPEiVmxuMfgmnL4yjcQEAahdRe2kTw10Boj6isZltd8igtY3T11plNwBdauGbFx1SwFRQw%3D%3D--QXlIDHIxQ3S8ciN4--AeDX4bDyHGiNhX3SFn4TDQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1308850577.1753402254; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 00:10:54 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 00:10:54 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 880E:2D5B28:333D9:50D3F:6882CB8E
[SOT] rewrite eval frame in C-lang by SigureMo · Pull Request #57653 · PaddlePaddle/Paddle · GitHub
SigureMo
changed the title
use c-lang write eval frame
[SOT] rewrite eval frame in C-lang
Sep 22, 2023
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[SOT] rewrite eval frame in C-lang #57653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SigureMo
merged 7 commits into
PaddlePaddle:develop
from
cattidea:sot/fix-eval-frame-311-compile-issues
Sep 23, 2023
Merged
[SOT] rewrite eval frame in C-lang #57653
SigureMo
merged 7 commits into
PaddlePaddle:develop
from
cattidea:sot/fix-eval-frame-311-compile-issues
Sep 23, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
changed the title
SigureMo
commented
Sep 22, 2023
| @@ -94,9 +94,9 @@ repos: | |||
| description: Check C++ code style using cpplint.py. | |||
| entry: bash ./tools/codestyle/cpplint_pre_commit.hook | |||
| language: system | |||
| files: \.(c|cc|cxx|cpp|cu|h|hpp|hxx)$ | |||
| files: \.(cc|cxx|cpp|cu|h|hpp|hxx)$ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eval_frame.c 是 Paddle 唯一现存的 C 代码，cpplint 里有大量的 C 写法检查，这些是不正确的（比如 NULL -> nullptr），也是没有办法修改的，添加大量 NOLINT 也是不建议的，鉴于所有 C 代码应当都有同样的问题，因此将其从 cpplint 监控列表移除
clang-format 不应禁掉，我们仍然需要代码格式化
clang-tidy 理应禁掉，但是目前并没有发现报错，也许是对 .c 后缀进行了特判，需要之后进一步观察
2 tasks
zrr1999
approved these changes
Sep 23, 2023
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 16, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR types
Bug fixes
PR changes
Others
Description
修复 3.11 编译问题
使用 C 编译 eval_frame，否则因为 eval_frame 中所 include 的部分 Python internal library 使用了 C++ 所不兼容的写法，会导致编译失败，如果不使用 C 的话就需要将相关代码 copy 出来，并使用 C++ 兼容的写法重写一遍，成本巨大，且不易维护
因为无法使用 VLOG，所以原来 VLOG 相关位置暂时注释掉，之后可能寻找合适的方式 log
另外修复了下创建 Function 时候没有 copy closure 的问题
以及修复了 test_pylayer 无法直接 run 的问题
PCard-66972