| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 14:19:24 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=387.956978,conversation_content-fragment;desc="conversation_content fragment";dur=1057.507623,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=526.573252,nginx;desc="NGINX";dur=1.300678,glb;desc="GLB";dur=101.682681
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=pIrPheVDwWKR5i%2FXncMYiXQezKE4t4a6OF5KRapkjZuGzj3OHfv7cew%2Fet7oNxoxEwfVoryVaUuC4gfX%2FdsBr%2F0WtxoupXGlW8X64NF%2Bwz2gOuJLXA5CIX9AGBiqwTBWuT3BR7TSn4j1kPEtZVb%2FncblExcaAbQSHFdF%2Fs6%2FrGpwRQmUcdEyKEsKPjiw4GvoWuBNJt7rQLcAqHHKjxvqYHsL9EOyR3O4bXiUTJ9%2BP9Tf36%2FqmPbxC%2BP6BtdYXS45uyeFai1PB764mR9pLjGDxA%3D%3D--bNYm4fSonfdvOEeU--JiCcl%2FLi6e0%2B6wAwXU9d1A%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.954547203.1753280363; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 14:19:23 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 14:19:23 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8D02:39062F:D11DE8:F79619:6880EF6B
[PIR] standardize the use of value[-4]. by winter-wang · Pull Request #57373 · PaddlePaddle/Paddle · GitHub
winter-wang
changed the title
[PIR] normalize the use of value.
[PIR] normalize the use of value.3-2
Sep 15, 2023
winter-wang
changed the title
[PIR] normalize the use of value.3-2
[PIR] normalize the use of value.3-3
Sep 16, 2023
winter-wang
force-pushed
the
cf_develop
branch
from
September 17, 2023 10:39
winter-wang
changed the title
[PIR] normalize the use of value.3-3
[PIR] normalize the use of value[4-4]
Sep 17, 2023
winter-wang
changed the title
[PIR] normalize the use of value[4-4]
[PIR] standardize the use of value[4-4].
Sep 17, 2023
winter-wang
force-pushed
the
cf_develop
branch
25 times, most recently
from
September 17, 2023 17:21
winter-wang
force-pushed
the
cf_develop
branch
from
September 17, 2023 17:23
winter-wang
changed the title
[PIR] standardize the use of value[4-4].
[PIR] standardize the use of value[-4].
Sep 18, 2023
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[PIR] standardize the use of value[-4]. #57373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winter-wang
changed the title
winter-wang
changed the title
winter-wang
force-pushed
the
cf_develop
branch
from
7f028de to
cc07302
Compare
winter-wang
changed the title
winter-wang
changed the title
winter-wang
force-pushed
the
cf_develop
branch
25 times, most recently
from
4beb146 to
54b6e13
Compare
winter-wang
force-pushed
the
cf_develop
branch
from
54b6e13 to
1cfd559
Compare
Aurelius84
reviewed
Sep 18, 2023
| const std::vector<std::vector<bool>>& stop_gradients) { | ||
| return impl_->vjp_(op, out_grads, stop_gradients); | ||
| } | ||
|
|
||
| std::vector<std::vector<pir::OpResult>> Vjp( | ||
| pir::Operation* op, | ||
| const std::vector<std::vector<pir::OpResult>>& out_grads, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里新增一个重载的Vjp 函数什么背景？我看上面是把入参类型由Value改为了OpResult
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
上层python api调用vjp接口时，传递的是std::vector<std::vector<pir::OpResult>>。 但下层op build接口接受的参数在本次PR中被修正为了std::vector<std::vector<pir::Value>>。 中间存在gap。 OpResult是Value的派生类，这儿新增了一个重载接口，进行该参数的类型转换。
后续控制流支持python api的话，也需要逐步将python相关代码中部分对OpResult的使用替换为Value。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的，了解了
zhangbo9674
approved these changes
Sep 18, 2023
Aurelius84
approved these changes
Sep 18, 2023
XiaoguangHu01
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
winter-wang
changed the title
Merged
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR types
Others
PR changes
APIs
Description
规范化代码中对Value的使用[-4]。
Value分两种，OpResult和BlockArgument. 由于之前没有BlockArgument， 大家都是混用Value和OpResult， 现在有了BlockArguemnt, 需要区分Value和OpResult的使用。
在需要支持BlockArgument的地方，将原本的OpResult升级为Value，使其能够兼容BlockArgument的行为。
本pr内容：
参考pr:
Other
Pcard-67164