| CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[NewIR] No.12 Migrate paddle.add into pir #57166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
单测框架有适配更新，rerun了ci |
| check_dygraph=self.check_dygraph(), check_prim=self.check_prim | ||
| check_dygraph=self.check_dygraph(), | ||
| check_prim=self.check_prim, | ||
| check_new_ir=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
将check_new_ir=True修改为check_new_ir=self.check_dygraph()吧。有的case在动态图下就会跳过检查，新IR下应该也不需要检查
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
收到
| @@ -67,6 +69,7 @@ def test_check_grad_normal(self): | |||
| 'Out', | |||
| check_dygraph=self.check_dygraph(), | |||
| check_prim=self.check_prim, | |||
| check_new_ir=True, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
收到
| @@ -79,6 +82,7 @@ def test_check_grad_ingore_x(self): | |||
| no_grad_set=set("X"), | |||
| check_dygraph=self.check_dygraph(), | |||
| check_prim=self.check_prim, | |||
| check_new_ir=True, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
收到
| @@ -91,6 +95,7 @@ def test_check_grad_ingore_y(self): | |||
| no_grad_set=set('Y'), | |||
| check_dygraph=self.check_dygraph(), | |||
| check_prim=self.check_prim, | |||
| check_new_ir=True, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
收到
| @@ -147,6 +152,7 @@ def test_check_output(self): | |||
| atol=1e-3, | |||
| check_dygraph=self.check_dygraph(), | |||
| check_prim=self.check_prim, | |||
| check_new_ir=True, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
收到
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里忘记修改了，麻烦再提个commit修改下~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
收到
PR types
Others
PR changes
Others
Description
No.12 paddle.add
TODO: