CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 15:01:16 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=289.829582,conversation_content-fragment;desc="conversation_content fragment";dur=680.554366,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=331.894718,nginx;desc="NGINX";dur=1.277809,glb;desc="GLB";dur=101.837791
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=vMQz5OUcyxYj4VRb5ARaV0%2BihX6d1sfIGxXxgfyTjwubi3HYHlGsOF2mkTJubHGpCqQtxD5nfmlAcfqQlYMF%2B4ew0o07vtWIjLDfiMDwU167yLpuJLsTuqe81YFDiE%2F9r7mkXIRfwszYhy1bZdHYKBcrBh7pAIHNkMRW05B2zmdSsHxGMRcp%2FqOrY6t8RjQj1buXpRJ%2BdmYMBcReAfdHPBVXXsBVqQQpFCHKLKUc8D4uO5hHkDlLMy%2FQlcCUBMxIFuVHy72DNMlL1lRM2MO97A%3D%3D--I6ayfGhWeVrl%2F21X--VrDHghSd0pbGw%2BkaozG5Qw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.885373542.1753542075; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 15:01:15 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 15:01:15 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D3EC:138BF2:69E70F:88DB10:6884EDBB
fix paddle namespace conflict when using paddle_flags by huangjiyi · Pull Request #56913 · PaddlePaddle/Paddle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
fix paddle namespace conflict when using paddle_flags #56913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
YuanRisheng
merged 3 commits into
PaddlePaddle:develop
from
huangjiyi:fix_paddle_namespcae_conflict
Sep 4, 2023
Merged
fix paddle namespace conflict when using paddle_flags #56913
YuanRisheng
merged 3 commits into
PaddlePaddle:develop
from
huangjiyi:fix_paddle_namespcae_conflict
Sep 4, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
你的PR提交成功,感谢你对开源项目的贡献! |
YuanRisheng
approved these changes
Sep 4, 2023
zyfncg
approved these changes
Sep 4, 2023
BeingGod
pushed a commit
to BeingGod/Paddle
that referenced
this pull request
Sep 9, 2023
…6913) * update * update * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR types
Others
PR changes
Others
Description
上述问题的原因在
paddle::xxx
命名空间下定义或者声明了 FLAG,比如:Paddle/paddle/fluid/distributed/ps/service/heter_client.cc
Lines 20 to 23 in e2af9d5
在对该文件进行宏展开预处理后,会得到:
相当于在
paddle::distributed
命名空间下又定义了一个paddle
命名空间,这样的话后续该文件在paddle::distributed
命名空间下的paddle::xxx
用法都会被解析成paddle::distributed::paddle::xxx
更底层的原因
在编译的过程中,需要对
paddle::xxx
用法进行解析,需要先找到符号paddle
的声明或定义,由于paddle
是一个非限定名称(没有前缀::
),因此查找过程的顺序是:先在当前命名空间paddle::distributed
进行查找,如果没找到就在上一层命名空间进行找,直到找完全局命名空间,ref: https://en.cppreference.com/w/cpp/language/unqualified_lookup在上面的例子中,由于在
paddle::distributed
命名空间下使用PD_DEFINE_int32
会定义一个paddle
命名空间,编译器在解析后续的paddle
名称时会先找到paddle::distributed::paddle
,从而所有paddle::xxx
用法都会被解析成paddle::distributed::paddle::xxx
,然后编译器再进一步按照限定名称查找这些用法的声明或者定义,最后没找到报错:Solution