[PRIM][IR]support more vjp code gen #56890

Charles-hit · 2023-09-01T10:22:28Z

PR types

New features

PR changes

Others

Description

Pcard-66975
support more vjp code gen in new ir.

paddle-bot · 2023-09-01T10:22:34Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

cxxly · 2023-09-04T08:17:15Z

test/prim/new_ir_prim/test_vjp_prim.py

@@ -100,6 +100,7 @@ def test_divide_grad_prim_case1(self):
        ]
        for idx, op in enumerate(newir_program.block().ops):
            self.assertEqual(op.name(), all_op_names[idx])
+        paddle.fluid.core._set_prim_backward_enabled(False)


paddle.framework.coer.xxx

cxxly · 2023-09-04T08:17:28Z

test/prim/new_ir_prim/test_vjp_prim.py

@@ -145,6 +146,7 @@ def test_sum_grad_prim(self):
        ]
        for idx, op in enumerate(newir_program.block().ops):
            self.assertEqual(op.name(), all_op_names[idx])
+        paddle.fluid.core._set_prim_backward_enabled(False)


paddle.framework.core.xxx

cxxly · 2023-09-04T08:19:58Z

paddle/fluid/operators/generator/tests_utils.py

-            and attr['support_tensor'] is True
-        ):
+            is_scalar(attr['typename']) or is_intarray(attr['typename'])
+        ) and attr['support_tensor'] is True:


attr['support_tensor'] is True -> attr['support_tensor']

cxxly · 2023-09-04T08:21:39Z

paddle/fluid/operators/generator/tests_utils.py

@@ -89,16 +89,14 @@ def is_tensor_list(s):
 def exist_mutable_attribute(attrs):


exist_mutable_attr 保持命名一执性，缩写全用缩写，全称全用全称，避免混用

cxxly · 2023-09-04T08:26:48Z

paddle/fluid/operators/generator/tests_utils.py

-        and attr['support_tensor'] is True
-    )
+        is_scalar(attr['typename']) or is_intarray(attr['typename'])
+    ) and attr['support_tensor'] is True


attr.get('support_tensor', False)

cyber-pioneer

LGTM

heavyrain-lzy

LGTM

Charles-hit force-pushed the support_more_vjp_code_gen branch 2 times, most recently from 8b81675 to 8da9bc4 Compare September 4, 2023 03:35

cxxly reviewed Sep 4, 2023

View reviewed changes

support more vjp code gen

afbf678

Charles-hit force-pushed the support_more_vjp_code_gen branch from 8da9bc4 to afbf678 Compare September 4, 2023 09:46

cyber-pioneer approved these changes Sep 5, 2023

View reviewed changes

heavyrain-lzy approved these changes Sep 5, 2023

View reviewed changes

Charles-hit merged commit 42869ab into PaddlePaddle:develop Sep 5, 2023

BeingGod pushed a commit to BeingGod/Paddle that referenced this pull request Sep 9, 2023

support more vjp code gen (PaddlePaddle#56890)

df9081c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[PRIM][IR]support more vjp code gen #56890

[PRIM][IR]support more vjp code gen #56890

Uh oh!

Charles-hit commented Sep 1, 2023

Uh oh!

paddle-bot bot commented Sep 1, 2023

Uh oh!

cxxly Sep 4, 2023

Uh oh!

cxxly Sep 4, 2023

Uh oh!

cxxly Sep 4, 2023

Uh oh!

Charles-hit Sep 5, 2023

Uh oh!

cxxly Sep 4, 2023

Uh oh!

Charles-hit Sep 5, 2023

Uh oh!

cxxly Sep 4, 2023

Uh oh!

Charles-hit Sep 5, 2023

Uh oh!

cyber-pioneer left a comment

Uh oh!

heavyrain-lzy left a comment

Uh oh!

Uh oh!

		@@ -89,16 +89,14 @@ def is_tensor_list(s):
		def exist_mutable_attribute(attrs):

[PRIM][IR]support more vjp code gen #56890

[PRIM][IR]support more vjp code gen #56890

Uh oh!

Conversation

Charles-hit commented Sep 1, 2023

PR types

PR changes

Description

Uh oh!

paddle-bot bot commented Sep 1, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cyber-pioneer left a comment

Choose a reason for hiding this comment

Uh oh!

heavyrain-lzy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!