| CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
[3rd-party] update openBLAS to fix compile error on Raptor Lake #56617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jiweibo 注意到注释中此前升级曾对IDG业务线有实际影响，能否帮忙确认新版本 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个改动没有生效，需要改动third_party目录下的openbals版本
改好了 |
| # OpenBLAS support Raptor Lake from v0.3.22 | ||
| if(UNIX | ||
| AND NOT APPLE | ||
| AND NOT WITH_ROCM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里加的这些判断是为啥？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
参考这个以前 #53748
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| # OpenBLAS support Raptor Lake from v0.3.22 | ||
| if(UNIX | ||
| AND NOT APPLE | ||
| AND NOT WITH_ROCM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
先确定下在这几个环境下 v0.3.22 能否正常编译，根据情况再添加上吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR可以稍后合入哈@risemeup1，我们先验证下新版本下公司内部业务有没有问题～
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
条件有限，我先用CI测一下 #56806
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可合～
|
hello, @jinyouzhi @risemeup1 我在本地Raptor Lake （Core i9 13900KF 上）机器上编译会报错。 编译选项 cmake .. -DWITH_GPU=OFF -DWITH_MKLDNN=OFF -DWITH_MKL=OFF编译器 |
刚刚在一台 Core i7 13700 上可以编译成功，编译器gcc 11.4，你可以检查一下你的目录Paddle/third-party/openblas以及Paddle/build/third-party/openblas 里面是指定版本吗？ |
|
@jinyouzhi 我这边 gcc 8.2 不行 |
我再尝试复现一下吧 |
|
@GreatV 我能复现了，thanks |
…lePaddle#56617) * [3rd-party] update openBLAS to fix compile error on Raptor Lake * modify comments and remove the gcc version limit * switch third-party/openblas to v0.3.23 * fix
…ke (PaddlePaddle#56617)" (PaddlePaddle#58090) This reverts commit 15728a7.
…ke (PaddlePaddle#56617)" (PaddlePaddle#58090) This reverts commit 15728a7.
PR types
Others
PR changes
Others
Description
https://github.com/xianyi/OpenBLAS/blob/394a9fbafe9010b76a2615c562204277a956eb52/Changelog.txt#L54
https://github.com/xianyi/OpenBLAS/blob/394a9fbafe9010b76a2615c562204277a956eb52/Changelog.txt#L17
OpenBLAS 0.3.22 开始支持Raptor Lake，当前 0.3.18 版本不能在 Xeon 4th CPU上编译（当
WITH_MKL=OFF时）。