| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 00:10:16 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=250.668985,conversation_content-fragment;desc="conversation_content fragment";dur=1067.264177,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=344.064805,nginx;desc="NGINX";dur=0.893963,glb;desc="GLB";dur=100.953048
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=EQh5E%2BwjCBzjtiZal23NXEO3hqOp9K7GM6FC7dEstnlyrAF1xlSolj0NPW0ThtVzuuyQXReRqGoIV%2FTkiay%2FWPMhoKloNF2qAUccjTxdIOVZfaBg246bqL33kwIb26QukLcY4p987%2BsgiSO81XObmVyZLZj2KS6HX%2FUSZWBSSLMH3PbLsmHxnckrhCufPR7aFzEz5bmimqGY%2FQ72CdX7pQI4fXKpS3IPF8vLvU4NUIYfiJc2l3W1%2BBT9h2KEsomn2wP9%2B6Rqi4sLtlUP3oX26Q%3D%3D--LDhAwKVMD7ZLUbUV--KNjtG0dMA40f%2FtBrXDNtHg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1362361174.1753402215; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 00:10:15 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 00:10:15 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 81BA:1EB2CB:33827:50C4D:6882CB67
Add mp_all_reduce asynchronize overlap. by GhostScreaming · Pull Request #55662 · PaddlePaddle/Paddle · GitHub
FeixLiu
changed the title
[WIP] Add mp_all_reduce asynchronize overlap.
Add mp_all_reduce asynchronize overlap.
Aug 11, 2023
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Add mp_all_reduce asynchronize overlap. #55662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Xreki
merged 15 commits into
PaddlePaddle:develop
from
GhostScreaming:mp_async_all_reduce
Aug 16, 2023
Merged
Add mp_all_reduce asynchronize overlap. #55662
Xreki
merged 15 commits into
PaddlePaddle:develop
from
GhostScreaming:mp_async_all_reduce
Aug 16, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry to inform you that 0524262's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
FeixLiu
changed the title
control following behaviors: 1. export Flags_mp_aysnc_allreduce=True to turn on mp async all_reduce 2. export Flags_skip_mp_c_identity=True to skip two c_identity operators in dygraph mode. 3. export Flags_fused_linear_param_grad_add to enable fused_linear_param_grad_add in ColumnParallel backward with mp async all_reduce.
FeixLiu
reviewed
Aug 11, 2023
Xreki
reviewed
Aug 11, 2023
| task.wait() | ||
| return dx, dw, dbias | ||
| else: | ||
| dw = paddle.matmul( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个分支引入了一些reshape，会不会导致一些模型变慢？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的reshape只是改变了数据的逻辑shape，没有进行数据搬移。实测对性能是没啥影响的，timeline的kernel执行时间也是一致的。
FeixLiu
previously approved these changes
Aug 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FeixLiu
reviewed
Aug 14, 2023
FeixLiu
previously approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
FeixLiu
previously approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with TODO: remove three flags, move to distributed_strategy.proto MpConfig
tianshuo78520a
approved these changes
Aug 16, 2023
FeixLiu
approved these changes
Aug 16, 2023
LiYuRio
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for communication
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
PR types
Others
PR changes
Others
Description
PCard-70444.
Add mp_all_reduce asynchronize overlap.
Use environment flags to control following behaviors:
export Flags_mp_aysnc_allreduce=Trueto turn on mp async all_reduceexport Flags_skip_mp_c_identity=Trueto skip two c_identity operators in dygraph mode.export Flags_fused_linear_param_grad_add=Trueto enable fused_linear_param_grad_add in ColumnParallelLinear backward with mp async all_reduce.