Fix Simbolic Symbolic (#60923)

co63oc · web-flow · commit f6ff3f34de2a · 2024-01-18T14:46:13.000+08:00
* Fix

* Fix
diff --git a/paddle/cinn/adt/equation_solver.cc b/paddle/cinn/adt/equation_solver.cc
@@ -109,7 +109,7 @@ bool IsReplicatedSymbolicValues(const Value& lhs, const Value& rhs) {
       rhs.variant());
 }
 
-bool HasReplicatedSimbolicValues(const List<Value>& values) {
+bool HasReplicatedSymbolicValues(const List<Value>& values) {
   for (std::size_t i = 0; i < values->size(); ++i) {
     for (std::size_t j = i + 1; j < values->size(); ++j) {
       if (IsReplicatedSymbolicValues(values->at(i), values->at(j))) {
@@ -128,7 +128,7 @@ std::unordered_map<Variable, Value> InferValuesImpl(
   for (const auto& iter : *in_iters.value()) {
     in_values->emplace_back(ctx->GetValue(iter));
   }
-  if (HasReplicatedSimbolicValues(in_values)) {
+  if (HasReplicatedSymbolicValues(in_values)) {
     return {{out_index.value(), Undefined{}}};
   }
   List<DimExpr> dim_constants{};
diff --git a/paddle/cinn/adt/graph_symbolic_dim_infer_ctx.cc b/paddle/cinn/adt/graph_symbolic_dim_infer_ctx.cc
@@ -475,9 +475,9 @@ SymbolicDim GetOrNewSymbolicDim(
   const auto& target_symbolic_dim_op =
       GetSymbolicDimOp4TensorDim(target_tensor_dim, shape_analysis);
   for (const auto& [tensor_dim, symbolic_dim] : tensor_dim2symbolic_Dim) {
-    const auto& cur_symblic_dim_op =
+    const auto& cur_symbolic_dim_op =
         GetSymbolicDimOp4TensorDim(tensor_dim, shape_analysis);
-    if (target_symbolic_dim_op == cur_symblic_dim_op) {
+    if (target_symbolic_dim_op == cur_symbolic_dim_op) {
       return symbolic_dim;
     }
   }
diff --git a/paddle/cinn/adt/print_utils/print_schedule_mesh.cc b/paddle/cinn/adt/print_utils/print_schedule_mesh.cc
@@ -102,9 +102,9 @@ std::string ToTxtStringMeshImpl(
 
 }  // namespace
 
-std::string ToTxtString(const ScheduleMesh& schecule_mesh) {
+std::string ToTxtString(const ScheduleMesh& schedule_mesh) {
   return std::visit([&](const auto& impl) { return ToTxtStringMeshImpl(impl); },
-                    schecule_mesh.variant());
+                    schedule_mesh.variant());
 }
 
 }  // namespace cinn::adt
diff --git a/paddle/cinn/adt/print_utils/print_schedule_mesh.h b/paddle/cinn/adt/print_utils/print_schedule_mesh.h
@@ -20,6 +20,6 @@ namespace cinn::adt {
 
 class ScheduleMesh;
 
-std::string ToTxtString(const ScheduleMesh& schecule_mesh);
+std::string ToTxtString(const ScheduleMesh& schedule_mesh);
 
 }  // namespace cinn::adt
diff --git a/paddle/cinn/api/op_group.h b/paddle/cinn/api/op_group.h
@@ -149,7 +149,7 @@ class OpGroup {
   // Example: Get the all Reduction op_nodes in the group.
   //   OpGroup group = ...;
   //   std::set<api::OpNode> reduce_ op_set;
-  //   // The lambda funtion of VisitOpNode to get reduction op_nodes.
+  //   // The lambda function of VisitOpNode to get reduction op_nodes.
   //   auto get_reduce_op = [&reduce_op_set](const api::OpNode& op){
   //     if (op.kind() == OpPatternKind::kReduction) {
   //       reduce_op_set.insert(op);
diff --git a/paddle/cinn/auto_schedule/search_space/auto_gen_rule/test_helper.cc b/paddle/cinn/auto_schedule/search_space/auto_gen_rule/test_helper.cc
@@ -43,7 +43,7 @@ using ::cinn::hlir::framework::Tensor;
 
 void TestAutoGenRuleBase::Initialize(const cinn::common::Target& target) {
   target_ = target;
-  backend_compier_ = backends::Compiler::Create(target);
+  backend_compiler_ = backends::Compiler::Create(target);
 }
 
 ir::IRSchedule TestAutoGenRuleBase::MakeIRSchedule(
@@ -92,7 +92,7 @@ ir::Module TestAutoGenRuleBase::BuildIRModule(const ir::IRSchedule& schedule) {
   CHECK_EQ(lowered_funcs_.size(), updated_bodys.size())
       << "associated exprs size not equal";
 
-  ir::Module::Builder builder("test_bulder", this->target_);
+  ir::Module::Builder builder("test_builder", this->target_);
   for (int i = 0; i < lowered_funcs_.size(); ++i) {
     ir::Expr func_body = updated_bodys.at(i);
     const ir::LoweredFunc& ori_func = lowered_funcs_.at(i);
@@ -124,9 +124,9 @@ raw_func_type TestAutoGenRuleBase::GenExecutableKernel(
     const ir::Module& ir_module) {
   auto&& func_name = lowered_funcs_.front()->name;
   // Compile to machine code
-  backend_compier_->Build(ir_module);
+  backend_compiler_->Build(ir_module);
   auto test_func_ptr = reinterpret_cast<void (*)(void**, int32_t)>(
-      backend_compier_->Lookup(func_name));
+      backend_compiler_->Lookup(func_name));
   return test_func_ptr;
 }
 
diff --git a/paddle/cinn/auto_schedule/search_space/auto_gen_rule/test_helper.h b/paddle/cinn/auto_schedule/search_space/auto_gen_rule/test_helper.h
@@ -70,7 +70,7 @@ class TestAutoGenRuleBase : public ::testing::Test {
  protected:
   cinn::common::Target target_;
   std::vector<ir::LoweredFunc> lowered_funcs_;
-  std::unique_ptr<backends::Compiler> backend_compier_;
+  std::unique_ptr<backends::Compiler> backend_compiler_;
 };
 
 /* @brief: Interface for checking function correctness.
diff --git a/paddle/cinn/auto_schedule/search_space/search_space.h b/paddle/cinn/auto_schedule/search_space/search_space.h
@@ -43,7 +43,7 @@ class SearchSpace {
   SearchSpace(const TuneTask& tune_task,
               utils::LinearRandomEngine::StateType rand_seed = -1);
 
-  // Sketch mutate, returns the mutated ModuleExpr and estimited cost
+  // Sketch mutate, returns the mutated ModuleExpr and estimated cost
   virtual SearchState GetScheduleMutate(const SearchState& state,
                                         const ExprCostModel& cost_model);
 

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ bool IsReplicatedSymbolicValues(const Value& lhs, const Value& rhs) {`
`109`	`109`	`rhs.variant());`
`110`	`110`	`}`
`111`	`111`
`112`		`-bool HasReplicatedSimbolicValues(const List<Value>& values) {`
	`112`	`+bool HasReplicatedSymbolicValues(const List<Value>& values) {`
`113`	`113`	`for (std::size_t i = 0; i < values->size(); ++i) {`
`114`	`114`	`for (std::size_t j = i + 1; j < values->size(); ++j) {`
`115`	`115`	`if (IsReplicatedSymbolicValues(values->at(i), values->at(j))) {`
`@@ -128,7 +128,7 @@ std::unordered_map<Variable, Value> InferValuesImpl(`
`128`	`128`	`for (const auto& iter : *in_iters.value()) {`
`129`	`129`	`in_values->emplace_back(ctx->GetValue(iter));`
`130`	`130`	`}`
`131`		`- if (HasReplicatedSimbolicValues(in_values)) {`
	`131`	`+ if (HasReplicatedSymbolicValues(in_values)) {`
`132`	`132`	`return {{out_index.value(), Undefined{}}};`
`133`	`133`	`}`
`134`	`134`	`List<DimExpr> dim_constants{};`
Original file line number	Diff line number	Diff line change
`@@ -475,9 +475,9 @@ SymbolicDim GetOrNewSymbolicDim(`
`475`	`475`	`const auto& target_symbolic_dim_op =`
`476`	`476`	`GetSymbolicDimOp4TensorDim(target_tensor_dim, shape_analysis);`
`477`	`477`	`for (const auto& [tensor_dim, symbolic_dim] : tensor_dim2symbolic_Dim) {`
`478`		`- const auto& cur_symblic_dim_op =`
	`478`	`+ const auto& cur_symbolic_dim_op =`
`479`	`479`	`GetSymbolicDimOp4TensorDim(tensor_dim, shape_analysis);`
`480`		`- if (target_symbolic_dim_op == cur_symblic_dim_op) {`
	`480`	`+ if (target_symbolic_dim_op == cur_symbolic_dim_op) {`
`481`	`481`	`return symbolic_dim;`
`482`	`482`	`}`
`483`	`483`	`}`
Original file line number	Diff line number	Diff line change
`@@ -102,9 +102,9 @@ std::string ToTxtStringMeshImpl(`
`102`	`102`
`103`	`103`	`} // namespace`
`104`	`104`
`105`		`-std::string ToTxtString(const ScheduleMesh& schecule_mesh) {`
	`105`	`+std::string ToTxtString(const ScheduleMesh& schedule_mesh) {`
`106`	`106`	`return std::visit([&](const auto& impl) { return ToTxtStringMeshImpl(impl); },`
`107`		`- schecule_mesh.variant());`
	`107`	`+ schedule_mesh.variant());`
`108`	`108`	`}`
`109`	`109`
`110`	`110`	`} // namespace cinn::adt`