[clang-tidy] NO.35-37 enable modernize-use-bool-literals, clang-analyzer-core.DivideZero, bugprone-integer-division (#61580)

enkilee · web-flow · commit cf6e7b3a1dff · 2024-02-20T11:29:18.000+08:00
* fix

* add 35 36
diff --git a/paddle/fluid/distributed/test/graph_node_test.cc b/paddle/fluid/distributed/test/graph_node_test.cc
@@ -410,8 +410,8 @@ void RunBrpcPushSparse() {
   // testCache();
   setenv("http_proxy", "", 1);
   setenv("https_proxy", "", 1);
-  prepare_file(edge_file_name, 1);
-  prepare_file(node_file_name, 0);
+  prepare_file(edge_file_name, true);
+  prepare_file(node_file_name, false);
   // auto ph_host = paddle::distributed::PSHost(ip_, port_, 0);
   // host_sign_list_.push_back(ph_host.SerializeToString());
 
@@ -541,7 +541,7 @@ void RunBrpcPushSparse() {
   client1.load_node_file(std::string("user"), std::string(node_file_name));
   client1.load_node_file(std::string("item"), std::string(node_file_name));
   client1.load_edge_file(
-      std::string("user2item"), std::string(edge_file_name), 0);
+      std::string("user2item"), std::string(edge_file_name), false);
   nodes.clear();
   VLOG(0) << "start to pull graph list";
   nodes = client1.pull_graph_list(std::string("user"), 0, 1, 4, 1);
diff --git a/paddle/fluid/inference/utils/table_printer.cc b/paddle/fluid/inference/utils/table_printer.cc
@@ -78,7 +78,7 @@ TablePrinter::TablePrinter(const std::vector<std::string>& header) {
   }
 
   terminal_witdh = terminal_witdh - (2 * num_cols) - (num_cols + 1);
-  int avg_width = static_cast<int>(terminal_witdh / num_cols);
+  int avg_width = static_cast<int>(terminal_witdh / num_cols);  // NOLINT
 
   for (size_t i = 0; i < num_cols; ++i) {
     shares_.emplace_back(avg_width);
diff --git a/paddle/fluid/memory/allocation/allocator.h b/paddle/fluid/memory/allocation/allocator.h
@@ -202,7 +202,7 @@ class Allocator : public phi::Allocator {
 };
 
 inline size_t AlignedSize(size_t size, size_t alignment) {
-  auto remaining = size % alignment;
+  auto remaining = size % alignment;  // NOLINT
   return remaining == 0 ? size : size + alignment - remaining;
 }
 
diff --git a/paddle/phi/kernels/stride/view_kernel.cc b/paddle/phi/kernels/stride/view_kernel.cc
@@ -65,7 +65,7 @@ void ViewDtypeKernel(const Context& dev_ctx,
             input.dtype(),
             dtype,
             input.strides()[input.strides().size() - 1]));
-    size_t times = input_dtype_size / output_dtype_size;
+    size_t times = input_dtype_size / output_dtype_size;  // NOLINT
 
     DDim output_dims = input.dims();
     output_dims[output_dims.size() - 1] =
diff --git a/test/cpp/fluid/pscore/heter_cloud_comm_cpu_test.cc b/test/cpp/fluid/pscore/heter_cloud_comm_cpu_test.cc
@@ -56,7 +56,7 @@ void InitTensorsOnClient(framework::Scope* scope,
   auto ptr = w_value->mutable_data<float>(*place);
 
   for (int64_t i = 0; i < w_value->numel(); ++i) {
-    ptr[i] = static_cast<float>(i / 10);
+    ptr[i] = static_cast<float>(i) / 10.0;
   }
 
   auto x_var = scope->Var("x")->GetMutable<phi::DenseTensor>();
diff --git a/test/cpp/fluid/pscore/heter_server_test.cc b/test/cpp/fluid/pscore/heter_server_test.cc
@@ -149,7 +149,7 @@ void InitTensorsOnServer(framework::Scope* scope,
   auto ptr = w_value->mutable_data<float>(*place);
 
   for (int64_t i = 0; i < w_value->numel(); ++i) {
-    ptr[i] = static_cast<float>(i / 10);
+    ptr[i] = static_cast<float>(i) / 10.0;
   }
 }
 
diff --git a/test/cpp/fluid/pscore/send_and_recv_op_cpu_test.cc b/test/cpp/fluid/pscore/send_and_recv_op_cpu_test.cc
@@ -99,7 +99,7 @@ void InitTensorsOnServer(framework::Scope* scope,
   auto ptr = w_value->mutable_data<float>(*place);
 
   for (int64_t i = 0; i < w_value->numel(); ++i) {
-    ptr[i] = static_cast<float>(i / 10);
+    ptr[i] = static_cast<float>(i) / 10.0;
   }
 }
 
diff --git a/test/cpp/fluid/pscore/send_and_recv_op_gpu_test.cc b/test/cpp/fluid/pscore/send_and_recv_op_gpu_test.cc
@@ -149,7 +149,7 @@ void InitTensorsOnServer(framework::Scope* scope,
   auto ptr = w_value->mutable_data<float>(*place);
 
   for (int64_t i = 0; i < w_value->numel(); ++i) {
-    ptr[i] = static_cast<float>(i / 10);
+    ptr[i] = static_cast<float>(i) / 10.0;
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ TablePrinter::TablePrinter(const std::vector<std::string>& header) {`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`terminal_witdh = terminal_witdh - (2 * num_cols) - (num_cols + 1);`
`81`		`- int avg_width = static_cast<int>(terminal_witdh / num_cols);`
	`81`	`+ int avg_width = static_cast<int>(terminal_witdh / num_cols); // NOLINT`
`82`	`82`
`83`	`83`	`for (size_t i = 0; i < num_cols; ++i) {`
`84`	`84`	`shares_.emplace_back(avg_width);`
Original file line number	Diff line number	Diff line change
`@@ -202,7 +202,7 @@ class Allocator : public phi::Allocator {`
`202`	`202`	`};`
`203`	`203`
`204`	`204`	`inline size_t AlignedSize(size_t size, size_t alignment) {`
`205`		`- auto remaining = size % alignment;`
	`205`	`+ auto remaining = size % alignment; // NOLINT`
`206`	`206`	`return remaining == 0 ? size : size + alignment - remaining;`
`207`	`207`	`}`
`208`	`208`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ void InitTensorsOnClient(framework::Scope* scope,`
`56`	`56`	`auto ptr = w_value->mutable_data<float>(*place);`
`57`	`57`
`58`	`58`	`for (int64_t i = 0; i < w_value->numel(); ++i) {`
`59`		`- ptr[i] = static_cast<float>(i / 10);`
	`59`	`+ ptr[i] = static_cast<float>(i) / 10.0;`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`auto x_var = scope->Var("x")->GetMutable<phi::DenseTensor>();`
Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ void InitTensorsOnServer(framework::Scope* scope,`
`149`	`149`	`auto ptr = w_value->mutable_data<float>(*place);`
`150`	`150`
`151`	`151`	`for (int64_t i = 0; i < w_value->numel(); ++i) {`
`152`		`- ptr[i] = static_cast<float>(i / 10);`
	`152`	`+ ptr[i] = static_cast<float>(i) / 10.0;`
`153`	`153`	`}`
`154`	`154`	`}`
`155`	`155`
Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ void InitTensorsOnServer(framework::Scope* scope,`
`99`	`99`	`auto ptr = w_value->mutable_data<float>(*place);`
`100`	`100`
`101`	`101`	`for (int64_t i = 0; i < w_value->numel(); ++i) {`
`102`		`- ptr[i] = static_cast<float>(i / 10);`
	`102`	`+ ptr[i] = static_cast<float>(i) / 10.0;`
`103`	`103`	`}`
`104`	`104`	`}`
`105`	`105`