[CINN] Fix randomness in group cluster pass (#70931)

huangjiyi · web-flow · commit c819245f30c6 · 2025-01-22T00:45:34.000+08:00
diff --git a/paddle/cinn/hlir/dialect/operator/transforms/cinn_group_cluster_pass.cc b/paddle/cinn/hlir/dialect/operator/transforms/cinn_group_cluster_pass.cc
@@ -59,26 +59,26 @@ namespace {
 
 using cinn::hlir::framework::pir::ScheduleInfoNode;
 
-std::unordered_set<::pir::Value> GetListOutsideInput(
+std::vector<::pir::Value> GetListOutsideInput(
     const std::vector<::pir::Operation*>& ops) {
-  std::unordered_set<pir::Value> outside_ops;
-  std::unordered_set<pir::Value> block_inner_output;
+  std::vector<pir::Value> outside_inputs;
+  std::unordered_set<pir::Value> visited;
 
   for (auto op : ops) {
     for (size_t i = 0; i < op->num_results(); ++i) {
-      block_inner_output.insert(op->result(i));
+      visited.insert(op->result(i));
     }
   }
 
   for (const auto& op : ops) {
     for (size_t i = 0; i < op->num_operands(); ++i) {
-      if (!block_inner_output.count(op->operand_source(i)) &&
-          !outside_ops.count(op->operand_source(i))) {
-        outside_ops.insert(op->operand_source(i));
+      if (!visited.count(op->operand_source(i))) {
+        visited.insert(op->operand_source(i));
+        outside_inputs.push_back(op->operand_source(i));
       }
     }
   }
-  return outside_ops;
+  return outside_inputs;
 }
 
 std::string BuildGroupId(const ::pir::GroupOpsVec& ops_list) {
@@ -108,7 +108,7 @@ struct GroupClusterNode {
   std::unordered_map<::pir::Operation*, std::vector<ScheduleInfoNode>>
       alignment_schedule_info;
 
-  std::unordered_set<::pir::Value> GetOutsideInput() const {
+  std::vector<::pir::Value> GetOutsideInput() const {
     return GetListOutsideInput(ops);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -59,26 +59,26 @@ namespace {`
`59`	`59`
`60`	`60`	`using cinn::hlir::framework::pir::ScheduleInfoNode;`
`61`	`61`
`62`		`-std::unordered_set<::pir::Value> GetListOutsideInput(`
	`62`	`+std::vector<::pir::Value> GetListOutsideInput(`
`63`	`63`	`const std::vector<::pir::Operation*>& ops) {`
`64`		`- std::unordered_set<pir::Value> outside_ops;`
`65`		`- std::unordered_set<pir::Value> block_inner_output;`
	`64`	`+ std::vector<pir::Value> outside_inputs;`
	`65`	`+ std::unordered_set<pir::Value> visited;`
`66`	`66`
`67`	`67`	`for (auto op : ops) {`
`68`	`68`	`for (size_t i = 0; i < op->num_results(); ++i) {`
`69`		`- block_inner_output.insert(op->result(i));`
	`69`	`+ visited.insert(op->result(i));`
`70`	`70`	`}`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`for (const auto& op : ops) {`
`74`	`74`	`for (size_t i = 0; i < op->num_operands(); ++i) {`
`75`		`- if (!block_inner_output.count(op->operand_source(i)) &&`
`76`		`- !outside_ops.count(op->operand_source(i))) {`
`77`		`- outside_ops.insert(op->operand_source(i));`
	`75`	`+ if (!visited.count(op->operand_source(i))) {`
	`76`	`+ visited.insert(op->operand_source(i));`
	`77`	`+ outside_inputs.push_back(op->operand_source(i));`
`78`	`78`	`}`
`79`	`79`	`}`
`80`	`80`	`}`
`81`		`- return outside_ops;`
	`81`	`+ return outside_inputs;`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`std::string BuildGroupId(const ::pir::GroupOpsVec& ops_list) {`
`@@ -108,7 +108,7 @@ struct GroupClusterNode {`
`108`	`108`	`std::unordered_map<::pir::Operation*, std::vector<ScheduleInfoNode>>`
`109`	`109`	`alignment_schedule_info;`
`110`	`110`
`111`		`- std::unordered_set<::pir::Value> GetOutsideInput() const {`
	`111`	`+ std::vector<::pir::Value> GetOutsideInput() const {`
`112`	`112`	`return GetListOutsideInput(ops);`
`113`	`113`	`}`
`114`	`114`