Fix Destoryed Destroyed (#60994)

co63oc · web-flow · commit c644bac786f6 · 2024-01-22T10:59:49.000+08:00
diff --git a/paddle/pir/core/block.cc b/paddle/pir/core/block.cc
@@ -23,7 +23,7 @@
 namespace pir {
 Block::~Block() {
   if (!use_empty()) {
-    LOG(FATAL) << "Destoryed a block that is still in use.";
+    LOG(FATAL) << "Destroyed a block that is still in use.";
   }
   clear();
   ClearArguments();
diff --git a/paddle/pir/core/block_argument.cc b/paddle/pir/core/block_argument.cc
@@ -61,7 +61,7 @@ class BlockArgumentImpl : public ValueImpl {
 
 BlockArgumentImpl::~BlockArgumentImpl() {
   if (!use_empty()) {
-    LOG(FATAL) << "Destoryed a blockargument that is still in use.";
+    LOG(FATAL) << "Destroyed a block argument that is still in use.";
   }
 }
 
diff --git a/paddle/pir/core/ir_mapping.h b/paddle/pir/core/ir_mapping.h
@@ -88,7 +88,7 @@ class IrMapping {
   }
 
   template <typename T>
-  void Earse(T from) {
+  void Erase(T from) {
     GetMutableMap<IrType<T>>().erase(from);
   }
 
diff --git a/paddle/pir/core/ir_printer.cc b/paddle/pir/core/ir_printer.cc
@@ -175,7 +175,7 @@ void IrPrinter::PrintGeneralOperation(Operation* op) {
   PrintAttributeMap(op);
   os << " :";
 
-  // PrintOpSingature
+  // PrintOpSignature
   PrintOperandsType(op);
   os << " -> ";
 
diff --git a/paddle/pir/core/iterator.h b/paddle/pir/core/iterator.h
@@ -200,7 +200,7 @@ class DoubleLevelContainer {
   Iterator end();
 
  protected:
-  // only support constructed by derived class : ConstainerT;
+  // only support constructed by derived class : ContainerT;
   DoubleLevelContainer() = default;
   DISABLE_COPY_AND_ASSIGN(DoubleLevelContainer);
   const ContainerT& container() const {
diff --git a/paddle/pir/core/op_base.h b/paddle/pir/core/op_base.h
@@ -49,7 +49,7 @@ class IR_API OpBase {
 
   Block *parent() const { return operation()->GetParent(); }
 
-  // Attribtue related interfaces
+  // Attribute related interfaces
   const AttributeMap &attributes() const { return operation()->attributes(); }
   Attribute attribute(const std::string &key) const {
     return operation()->attribute(key);
diff --git a/paddle/pir/core/op_info_impl.cc b/paddle/pir/core/op_info_impl.cc
@@ -24,8 +24,8 @@ void OpInfo::AttachInterface(InterfaceValue &&interface_value) {
 }
 
 void OpInfoImpl::AttachInterface(InterfaceValue &&interface_value) {
-  auto suceess = interface_set_.insert(std::move(interface_value)).second;
-  IR_ENFORCE(suceess,
+  auto success = interface_set_.insert(std::move(interface_value)).second;
+  IR_ENFORCE(success,
              "Interface: id[%u] is already registered. inset failed",
              interface_value.type_id());
   VLOG(10) << "Attach a interface: id[" << interface_value.type_id() << "]. to "
@@ -93,7 +93,7 @@ void OpInfoImpl::Destroy(OpInfo info) {
   if (info.impl_) {
     info.impl_->Destroy();
   } else {
-    LOG(WARNING) << "A nullptr OpInfo is destoryed.";
+    LOG(WARNING) << "A nullptr OpInfo is destroyed.";
   }
 }
 
@@ -128,7 +128,7 @@ void OpInfoImpl::Destroy() {
       reinterpret_cast<char *>(this) - sizeof(pir::TypeId) * num_traits_;
   // (2)free interfaces
   this->~OpInfoImpl();
-  // (3) free memeory
+  // (3) free memory
   VLOG(10) << "Free base_ptr " << reinterpret_cast<void *>(base_ptr);
   ::operator delete(base_ptr);
 }
diff --git a/paddle/pir/core/op_result.h b/paddle/pir/core/op_result.h
@@ -40,7 +40,7 @@ class IR_API OpResult : public Value {
  private:
   friend Operation;
   OpResult(detail::OpResultImpl *impl);  // NOLINT
-  // Access classof annd dyn_cast_from.
+  // Access classof and dyn_cast_from.
   friend Value;
   friend struct std::hash<OpResult>;
   static bool classof(Value value);
diff --git a/paddle/pir/core/op_result_impl.cc b/paddle/pir/core/op_result_impl.cc
@@ -27,7 +27,7 @@ uint32_t OpResultImpl::index() const {
 
 OpResultImpl::~OpResultImpl() {
   if (!use_empty()) {
-    LOG(FATAL) << "Destoryed a op_result that is still in use. \n"
+    LOG(FATAL) << "Destroyed a op_result that is still in use. \n"
                << "The owner op type is:" << owner()->name();
   }
 }
@@ -72,7 +72,7 @@ void OpResultImpl::set_attribute(const std::string &key, Attribute value) {
   auto attr = owner->attribute(key);
   if (attr && !attr.isa<ArrayAttribute>()) {
     IR_THROW(
-        "The %s attribute has existed as operation attriubute. Can't set it as "
+        "The %s attribute has existed as operation attribute. Can't set it as "
         "value attribute. ");
   }
   auto array_attr = attr.dyn_cast<ArrayAttribute>();
diff --git a/paddle/pir/core/operation.cc b/paddle/pir/core/operation.cc
@@ -398,12 +398,12 @@ int32_t Operation::ComputeOpOperandOffset(uint32_t index) const {
                               sizeof(Operation));
 }
 
-#define COMPONENT_IMPL(component_lower, componnent_upper)                   \
-  componnent_upper##Impl *Operation::component_lower##_impl(uint32_t index) \
-      const {                                                               \
-    int32_t offset = Compute##componnent_upper##Offset(index);              \
-    return reinterpret_cast<componnent_upper##Impl *>(                      \
-        reinterpret_cast<char *>(const_cast<Operation *>(this)) + offset);  \
+#define COMPONENT_IMPL(component_lower, component_upper)                   \
+  component_upper##Impl *Operation::component_lower##_impl(uint32_t index) \
+      const {                                                              \
+    int32_t offset = Compute##component_upper##Offset(index);              \
+    return reinterpret_cast<component_upper##Impl *>(                      \
+        reinterpret_cast<char *>(const_cast<Operation *>(this)) + offset); \
   }
 
 COMPONENT_IMPL(op_result, OpResult)
diff --git a/paddle/pir/core/parser/ir_parser.cc b/paddle/pir/core/parser/ir_parser.cc
@@ -256,7 +256,7 @@ std::vector<std::string> IrParser::ParseValueList() {
   return value_index;
 }
 
-// OpName := "\"" StringIdentifer "." StringIdentifer "\""
+// OpName := "\"" StringIdentifier "." StringIdentifier "\""
 OpInfo IrParser::ParseOpInfo() {
   Token opname_token = ConsumeToken();
   std::string opname =
@@ -288,7 +288,7 @@ std::vector<Value> IrParser::ParseOperandList() {
 }
 
 // AttributeMap := "{" AttributeEntry,(,AttributeEntry)* "}"
-// AttributeEntry := StringIdentifer:Attribute
+// AttributeEntry := StringIdentifier:Attribute
 AttributeMap IrParser::ParseAttributeMap() {
   AttributeMap attribute_map{};
   ConsumeAToken("{");
diff --git a/paddle/pir/core/parser/lexer.cc b/paddle/pir/core/parser/lexer.cc
@@ -16,7 +16,7 @@
 
 Token Lexer::ConsumeToken() {
   SkipWhitespace();
-  if (auto token = LexIdentifer()) {
+  if (auto token = LexIdentifier()) {
     return *token;
   } else if (auto token = LexNumberOrArraow()) {
     return *token;
@@ -71,7 +71,7 @@ void Lexer::SkipWhitespace() {
   }
 }
 
-std::unique_ptr<Token> Lexer::LexIdentifer() {
+std::unique_ptr<Token> Lexer::LexIdentifier() {
   if ((!isalpha(is.peek()) && is.peek() != '_') ||
       IsEndTag(static_cast<char>(is.peek()))) {
     return nullptr;
@@ -80,7 +80,7 @@ std::unique_ptr<Token> Lexer::LexIdentifer() {
   while (isalnum(is.peek()) || is.peek() == '_' || is.peek() == '.') {
     token_identifier += GetChar();
   }
-  std::unique_ptr<Token> token(new Token{token_identifier, IDENTIFER});
+  std::unique_ptr<Token> token(new Token{token_identifier, IDENTIFIER});
   return token;
 }
 
diff --git a/paddle/pir/core/parser/lexer.h b/paddle/pir/core/parser/lexer.h
@@ -29,7 +29,7 @@ class Lexer {
   ~Lexer() = default;
   Token ConsumeToken();
   Token PeekToken();
-  std::unique_ptr<Token> LexIdentifer();
+  std::unique_ptr<Token> LexIdentifier();
   std::unique_ptr<Token> LexNumberOrArraow();
   std::unique_ptr<Token> LexEndTagOrNullVal();
   std::unique_ptr<Token> LexValueId();
diff --git a/paddle/pir/core/parser/token.h b/paddle/pir/core/parser/token.h
@@ -17,7 +17,7 @@
 
 enum Token_type {
   EOF_ = -1,
-  IDENTIFER = 0,
+  IDENTIFIER = 0,
   DIGIT = 1,
   SDIGIT = 2,
   ENDTAG = 3,
diff --git a/paddle/pir/core/region.cc b/paddle/pir/core/region.cc
@@ -107,7 +107,7 @@ void Region::TakeBody(Region &&other) {
 
 void Region::clear() {
   // In order to ensure the correctness of UD Chain,
-  // BlockOperend should be decontructed bofore its source.
+  // BlockOperend should be deconstructed before its source.
   for (auto iter = blocks_.rbegin(); iter != blocks_.rend(); ++iter) {
     (*iter)->clear();
   }

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@`
`23`	`23`	`namespace pir {`
`24`	`24`	`Block::~Block() {`
`25`	`25`	`if (!use_empty()) {`
`26`		`- LOG(FATAL) << "Destoryed a block that is still in use.";`
	`26`	`+ LOG(FATAL) << "Destroyed a block that is still in use.";`
`27`	`27`	`}`
`28`	`28`	`clear();`
`29`	`29`	`ClearArguments();`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ class BlockArgumentImpl : public ValueImpl {`
`61`	`61`
`62`	`62`	`BlockArgumentImpl::~BlockArgumentImpl() {`
`63`	`63`	`if (!use_empty()) {`
`64`		`- LOG(FATAL) << "Destoryed a blockargument that is still in use.";`
	`64`	`+ LOG(FATAL) << "Destroyed a block argument that is still in use.";`
`65`	`65`	`}`
`66`	`66`	`}`
`67`	`67`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ class IrMapping {`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`template <typename T>`
`91`		`- void Earse(T from) {`
	`91`	`+ void Erase(T from) {`
`92`	`92`	`GetMutableMap<IrType<T>>().erase(from);`
`93`	`93`	`}`
`94`	`94`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ uint32_t OpResultImpl::index() const {`
`27`	`27`
`28`	`28`	`OpResultImpl::~OpResultImpl() {`
`29`	`29`	`if (!use_empty()) {`
`30`		`- LOG(FATAL) << "Destoryed a op_result that is still in use. \n"`
	`30`	`+ LOG(FATAL) << "Destroyed a op_result that is still in use. \n"`
`31`	`31`	`<< "The owner op type is:" << owner()->name();`
`32`	`32`	`}`
`33`	`33`	`}`
`@@ -72,7 +72,7 @@ void OpResultImpl::set_attribute(const std::string &key, Attribute value) {`
`72`	`72`	`auto attr = owner->attribute(key);`
`73`	`73`	`if (attr && !attr.isa<ArrayAttribute>()) {`
`74`	`74`	`IR_THROW(`
`75`		`- "The %s attribute has existed as operation attriubute. Can't set it as "`
	`75`	`+ "The %s attribute has existed as operation attribute. Can't set it as "`
`76`	`76`	`"value attribute. ");`
`77`	`77`	`}`
`78`	`78`	`auto array_attr = attr.dyn_cast<ArrayAttribute>();`