[clang-tidy] enable bugprone-unhandled-self-assignment check (#56640)

gouzil · web-flow · commit b185adf8e251 · 2023-08-29T10:37:52.000+08:00
diff --git a/.clang-tidy b/.clang-tidy
@@ -40,7 +40,7 @@ bugprone-integer-division,
 -bugprone-too-small-loop-variable,
 -bugprone-undefined-memory-manipulation,
 -bugprone-undelegated-constructor,
--bugprone-unhandled-self-assignment,
+bugprone-unhandled-self-assignment,
 bugprone-unused-raii,
 -bugprone-unused-return-value,
 -bugprone-use-after-move,
diff --git a/paddle/fluid/distributed/fleet_executor/dist_model_tensor_wrapper.cc b/paddle/fluid/distributed/fleet_executor/dist_model_tensor_wrapper.cc
@@ -56,6 +56,9 @@ void DistModelDataBuf::Resize(size_t length) {
 }
 
 DistModelDataBuf& DistModelDataBuf::operator=(const DistModelDataBuf& other) {
+  if (this == &other) {
+    return *this;
+  }
   if (!other.memory_owned_) {
     data_ = other.data_;
     length_ = other.length_;
diff --git a/paddle/fluid/framework/op_desc.cc b/paddle/fluid/framework/op_desc.cc
@@ -513,6 +513,9 @@ OpDesc::OpDesc(const proto::OpDesc &desc, BlockDesc *block)
 // Explicitly implement the assign operator, Since the added
 // unique_ptr data member does not have the implicit assign operator.
 OpDesc &OpDesc::operator=(const OpDesc &other) {
+  if (this == &other) {
+    return *this;
+  }
   CopyFrom(other);
   block_ = other.block_;
   need_update_ = true;
diff --git a/paddle/fluid/inference/api/api.cc b/paddle/fluid/inference/api/api.cc
@@ -52,6 +52,7 @@ PaddleBuf::PaddleBuf(PaddleBuf &&other)
 PaddleBuf::PaddleBuf(const PaddleBuf &other) { *this = other; }
 
 PaddleBuf &PaddleBuf::operator=(const PaddleBuf &other) {
+  if (this == &other) return *this;
   if (!other.memory_owned_) {
     data_ = other.data_;
     length_ = other.length_;
diff --git a/paddle/fluid/inference/api/paddle_infer_contrib.cc b/paddle/fluid/inference/api/paddle_infer_contrib.cc
@@ -259,6 +259,9 @@ Status::Status(const Status& status) : impl_(std::make_shared<Impl>()) {
 }
 
 Status& Status::operator=(const Status& status) noexcept {
+  if (this == &status) {
+    return *this;
+  }
   *impl_ = *status.impl_;
   return *this;
 }
diff --git a/paddle/phi/core/dense_tensor.cc b/paddle/phi/core/dense_tensor.cc
@@ -65,6 +65,9 @@ DenseTensor::DenseTensor(const DenseTensor& other) {
 }
 
 DenseTensor& DenseTensor::operator=(const DenseTensor& other) {
+  if (this == &other) {
+    return *this;
+  }
   meta_ = other.meta();
   holder_ = other.holder_;
   storage_properties_ =
diff --git a/paddle/phi/core/string_tensor.cc b/paddle/phi/core/string_tensor.cc
@@ -43,6 +43,7 @@ StringTensor::StringTensor(const StringTensor& other) {
 }
 
 StringTensor& StringTensor::operator=(const StringTensor& other) {
+  if (this == &other) return *this;
   meta_ = other.meta();
   holder_ = other.holder_;
   return *this;

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,9 @@ void DistModelDataBuf::Resize(size_t length) {`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`DistModelDataBuf& DistModelDataBuf::operator=(const DistModelDataBuf& other) {`
	`59`	`+ if (this == &other) {`
	`60`	`+ return *this;`
	`61`	`+ }`
`59`	`62`	`if (!other.memory_owned_) {`
`60`	`63`	`data_ = other.data_;`
`61`	`64`	`length_ = other.length_;`
Original file line number	Diff line number	Diff line change
`@@ -259,6 +259,9 @@ Status::Status(const Status& status) : impl_(std::make_shared<Impl>()) {`
`259`	`259`	`}`
`260`	`260`
`261`	`261`	`Status& Status::operator=(const Status& status) noexcept {`
	`262`	`+ if (this == &status) {`
	`263`	`+ return *this;`
	`264`	`+ }`
`262`	`265`	`impl_ = status.impl_;`
`263`	`266`	`return *this;`
`264`	`267`	`}`
Original file line number	Diff line number	Diff line change
`@@ -65,6 +65,9 @@ DenseTensor::DenseTensor(const DenseTensor& other) {`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`DenseTensor& DenseTensor::operator=(const DenseTensor& other) {`
	`68`	`+ if (this == &other) {`
	`69`	`+ return *this;`
	`70`	`+ }`
`68`	`71`	`meta_ = other.meta();`
`69`	`72`	`holder_ = other.holder_;`
`70`	`73`	`storage_properties_ =`
Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,7 @@ StringTensor::StringTensor(const StringTensor& other) {`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`StringTensor& StringTensor::operator=(const StringTensor& other) {`
	`46`	`+ if (this == &other) return *this;`
`46`	`47`	`meta_ = other.meta();`
`47`	`48`	`holder_ = other.holder_;`
`48`	`49`	`return *this;`