fixed bug introduced by function (#68527)

cubehan3 · web-flow · commit b08b79b13480 · 2024-09-30T10:39:33.000+08:00
diff --git a/paddle/fluid/primitive/rule/vjp/details.h b/paddle/fluid/primitive/rule/vjp/details.h
@@ -656,36 +656,37 @@ void add_grad(const Tensor& x,
               Tensor* dx,
               Tensor* dy) {
   if (dy) {
-    if (!common::AreDimsWithDynamicShapeCompatible(out_grad.dims(), y.dims())) {
-      if (has_dynamic_shape(y.shape()) || has_dynamic_shape(out_grad.shape())) {
-        auto dy_tmp = reduce_as<T>(out_grad, y);
-        set_output<T>(dy_tmp, dy);
-      } else {
+    if (has_dynamic_shape(y.shape()) || has_dynamic_shape(out_grad.shape())) {
+      auto dy_tmp = reduce_as<T>(out_grad, y);
+      set_output<T>(dy_tmp, dy);
+    } else {
+      if (out_grad.dims() != y.dims()) {
         phi::DDim reduce_dim =
             get_reduce_dims_from_out(out_grad.dims(), y.dims());
         auto dy_reduce_res =
             out_grad.sum(common::vectorize(reduce_dim), y.dtype(), false);
         auto dy_tmp = reshape<T>(dy_reduce_res, common::vectorize(y.dims()));
         set_output<T>(dy_tmp, dy);
+      } else {
+        by_pass<T>(out_grad, dy);
       }
-    } else {
-      by_pass<T>(out_grad, dy);
     }
   }
+
   if (dx) {
-    if (!common::AreDimsWithDynamicShapeCompatible(out_grad.dims(), x.dims())) {
-      if (has_dynamic_shape(x.shape()) || has_dynamic_shape(out_grad.shape())) {
-        auto dx_tmp = reduce_as<T>(out_grad, x);
-        set_output<T>(dx_tmp, dx);
-      } else {
+    if (has_dynamic_shape(x.shape()) || has_dynamic_shape(out_grad.shape())) {
+      auto dx_tmp = reduce_as<T>(out_grad, x);
+      set_output<T>(dx_tmp, dx);
+    } else {
+      if (out_grad.dims() != x.dims()) {
         auto reduce_dim = get_reduce_dims_from_out(out_grad.dims(), x.dims());
         auto dx_reduce_res =
             out_grad.sum(common::vectorize(reduce_dim), x.dtype(), false);
         auto dx_tmp = reshape<T>(dx_reduce_res, common::vectorize(x.dims()));
         set_output<T>(dx_tmp, dx);
+      } else {
+        by_pass<T>(out_grad, dx);
       }
-    } else {
-      by_pass<T>(out_grad, dx);
     }
   }
 }
