[clang-tidy] NO.19 enable readability-container-size-empty (#61713)

enkilee · web-flow · commit ae8717b73f40 · 2024-02-26T17:09:24.000+08:00
* clangtidy 19

* fix
diff --git a/paddle/fluid/framework/ir/generate_pass.cc b/paddle/fluid/framework/ir/generate_pass.cc
@@ -348,7 +348,7 @@ GraphPatternDetector::handle_t GetGenerateRewrite(
             std::vector<std::string> arguments;
             for (const std::string& argument : var.arguments()) {
               // The input may be mapped on the operator of pattern subgraph.
-              if (var_node_maps[argument].size() == 0) {
+              if (var_node_maps[argument].empty()) {
                 VarDesc var_desc(patterns::UniqueKey(argument));
                 var_node_maps[argument].emplace_back(
                     graph->CreateVarNode(&var_desc));
@@ -363,7 +363,7 @@ GraphPatternDetector::handle_t GetGenerateRewrite(
             std::vector<std::string> arguments;
             for (const std::string& argument : var.arguments()) {
               // The output may be mapped on the operator of pattern subgraph.
-              if (var_node_maps[argument].size() == 0) {
+              if (var_node_maps[argument].empty()) {
                 VarDesc var_desc(patterns::UniqueKey(argument));
                 var_node_maps[argument].emplace_back(
                     graph->CreateVarNode(&var_desc));
diff --git a/paddle/fluid/pir/dialect/operator/utils/utils.cc b/paddle/fluid/pir/dialect/operator/utils/utils.cc
@@ -181,7 +181,7 @@ static std::unordered_map<
         {AttrType::ARRAY,
          [](const pir::Attribute& attr) {
            auto attr_vec = attr.dyn_cast<pir::ArrayAttribute>().AsVector();
-           if (attr_vec.size() == 0) {
+           if (attr_vec.empty()) {
              return VariantType{std::vector<int>()};
            }
            AttrType element_type = GetAttributeType(attr_vec[0]);
diff --git a/paddle/fluid/pir/transforms/pd_op_to_kernel_pass.cc b/paddle/fluid/pir/transforms/pd_op_to_kernel_pass.cc
@@ -786,7 +786,7 @@ static phi::Backend GetKernelBackendByYaml(
     }
   }
 
-  if (backend_info.size() > 0 && kernel_backend == phi::Backend::UNDEFINED) {
+  if (!backend_info.empty() && kernel_backend == phi::Backend::UNDEFINED) {
     kernel_backend = paddle::experimental::ParseBackend(place);
   }
 
diff --git a/paddle/phi/infermeta/spmd_rules/dim_trans.cc b/paddle/phi/infermeta/spmd_rules/dim_trans.cc
@@ -125,7 +125,7 @@ std::string Split::to_string() {
 std::shared_ptr<DimTrans> make_flatten(
     const std::vector<std::shared_ptr<DimTrans>>& dims) {
   std::shared_ptr<DimTrans> ptr;
-  if (dims.size() == 0) {
+  if (dims.empty()) {
     ptr = std::make_shared<Singleton>();
   } else if (dims.size() == 1) {
     ptr = dims[0];
diff --git a/paddle/phi/infermeta/spmd_rules/reshape.cc b/paddle/phi/infermeta/spmd_rules/reshape.cc
@@ -120,7 +120,7 @@ std::vector<std::shared_ptr<DimTrans>> MakeReshapeDimTrans(
       }
     }
 
-    if (tgt_splitted_shape.size() > 0) {
+    if (!tgt_splitted_shape.empty()) {
       std::vector<std::shared_ptr<DimTrans>> input_dims;
       for (int i = 0, n = static_cast<int>(src_dims.size()); i < n; i++) {
         int64_t in_dim = src_dims[i];
diff --git a/paddle/phi/kernels/stride/slice_kernel.cc b/paddle/phi/kernels/stride/slice_kernel.cc
@@ -20,7 +20,6 @@
 #include "paddle/phi/core/kernel_registry.h"
 #include "paddle/phi/kernels/funcs/slice_utils.h"
 
-
 namespace phi {
 
 template <typename Context>
@@ -59,7 +58,7 @@ void SliceStridedKernel(const Context& ctx,
   }
 
   std::vector<uint8_t> decrease_flag(output_dims.size(), 0);
-  if (decrease_axis.size() > 0) {
+  if (!decrease_axis.empty()) {
     for (int i = 0; i < static_cast<int>(decrease_axis.size()); ++i) {
       int64_t axis = decrease_axis[i];
       decrease_flag[axis] = 1;
diff --git a/paddle/phi/kernels/stride/strided_slice_kernel.cc b/paddle/phi/kernels/stride/strided_slice_kernel.cc
@@ -90,7 +90,7 @@ void StridedSliceRawStridedKernel(const Context& dev_ctx,
   }
 
   // generate new shape
-  if (decrease_axis.size() > 0) {
+  if (!decrease_axis.empty()) {
     std::vector<int64_t> new_out_shape;
     std::vector<int64_t> new_out_stride;
     for (size_t i = 0; i < decrease_axis.size(); ++i) {
diff --git a/paddle/pir/src/core/builtin_op.cc b/paddle/pir/src/core/builtin_op.cc
@@ -353,7 +353,7 @@ void SplitOp::PassStopGradients(OperationArgument &argument) {
   if (auto input = argument.inputs[0]) {
     auto *defining_op = input.defining_op();
     if (defining_op && defining_op->isa<CombineOp>()) {
-      IR_ENFORCE(argument.output_types.size(),
+      IR_ENFORCE(!argument.output_types.empty(),
                  defining_op->num_operands(),
                  "Required SplitOp.output.size() == CombineOp.input.size(), "
                  "but received %d != %d",

Original file line number	Diff line number	Diff line change
`@@ -181,7 +181,7 @@ static std::unordered_map<`
`181`	`181`	`{AttrType::ARRAY,`
`182`	`182`	`[](const pir::Attribute& attr) {`
`183`	`183`	`auto attr_vec = attr.dyn_cast<pir::ArrayAttribute>().AsVector();`
`184`		`- if (attr_vec.size() == 0) {`
	`184`	`+ if (attr_vec.empty()) {`
`185`	`185`	`return VariantType{std::vector<int>()};`
`186`	`186`	`}`
`187`	`187`	`AttrType element_type = GetAttributeType(attr_vec[0]);`
Original file line number	Diff line number	Diff line change
`@@ -786,7 +786,7 @@ static phi::Backend GetKernelBackendByYaml(`
`786`	`786`	`}`
`787`	`787`	`}`
`788`	`788`
`789`		`- if (backend_info.size() > 0 && kernel_backend == phi::Backend::UNDEFINED) {`
	`789`	`+ if (!backend_info.empty() && kernel_backend == phi::Backend::UNDEFINED) {`
`790`	`790`	`kernel_backend = paddle::experimental::ParseBackend(place);`
`791`	`791`	`}`
`792`	`792`
Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ std::vector<std::shared_ptr<DimTrans>> MakeReshapeDimTrans(`
`120`	`120`	`}`
`121`	`121`	`}`
`122`	`122`
`123`		`- if (tgt_splitted_shape.size() > 0) {`
	`123`	`+ if (!tgt_splitted_shape.empty()) {`
`124`	`124`	`std::vector<std::shared_ptr<DimTrans>> input_dims;`
`125`	`125`	`for (int i = 0, n = static_cast<int>(src_dims.size()); i < n; i++) {`
`126`	`126`	`int64_t in_dim = src_dims[i];`
Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ void StridedSliceRawStridedKernel(const Context& dev_ctx,`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`// generate new shape`
`93`		`- if (decrease_axis.size() > 0) {`
	`93`	`+ if (!decrease_axis.empty()) {`
`94`	`94`	`std::vector<int64_t> new_out_shape;`
`95`	`95`	`std::vector<int64_t> new_out_stride;`
`96`	`96`	`for (size_t i = 0; i < decrease_axis.size(); ++i) {`