[clang-tidy] enable clang-analyzer-core.UndefinedBinaryOperatorResult (#56636)

gouzil · web-flow · commit a694e679763f · 2023-08-29T10:35:11.000+08:00
diff --git a/.clang-tidy b/.clang-tidy
@@ -58,7 +58,7 @@ bugprone-unused-raii,
 -clang-analyzer-core.NullDereference,
 -clang-analyzer-core.StackAddrEscapeBase,
 -clang-analyzer-core.StackAddressEscape,
--clang-analyzer-core.UndefinedBinaryOperatorResult,
+clang-analyzer-core.UndefinedBinaryOperatorResult,
 -clang-analyzer-core.VLASize,
 -clang-analyzer-core.builtin.BuiltinFunctions,
 -clang-analyzer-core.builtin.NoReturnFunctions,
diff --git a/paddle/phi/kernels/funcs/activation_functor.h b/paddle/phi/kernels/funcs/activation_functor.h
@@ -1488,7 +1488,7 @@ struct LeakyReluFunctor : public BaseActivationFunctor<T> {
 
   template <typename Device, typename X, typename Out>
   void operator()(Device d, X x, Out out) const {
-    if (alpha < 1.f) {
+    if (alpha < 1.f) {  // NOLINT
       out.device(d) = x.cwiseMax(static_cast<T>(alpha) * x);
     } else {
       out.device(d) = x.cwiseMin(static_cast<T>(alpha) * x);
@@ -1653,7 +1653,7 @@ struct HardShrinkFunctor : public BaseActivationFunctor<T> {
   }
   template <typename Device, typename X, typename Out>
   void operator()(Device d, X x, Out out) const {
-    auto temp1 = x < static_cast<T>(threshold * -1.f);
+    auto temp1 = x < static_cast<T>(threshold * -1.f);  // NOLINT
     auto temp2 = x > static_cast<T>(threshold);
     out.device(d) = x * (temp1 || temp2).template cast<T>();
   }
@@ -1673,7 +1673,7 @@ struct HardShrinkGradFunctor : public BaseActivationFunctor<T> {
             typename dOut,
             typename dX>
   void operator()(Device d, X x, Out out UNUSED, dOut dout, dX dx) const {
-    auto temp1 = x < static_cast<T>(threshold * -1.f);
+    auto temp1 = x < static_cast<T>(threshold * -1.f);  // NOLINT
     auto temp2 = x > static_cast<T>(threshold);
     dx.device(d) = dout * (temp1 || temp2).template cast<T>();
   }
@@ -2565,7 +2565,7 @@ struct CELUGradFunctor : public BaseActivationFunctor<T> {
             typename dOut,
             typename dX>
   void operator()(Device d, X x, Out out UNUSED, dOut dout, dX dx) const {
-    auto temp_a_pos = static_cast<T>(alpha > 0);
+    auto temp_a_pos = static_cast<T>(alpha > 0);  // NOLINT
     auto temp_a_neg = static_cast<T>(alpha <= 0);
     auto temp_x_pos = (x > static_cast<T>(0)).template cast<T>();
     auto temp_x_neg = (x <= static_cast<T>(0)).template cast<T>();
