[IR]Polish Construct function arugment (#55004)

Aurelius84 · web-flow · commit 7e383885e9b5 · 2023-06-30T08:49:37.000+08:00
diff --git a/paddle/fluid/ir/dialect/kernel_attribute_storage.h b/paddle/fluid/ir/dialect/kernel_attribute_storage.h
@@ -28,7 +28,7 @@ struct KernelAttributeStorage : public ir::AttributeStorage {
 
   explicit KernelAttributeStorage(const ParamKey &key) { kernel_key_ = key; }
 
-  static KernelAttributeStorage *Construct(ParamKey key) {
+  static KernelAttributeStorage *Construct(const ParamKey &key) {
     return new KernelAttributeStorage(key);
   }
 
diff --git a/paddle/fluid/ir/dialect/kernel_type_storage.h b/paddle/fluid/ir/dialect/kernel_type_storage.h
@@ -37,23 +37,23 @@ struct AllocatedDenseTensorTypeStorage : public ir::TypeStorage {
   ///
   using ParamKey = std::tuple<phi::Place, dialect::DenseTensorType>;
 
-  AllocatedDenseTensorTypeStorage(phi::Place place,
-                                  dialect::DenseTensorType type)
+  AllocatedDenseTensorTypeStorage(const phi::Place& place,
+                                  const dialect::DenseTensorType& type)
       : place_(place), dense_tensor_type_(type) {}
 
   ///
   /// \brief Each derived TypeStorage must define a Construct method, which
   /// StorageManager uses to construct a derived TypeStorage.
   ///
-  static AllocatedDenseTensorTypeStorage *Construct(ParamKey key) {
+  static AllocatedDenseTensorTypeStorage* Construct(const ParamKey& key) {
     return new AllocatedDenseTensorTypeStorage(std::get<0>(key),
                                                std::get<1>(key));
   }
 
   ///
   /// \brief Each derived TypeStorage must provide a HashValue method.
   ///
-  static std::size_t HashValue(const ParamKey &key) {
+  static std::size_t HashValue(const ParamKey& key) {
     std::size_t hash_value = 0;
     // hash place
     hash_value = ir::hash_combine(hash_value, std::get<0>(key).HashValue());
@@ -74,7 +74,7 @@ struct AllocatedDenseTensorTypeStorage : public ir::TypeStorage {
   ///
   /// \brief Each derived TypeStorage needs to overload operator==.
   ///
-  bool operator==(const ParamKey &key) const {
+  bool operator==(const ParamKey& key) const {
     return ParamKey(place_, dense_tensor_type_) == key;
   }
 
diff --git a/paddle/fluid/ir/dialect/pd_attribute_storage.h b/paddle/fluid/ir/dialect/pd_attribute_storage.h
@@ -29,7 +29,7 @@ struct IntArrayAttributeStorage : public ir::AttributeStorage {
 
   explicit IntArrayAttributeStorage(const ParamKey &key) { data_ = key; }
 
-  static IntArrayAttributeStorage *Construct(ParamKey key) {
+  static IntArrayAttributeStorage *Construct(const ParamKey &key) {
     return new IntArrayAttributeStorage(key);
   }
 
@@ -59,7 +59,7 @@ struct DataTypeAttributeStorage : public ir::AttributeStorage {
 
   explicit DataTypeAttributeStorage(const ParamKey &key) { data_ = key; }
 
-  static DataTypeAttributeStorage *Construct(ParamKey key) {
+  static DataTypeAttributeStorage *Construct(const ParamKey &key) {
     return new DataTypeAttributeStorage(key);
   }
 
@@ -80,7 +80,7 @@ struct PlaceAttributeStorage : public ir::AttributeStorage {
 
   explicit PlaceAttributeStorage(const ParamKey &key) { data_ = key; }
 
-  static PlaceAttributeStorage *Construct(ParamKey key) {
+  static PlaceAttributeStorage *Construct(const ParamKey &key) {
     return new PlaceAttributeStorage(key);
   }
 
@@ -99,7 +99,7 @@ struct DataLayoutAttributeStorage : public ir::AttributeStorage {
 
   explicit DataLayoutAttributeStorage(const ParamKey &key) { data_ = key; }
 
-  static DataLayoutAttributeStorage *Construct(ParamKey key) {
+  static DataLayoutAttributeStorage *Construct(const ParamKey &key) {
     return new DataLayoutAttributeStorage(key);
   }
 
diff --git a/paddle/fluid/ir/dialect/pd_type_storage.h b/paddle/fluid/ir/dialect/pd_type_storage.h
@@ -27,7 +27,7 @@ namespace std {
 ///
 template <typename T>
 struct hash<std::vector<T>> {
-  std::size_t operator()(const std::vector<T> &dim) const {
+  std::size_t operator()(const std::vector<T>& dim) const {
     std::size_t seed = 0;
     for (size_t i = 0; i < dim.size(); ++i) {
       seed ^= std::hash<T>()(dim[i]) + 0x9e3779b9 + (seed << 6) + (seed >> 2);
@@ -57,10 +57,10 @@ struct DenseTensorTypeStorage : public ir::TypeStorage {
   using ParamKey =
       std::tuple<ir::Type, phi::DDim, phi::DataLayout, phi::LoD, size_t>;
 
-  DenseTensorTypeStorage(ir::Type dtype,
-                         phi::DDim dims,
-                         phi::DataLayout layout,
-                         phi::LoD lod,
+  DenseTensorTypeStorage(const ir::Type& dtype,
+                         const phi::DDim& dims,
+                         const phi::DataLayout& layout,
+                         const phi::LoD& lod,
                          size_t offset)
       : dtype_(dtype),
         dims_(dims),
@@ -72,7 +72,7 @@ struct DenseTensorTypeStorage : public ir::TypeStorage {
   /// \brief Each derived TypeStorage must define a Construct method, which
   /// StorageManager uses to construct a derived TypeStorage.
   ///
-  static DenseTensorTypeStorage *Construct(ParamKey key) {
+  static DenseTensorTypeStorage* Construct(const ParamKey& key) {
     return new DenseTensorTypeStorage(std::get<0>(key),
                                       std::get<1>(key),
                                       std::get<2>(key),
@@ -83,7 +83,7 @@ struct DenseTensorTypeStorage : public ir::TypeStorage {
   ///
   /// \brief Each derived TypeStorage must provide a HashValue method.
   ///
-  static std::size_t HashValue(const ParamKey &key) {
+  static std::size_t HashValue(const ParamKey& key) {
     std::size_t hash_value = 0;
     // hash dtype
     hash_value =
@@ -109,7 +109,7 @@ struct DenseTensorTypeStorage : public ir::TypeStorage {
   ///
   /// \brief Each derived TypeStorage needs to overload operator==.
   ///
-  bool operator==(const ParamKey &key) const {
+  bool operator==(const ParamKey& key) const {
     return ParamKey(dtype_, dims_, layout_, lod_, offset_) == key;
   }
 
diff --git a/paddle/ir/core/builtin_attribute_storage.h b/paddle/ir/core/builtin_attribute_storage.h
@@ -30,7 +30,7 @@ namespace ir {
                                                                          \
     explicit concrete_storage(const ParamKey &key) { data_ = key; }      \
                                                                          \
-    static concrete_storage *Construct(ParamKey key) {                   \
+    static concrete_storage *Construct(const ParamKey &key) {            \
       return new concrete_storage(key);                                  \
     }                                                                    \
                                                                          \
@@ -60,7 +60,7 @@ struct StrAttributeStorage : public AttributeStorage {
 
   ~StrAttributeStorage() { free(data_); }
 
-  static StrAttributeStorage *Construct(ParamKey key) {
+  static StrAttributeStorage *Construct(const ParamKey &key) {
     return new StrAttributeStorage(key);
   }
 
@@ -100,7 +100,7 @@ struct ArrayAttributeStorage : public AttributeStorage {
 
   ~ArrayAttributeStorage() { free(reinterpret_cast<void *>(data_)); }
 
-  static ArrayAttributeStorage *Construct(ParamKey key) {
+  static ArrayAttributeStorage *Construct(const ParamKey &key) {
     return new ArrayAttributeStorage(key);
   }
 
diff --git a/paddle/ir/core/builtin_type_storage.h b/paddle/ir/core/builtin_type_storage.h
@@ -36,7 +36,7 @@ struct VectorTypeStorage : public TypeStorage {
   /// \brief Each derived TypeStorage must define a Construc method, which
   /// StorageManager uses to construct a derived TypeStorage.
   ///
-  static VectorTypeStorage *Construct(ParamKey key) {
+  static VectorTypeStorage *Construct(const ParamKey &key) {
     return new VectorTypeStorage(key);
   }
 
diff --git a/test/cpp/ir/core/type_test.cc b/test/cpp/ir/core/type_test.cc
@@ -167,7 +167,7 @@ struct IntegerTypeStorage : public ir::TypeStorage {
     return ParamKey(width_, signedness_) == key;
   }
 
-  static IntegerTypeStorage *Construct(ParamKey key) {
+  static IntegerTypeStorage *Construct(const ParamKey &key) {
     return new IntegerTypeStorage(key.first, key.second);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ struct KernelAttributeStorage : public ir::AttributeStorage {`
`28`	`28`
`29`	`29`	`explicit KernelAttributeStorage(const ParamKey &key) { kernel_key_ = key; }`
`30`	`30`
`31`		`- static KernelAttributeStorage *Construct(ParamKey key) {`
	`31`	`+ static KernelAttributeStorage *Construct(const ParamKey &key) {`
`32`	`32`	`return new KernelAttributeStorage(key);`
`33`	`33`	`}`
`34`	`34`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ struct IntArrayAttributeStorage : public ir::AttributeStorage {`
`29`	`29`
`30`	`30`	`explicit IntArrayAttributeStorage(const ParamKey &key) { data_ = key; }`
`31`	`31`
`32`		`- static IntArrayAttributeStorage *Construct(ParamKey key) {`
	`32`	`+ static IntArrayAttributeStorage *Construct(const ParamKey &key) {`
`33`	`33`	`return new IntArrayAttributeStorage(key);`
`34`	`34`	`}`
`35`	`35`
`@@ -59,7 +59,7 @@ struct DataTypeAttributeStorage : public ir::AttributeStorage {`
`59`	`59`
`60`	`60`	`explicit DataTypeAttributeStorage(const ParamKey &key) { data_ = key; }`
`61`	`61`
`62`		`- static DataTypeAttributeStorage *Construct(ParamKey key) {`
	`62`	`+ static DataTypeAttributeStorage *Construct(const ParamKey &key) {`
`63`	`63`	`return new DataTypeAttributeStorage(key);`
`64`	`64`	`}`
`65`	`65`
`@@ -80,7 +80,7 @@ struct PlaceAttributeStorage : public ir::AttributeStorage {`
`80`	`80`
`81`	`81`	`explicit PlaceAttributeStorage(const ParamKey &key) { data_ = key; }`
`82`	`82`
`83`		`- static PlaceAttributeStorage *Construct(ParamKey key) {`
	`83`	`+ static PlaceAttributeStorage *Construct(const ParamKey &key) {`
`84`	`84`	`return new PlaceAttributeStorage(key);`
`85`	`85`	`}`
`86`	`86`
`@@ -99,7 +99,7 @@ struct DataLayoutAttributeStorage : public ir::AttributeStorage {`
`99`	`99`
`100`	`100`	`explicit DataLayoutAttributeStorage(const ParamKey &key) { data_ = key; }`
`101`	`101`
`102`		`- static DataLayoutAttributeStorage *Construct(ParamKey key) {`
	`102`	`+ static DataLayoutAttributeStorage *Construct(const ParamKey &key) {`
`103`	`103`	`return new DataLayoutAttributeStorage(key);`
`104`	`104`	`}`
`105`	`105`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ namespace ir {`
`30`	`30`	`\`
`31`	`31`	`explicit concrete_storage(const ParamKey &key) { data_ = key; } \`
`32`	`32`	`\`
`33`		`- static concrete_storage *Construct(ParamKey key) { \`
	`33`	`+ static concrete_storage *Construct(const ParamKey &key) { \`
`34`	`34`	`return new concrete_storage(key); \`
`35`	`35`	`} \`
`36`	`36`	`\`
`@@ -60,7 +60,7 @@ struct StrAttributeStorage : public AttributeStorage {`
`60`	`60`
`61`	`61`	`~StrAttributeStorage() { free(data_); }`
`62`	`62`
`63`		`- static StrAttributeStorage *Construct(ParamKey key) {`
	`63`	`+ static StrAttributeStorage *Construct(const ParamKey &key) {`
`64`	`64`	`return new StrAttributeStorage(key);`
`65`	`65`	`}`
`66`	`66`
`@@ -100,7 +100,7 @@ struct ArrayAttributeStorage : public AttributeStorage {`
`100`	`100`
`101`	`101`	`~ArrayAttributeStorage() { free(reinterpret_cast<void *>(data_)); }`
`102`	`102`
`103`		`- static ArrayAttributeStorage *Construct(ParamKey key) {`
	`103`	`+ static ArrayAttributeStorage *Construct(const ParamKey &key) {`
`104`	`104`	`return new ArrayAttributeStorage(key);`
`105`	`105`	`}`
`106`	`106`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ struct VectorTypeStorage : public TypeStorage {`
`36`	`36`	`/// \brief Each derived TypeStorage must define a Construc method, which`
`37`	`37`	`/// StorageManager uses to construct a derived TypeStorage.`
`38`	`38`	`///`
`39`		`- static VectorTypeStorage *Construct(ParamKey key) {`
	`39`	`+ static VectorTypeStorage *Construct(const ParamKey &key) {`
`40`	`40`	`return new VectorTypeStorage(key);`
`41`	`41`	`}`
`42`	`42`
Original file line number	Diff line number	Diff line change
`@@ -167,7 +167,7 @@ struct IntegerTypeStorage : public ir::TypeStorage {`
`167`	`167`	`return ParamKey(width_, signedness_) == key;`
`168`	`168`	`}`
`169`	`169`
`170`		`- static IntegerTypeStorage *Construct(ParamKey key) {`
	`170`	`+ static IntegerTypeStorage *Construct(const ParamKey &key) {`
`171`	`171`	`return new IntegerTypeStorage(key.first, key.second);`
`172`	`172`	`}`
`173`	`173`