[clang-tidy] NO.29 enable bugprone-exception-escape (#61609)

enkilee · web-flow · commit 74b9317a0b4b · 2024-02-20T11:29:59.000+08:00
diff --git a/paddle/fluid/framework/details/eager_deletion_op_handle.cc b/paddle/fluid/framework/details/eager_deletion_op_handle.cc
@@ -74,7 +74,7 @@ EagerDeletionOpHandle::EagerDeletionOpHandle(
   }
 }
 
-EagerDeletionOpHandle::~EagerDeletionOpHandle() {
+EagerDeletionOpHandle::~EagerDeletionOpHandle() {  // NOLINT
 #if defined(PADDLE_WITH_CUDA) || defined(PADDLE_WITH_HIP)
   if (event_) {
     auto gpu_place = dev_ctx_->GetPlace();
diff --git a/paddle/fluid/framework/details/fused_all_reduce_op_handle.cc b/paddle/fluid/framework/details/fused_all_reduce_op_handle.cc
@@ -60,7 +60,7 @@ FusedAllReduceOpHandle::FusedAllReduceOpHandle(
       num_of_all_reduce_(num_of_all_reduce) {}
 #endif
 
-FusedAllReduceOpHandle::~FusedAllReduceOpHandle() {
+FusedAllReduceOpHandle::~FusedAllReduceOpHandle() {  // NOLINT
 #if defined(PADDLE_WITH_NCCL) || defined(PADDLE_WITH_RCCL)
   auto destroy_event = [](gpuEvent_t event) {
     if (event == nullptr) return;
diff --git a/paddle/fluid/inference/api/resource_manager.cc b/paddle/fluid/inference/api/resource_manager.cc
@@ -138,7 +138,7 @@ GPUContextResource::GPUContextResource(const phi::Place& place, void* stream)
   InitGPUResource(stream);
 }
 
-GPUContextResource::~GPUContextResource() { DestroyGPUResource(); }
+GPUContextResource::~GPUContextResource() { DestroyGPUResource(); }  // NOLINT
 
 void GPUContextResource::InitGPUResource(void* stream) {
   phi::backends::gpu::GPUDeviceGuard guard(place_.device);
diff --git a/paddle/phi/backends/onednn/onednn_context.cc b/paddle/phi/backends/onednn/onednn_context.cc
@@ -40,7 +40,7 @@ OneDNNContextThreadLocals::Body::Body()
 // and other is to start inference
 // TODO(jczaja): Ideally it would be good to clear only part of cache
 // related to thread that is to be terminated
-OneDNNContextThreadLocals::Body::~Body() {
+OneDNNContextThreadLocals::Body::~Body() {  // NOLINT
   auto cpu_place = phi::CPUPlace();
   // TODO(YuanRisheng): we need remove the dependency on fluid device context
   // here
diff --git a/paddle/phi/core/sparse_coo_tensor.cc b/paddle/phi/core/sparse_coo_tensor.cc
@@ -22,7 +22,7 @@ SparseCooTensor::SparseCooTensor() {
   this->SetMember(non_zero_indices, non_zero_elements, {1}, true);
 }
 
-SparseCooTensor::SparseCooTensor(SparseCooTensor&& other) noexcept {
+SparseCooTensor::SparseCooTensor(SparseCooTensor&& other) noexcept {  // NOLINT
   this->non_zero_elements_ = other.non_zero_elements_;
   this->non_zero_indices_ = other.non_zero_indices_;
   this->coalesced_ = other.coalesced_;
diff --git a/paddle/phi/core/string_tensor.cc b/paddle/phi/core/string_tensor.cc
@@ -49,7 +49,8 @@ StringTensor& StringTensor::operator=(const StringTensor& other) {
   return *this;
 }
 
-StringTensor& StringTensor::operator=(StringTensor&& other) noexcept {
+StringTensor& StringTensor::operator=(
+    StringTensor&& other) noexcept {  // NOLINT
   meta_ = std::move(other.meta_);
   std::swap(holder_, other.holder_);
   return *this;

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ EagerDeletionOpHandle::EagerDeletionOpHandle(`
`74`	`74`	`}`
`75`	`75`	`}`
`76`	`76`
`77`		`-EagerDeletionOpHandle::~EagerDeletionOpHandle() {`
	`77`	`+EagerDeletionOpHandle::~EagerDeletionOpHandle() { // NOLINT`
`78`	`78`	`#if defined(PADDLE_WITH_CUDA) \|\| defined(PADDLE_WITH_HIP)`
`79`	`79`	`if (event_) {`
`80`	`80`	`auto gpu_place = dev_ctx_->GetPlace();`
Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ GPUContextResource::GPUContextResource(const phi::Place& place, void* stream)`
`138`	`138`	`InitGPUResource(stream);`
`139`	`139`	`}`
`140`	`140`
`141`		`-GPUContextResource::~GPUContextResource() { DestroyGPUResource(); }`
	`141`	`+GPUContextResource::~GPUContextResource() { DestroyGPUResource(); } // NOLINT`
`142`	`142`
`143`	`143`	`void GPUContextResource::InitGPUResource(void* stream) {`
`144`	`144`	`phi::backends::gpu::GPUDeviceGuard guard(place_.device);`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ SparseCooTensor::SparseCooTensor() {`
`22`	`22`	`this->SetMember(non_zero_indices, non_zero_elements, {1}, true);`
`23`	`23`	`}`
`24`	`24`
`25`		`-SparseCooTensor::SparseCooTensor(SparseCooTensor&& other) noexcept {`
	`25`	`+SparseCooTensor::SparseCooTensor(SparseCooTensor&& other) noexcept { // NOLINT`
`26`	`26`	`this->non_zero_elements_ = other.non_zero_elements_;`
`27`	`27`	`this->non_zero_indices_ = other.non_zero_indices_;`
`28`	`28`	`this->coalesced_ = other.coalesced_;`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,8 @@ StringTensor& StringTensor::operator=(const StringTensor& other) {`
`49`	`49`	`return *this;`
`50`	`50`	`}`
`51`	`51`
`52`		`-StringTensor& StringTensor::operator=(StringTensor&& other) noexcept {`
	`52`	`+StringTensor& StringTensor::operator=(`
	`53`	`+ StringTensor&& other) noexcept { // NOLINT`
`53`	`54`	`meta_ = std::move(other.meta_);`
`54`	`55`	`std::swap(holder_, other.holder_);`
`55`	`56`	`return *this;`