Fix Rwriter Rewriter (#61265)

co63oc · web-flow · commit 6054d64c16cd · 2024-01-30T10:59:15.000+08:00
diff --git a/paddle/cinn/common/ir_util.h b/paddle/cinn/common/ir_util.h
@@ -82,7 +82,7 @@ inline Expr make_bool(bool x, int lanes) {
 void CheckTensorUniqueInExpr(Expr expr);
 
 /**
- * \brief Check all the buffers are uniuqe in an expression.
+ * \brief Check all the buffers are unique in an expression.
  */
 void CheckBufferUniqueInExpr(Expr expr);
 
diff --git a/paddle/cinn/common/type.cc b/paddle/cinn/common/type.cc
@@ -330,11 +330,11 @@ Type &Type::operator=(const Type &other) {
 }
 
 Type::Storage &Type::GetStorage() {
-  CHECK(storage_) << "The type not initializated! Please check.";
+  CHECK(storage_) << "The type not initialized! Please check.";
   return *storage_;
 }
 const Type::Storage &Type::GetStorage() const {
-  CHECK(storage_) << "The type not initializated! Please check.";
+  CHECK(storage_) << "The type not initialized! Please check.";
   return *storage_;
 }
 
diff --git a/paddle/cinn/frontend/op_mappers/paddle/arg_min_max.cc b/paddle/cinn/frontend/op_mappers/paddle/arg_min_max.cc
@@ -72,7 +72,7 @@ void ArgOpMapperHelper(const paddle::cpp::OpDesc& op_desc,
       << "the indices dtype must be int32 or int64, but got dtype = " << dtype;
 
   int ndim = x->shape.size();
-  // If flatten = true, flatten x and do opration on axis 0.
+  // If flatten = true, flatten x and do operation on axis 0.
   if (flatten) {
     x = ctx.Builder()->Reshape(x, {-1});
     axis = 0;
diff --git a/paddle/cinn/frontend/paddle/cpp/op_desc.h b/paddle/cinn/frontend/paddle/cpp/op_desc.h
@@ -31,7 +31,7 @@ namespace cpp {
 
 /*
  * The cpp::OpDesc is the internal representation for Op. All the internal
- * imprementation should use it, not the pb::OpDesc.
+ * implementation should use it, not the pb::OpDesc.
  */
 class OpDesc : public OpDescAPI {
  public:
diff --git a/paddle/cinn/frontend/pass/gemm_rewriter_test.cc b/paddle/cinn/frontend/pass/gemm_rewriter_test.cc
@@ -30,7 +30,7 @@
 
 namespace cinn::frontend {
 
-TEST(GemmRwriter, BatchedTransLeft) {
+TEST(GemmRewriter, BatchedTransLeft) {
   if (!cinn::runtime::IsCompiledWithCUDA()) {
     return;
   }
@@ -54,7 +54,7 @@ TEST(GemmRwriter, BatchedTransLeft) {
   CompareResult(&program, target, input_ids, {out->id}, 1, passes, 123, true);
 }
 
-TEST(GemmRwriter, BatchedTransRight) {
+TEST(GemmRewriter, BatchedTransRight) {
   if (!cinn::runtime::IsCompiledWithCUDA()) {
     return;
   }
@@ -78,7 +78,7 @@ TEST(GemmRwriter, BatchedTransRight) {
   CompareResult(&program, target, input_ids, {out->id}, 1, passes, 123, true);
 }
 
-TEST(GemmRwriter, BatchedTransTwo) {
+TEST(GemmRewriter, BatchedTransTwo) {
   if (!cinn::runtime::IsCompiledWithCUDA()) {
     return;
   }
@@ -103,7 +103,7 @@ TEST(GemmRwriter, BatchedTransTwo) {
   CompareResult(&program, target, input_ids, {out->id}, 2, passes, 123, true);
 }
 
-TEST(GemmRwriter, BatchedNoTrans) {
+TEST(GemmRewriter, BatchedNoTrans) {
   if (!cinn::runtime::IsCompiledWithCUDA()) {
     return;
   }
@@ -126,7 +126,7 @@ TEST(GemmRwriter, BatchedNoTrans) {
   CompareResult(&program, target, input_ids, {out->id}, 0, passes, 123, true);
 }
 
-TEST(GemmRwriter, TransLeft) {
+TEST(GemmRewriter, TransLeft) {
   if (!cinn::runtime::IsCompiledWithCUDA()) {
     return;
   }
@@ -150,7 +150,7 @@ TEST(GemmRwriter, TransLeft) {
   CompareResult(&program, target, input_ids, {out->id}, 1, passes, 123, true);
 }
 
-TEST(GemmRwriter, TransRight) {
+TEST(GemmRewriter, TransRight) {
   if (!cinn::runtime::IsCompiledWithCUDA()) {
     return;
   }
@@ -174,7 +174,7 @@ TEST(GemmRwriter, TransRight) {
   CompareResult(&program, target, input_ids, {out->id}, 1, passes, 123, true);
 }
 
-TEST(GemmRwriter, TransTwo) {
+TEST(GemmRewriter, TransTwo) {
   if (!cinn::runtime::IsCompiledWithCUDA()) {
     return;
   }
@@ -199,7 +199,7 @@ TEST(GemmRwriter, TransTwo) {
   CompareResult(&program, target, input_ids, {out->id}, 2, passes, 123, true);
 }
 
-TEST(GemmRwriter, NoTrans) {
+TEST(GemmRewriter, NoTrans) {
   if (!cinn::runtime::IsCompiledWithCUDA()) {
     return;
   }
@@ -222,7 +222,7 @@ TEST(GemmRwriter, NoTrans) {
   CompareResult(&program, target, input_ids, {out->id}, 0, passes, 123, true);
 }
 
-TEST(GemmRwriter, BatchedComplex) {
+TEST(GemmRewriter, BatchedComplex) {
   if (!cinn::runtime::IsCompiledWithCUDA()) {
     return;
   }
@@ -256,7 +256,7 @@ TEST(GemmRwriter, BatchedComplex) {
   CompareResult(&program, target, input_ids, {out->id}, 4, passes, 123, false);
 }
 
-TEST(GemmRwriter, Complex) {
+TEST(GemmRewriter, Complex) {
   if (!cinn::runtime::IsCompiledWithCUDA()) {
     return;
   }

Original file line number	Diff line number	Diff line change
`@@ -330,11 +330,11 @@ Type &Type::operator=(const Type &other) {`
`330`	`330`	`}`
`331`	`331`
`332`	`332`	`Type::Storage &Type::GetStorage() {`
`333`		`- CHECK(storage_) << "The type not initializated! Please check.";`
	`333`	`+ CHECK(storage_) << "The type not initialized! Please check.";`
`334`	`334`	`return *storage_;`
`335`	`335`	`}`
`336`	`336`	`const Type::Storage &Type::GetStorage() const {`
`337`		`- CHECK(storage_) << "The type not initializated! Please check.";`
	`337`	`+ CHECK(storage_) << "The type not initialized! Please check.";`
`338`	`338`	`return *storage_;`
`339`	`339`	`}`
`340`	`340`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@`
`30`	`30`
`31`	`31`	`namespace cinn::frontend {`
`32`	`32`
`33`		`-TEST(GemmRwriter, BatchedTransLeft) {`
	`33`	`+TEST(GemmRewriter, BatchedTransLeft) {`
`34`	`34`	`if (!cinn::runtime::IsCompiledWithCUDA()) {`
`35`	`35`	`return;`
`36`	`36`	`}`
`@@ -54,7 +54,7 @@ TEST(GemmRwriter, BatchedTransLeft) {`
`54`	`54`	`CompareResult(&program, target, input_ids, {out->id}, 1, passes, 123, true);`
`55`	`55`	`}`
`56`	`56`
`57`		`-TEST(GemmRwriter, BatchedTransRight) {`
	`57`	`+TEST(GemmRewriter, BatchedTransRight) {`
`58`	`58`	`if (!cinn::runtime::IsCompiledWithCUDA()) {`
`59`	`59`	`return;`
`60`	`60`	`}`
`@@ -78,7 +78,7 @@ TEST(GemmRwriter, BatchedTransRight) {`
`78`	`78`	`CompareResult(&program, target, input_ids, {out->id}, 1, passes, 123, true);`
`79`	`79`	`}`
`80`	`80`
`81`		`-TEST(GemmRwriter, BatchedTransTwo) {`
	`81`	`+TEST(GemmRewriter, BatchedTransTwo) {`
`82`	`82`	`if (!cinn::runtime::IsCompiledWithCUDA()) {`
`83`	`83`	`return;`
`84`	`84`	`}`
`@@ -103,7 +103,7 @@ TEST(GemmRwriter, BatchedTransTwo) {`
`103`	`103`	`CompareResult(&program, target, input_ids, {out->id}, 2, passes, 123, true);`
`104`	`104`	`}`
`105`	`105`
`106`		`-TEST(GemmRwriter, BatchedNoTrans) {`
	`106`	`+TEST(GemmRewriter, BatchedNoTrans) {`
`107`	`107`	`if (!cinn::runtime::IsCompiledWithCUDA()) {`
`108`	`108`	`return;`
`109`	`109`	`}`
`@@ -126,7 +126,7 @@ TEST(GemmRwriter, BatchedNoTrans) {`
`126`	`126`	`CompareResult(&program, target, input_ids, {out->id}, 0, passes, 123, true);`
`127`	`127`	`}`
`128`	`128`
`129`		`-TEST(GemmRwriter, TransLeft) {`
	`129`	`+TEST(GemmRewriter, TransLeft) {`
`130`	`130`	`if (!cinn::runtime::IsCompiledWithCUDA()) {`
`131`	`131`	`return;`
`132`	`132`	`}`
`@@ -150,7 +150,7 @@ TEST(GemmRwriter, TransLeft) {`
`150`	`150`	`CompareResult(&program, target, input_ids, {out->id}, 1, passes, 123, true);`
`151`	`151`	`}`
`152`	`152`
`153`		`-TEST(GemmRwriter, TransRight) {`
	`153`	`+TEST(GemmRewriter, TransRight) {`
`154`	`154`	`if (!cinn::runtime::IsCompiledWithCUDA()) {`
`155`	`155`	`return;`
`156`	`156`	`}`
`@@ -174,7 +174,7 @@ TEST(GemmRwriter, TransRight) {`
`174`	`174`	`CompareResult(&program, target, input_ids, {out->id}, 1, passes, 123, true);`
`175`	`175`	`}`
`176`	`176`
`177`		`-TEST(GemmRwriter, TransTwo) {`
	`177`	`+TEST(GemmRewriter, TransTwo) {`
`178`	`178`	`if (!cinn::runtime::IsCompiledWithCUDA()) {`
`179`	`179`	`return;`
`180`	`180`	`}`
`@@ -199,7 +199,7 @@ TEST(GemmRwriter, TransTwo) {`
`199`	`199`	`CompareResult(&program, target, input_ids, {out->id}, 2, passes, 123, true);`
`200`	`200`	`}`
`201`	`201`
`202`		`-TEST(GemmRwriter, NoTrans) {`
	`202`	`+TEST(GemmRewriter, NoTrans) {`
`203`	`203`	`if (!cinn::runtime::IsCompiledWithCUDA()) {`
`204`	`204`	`return;`
`205`	`205`	`}`
`@@ -222,7 +222,7 @@ TEST(GemmRwriter, NoTrans) {`
`222`	`222`	`CompareResult(&program, target, input_ids, {out->id}, 0, passes, 123, true);`
`223`	`223`	`}`
`224`	`224`
`225`		`-TEST(GemmRwriter, BatchedComplex) {`
	`225`	`+TEST(GemmRewriter, BatchedComplex) {`
`226`	`226`	`if (!cinn::runtime::IsCompiledWithCUDA()) {`
`227`	`227`	`return;`
`228`	`228`	`}`
`@@ -256,7 +256,7 @@ TEST(GemmRwriter, BatchedComplex) {`
`256`	`256`	`CompareResult(&program, target, input_ids, {out->id}, 4, passes, 123, false);`
`257`	`257`	`}`
`258`	`258`
`259`		`-TEST(GemmRwriter, Complex) {`
	`259`	`+TEST(GemmRewriter, Complex) {`
`260`	`260`	`if (!cinn::runtime::IsCompiledWithCUDA()) {`
`261`	`261`	`return;`
`262`	`262`	`}`