[clang-tidy] NO.17 enable cppcoreguidelines-explicit-virtual-functions,modernize-use-override (#61714)

enkilee · web-flow · commit 600c058f92bc · 2024-03-01T10:54:45.000+08:00
* clangtidy 17

* fix
diff --git a/paddle/fluid/framework/details/graph_test_base.h b/paddle/fluid/framework/details/graph_test_base.h
@@ -44,7 +44,7 @@ class DummyOp : public OperatorBase {
 
 class SumOpMaker : public OpProtoAndCheckerMaker {
  public:
-  void Make() {
+  void Make() override {
     AddInput("X", "").AsDuplicable();
     AddOutput("Out", "");
     AddComment("");
@@ -53,7 +53,7 @@ class SumOpMaker : public OpProtoAndCheckerMaker {
 
 class AssignOpMaker : public OpProtoAndCheckerMaker {
  public:
-  void Make() {
+  void Make() override {
     AddInput("X", "").AsDuplicable();
     AddOutput("Out", "");
     AddComment("");
@@ -62,7 +62,7 @@ class AssignOpMaker : public OpProtoAndCheckerMaker {
 
 class SplitOpMaker : public OpProtoAndCheckerMaker {
  public:
-  void Make() {
+  void Make() override {
     AddInput("X", "");
     AddOutput("Out", "").AsDuplicable();
     AddComment("");
diff --git a/paddle/fluid/framework/ir/graph_test.cc b/paddle/fluid/framework/ir/graph_test.cc
@@ -38,7 +38,7 @@ class NOP : public OperatorBase {
 
 class SumOpMaker : public OpProtoAndCheckerMaker {
  public:
-  void Make() {
+  void Make() override {
     AddInput("X", "").AsDuplicable();
     AddOutput("Out", "").AsDuplicable();
     AddComment("");
@@ -60,7 +60,7 @@ class SumOpVarTypeInference : public VarTypeInference {
 
 class DummyOpMaker : public OpProtoAndCheckerMaker {
  public:
-  void Make() {
+  void Make() override {
     AddInput("X", "").AsDuplicable();
     AddOutput("Out", "").AsDuplicable();
     AddComment("");
diff --git a/paddle/fluid/framework/ir/pass_test.cc b/paddle/fluid/framework/ir/pass_test.cc
@@ -43,7 +43,7 @@ void BuildCircleGraph(Graph* g) {
 
 class TestPass : public Pass {
  protected:
-  void ApplyImpl(ir::Graph* graph) const {
+  void ApplyImpl(ir::Graph* graph) const override {
     graph->Set<int>("copy_test_pass_attr", new int);
     graph->Set<int>("copy_test_graph_attr", new int);
 
@@ -226,7 +226,7 @@ TEST(PassTest, TestPassAttrCheckConvertAllBlocks) {
 
 class TestPassWithDefault : public Pass {
  protected:
-  void ApplyImpl(ir::Graph* graph) const {
+  void ApplyImpl(ir::Graph* graph) const override {
     graph->Set<int>("copy_default_attr", new int);
 
     int test_pass_attr = this->Get<int>("default_attr");
diff --git a/paddle/fluid/ir_adaptor/translator/op_translator.cc b/paddle/fluid/ir_adaptor/translator/op_translator.cc
@@ -2722,7 +2722,7 @@ struct RandIntOpTranscriber : public OpTranscriber {
   std::tuple<OpOutputTypeList, OpOutputMapping> GenerateOperationOutput(
       pir::IrContext* ctx,
       const OpDesc& op_desc,
-      const OpOutputInfoList& output_infos) {
+      const OpOutputInfoList& output_infos) override {
     OpOutputMapping arg_to_idx;
     OpOutputTypeList op_output_types = {};
 
diff --git a/test/cpp/fluid/framework/op_proto_maker_test.cc b/test/cpp/fluid/framework/op_proto_maker_test.cc
@@ -21,7 +21,7 @@ limitations under the License. */
 
 class TestAttrProtoMaker : public paddle::framework::OpProtoAndCheckerMaker {
  public:
-  void Make() {
+  void Make() override {
     AddAttr<float>("scale", "scale of test op");
     AddAttr<float>("scale", "scale of test op");
   }
@@ -37,7 +37,7 @@ TEST(ProtoMaker, DuplicatedAttr) {
 
 class TestInOutProtoMaker : public paddle::framework::OpProtoAndCheckerMaker {
  public:
-  void Make() {
+  void Make() override {
     AddInput("input", "input of test op");
     AddInput("input", "input of test op");
   }
@@ -54,7 +54,7 @@ TEST(ProtoMaker, DuplicatedInOut) {
 class OpProtoMakerWithScalar
     : public paddle::framework::OpProtoAndCheckerMaker {
  public:
-  void Make() {
+  void Make() override {
     AddAttr<paddle::experimental::Scalar>("generic_scalar",
                                           "generic_scalar of test op");
     AddAttr<std::vector<paddle::experimental::Scalar>>(
diff --git a/test/cpp/fluid/framework/operator_test.cc b/test/cpp/fluid/framework/operator_test.cc
@@ -51,7 +51,7 @@ class OpWithoutKernelTest : public OperatorBase {
 
 class OpWithoutKernelCheckerMaker : public OpProtoAndCheckerMaker {
  public:
-  void Make() {
+  void Make() override {
     AddInput("input", "input of test op");
     AddOutput("output", "output of test op");
     AddAttr<float>("scale", "scale of cosine op");
@@ -106,7 +106,7 @@ static int special_type_value = 1;
 
 class OpKernelTestProtoAndCheckerMaker : public OpProtoAndCheckerMaker {
  public:
-  void Make() {
+  void Make() override {
     AddInput("x", "input of test op");
     AddOutput("y", "output of test op");
     AddAttr<float>("scale", "scale of cosine op")
@@ -161,7 +161,7 @@ class CPUKernel2Test : public OpKernel<float> {
 class OpKernelTestMultiInputsProtoAndCheckerMaker
     : public OpProtoAndCheckerMaker {
  public:
-  void Make() {
+  void Make() override {
     AddInput("xs", "inputs of test op").AsDuplicable();
     AddInput("k", "input of test op");
     AddOutput("ys", "outputs of test op").AsDuplicable();
@@ -335,7 +335,7 @@ class IndicateLoDTensorDataTypeTest : public OperatorWithKernel {
 
 class IndicateLoDTensorDataTypeTestProtoMaker : public OpProtoAndCheckerMaker {
  public:
-  void Make() {
+  void Make() override {
     AddInput("phi::DenseTensor", "Input of phi::DenseTensor type Variable.");
     AddComment("This Op is only for IndicateVarDataType interface test.");
   }
@@ -357,7 +357,7 @@ class IndicateSelectedRowsDataTypeTest : public OperatorWithKernel {
 class IndicateSelectedRowsDataTypeTestProtoMaker
     : public OpProtoAndCheckerMaker {
  public:
-  void Make() {
+  void Make() override {
     AddInput("SelectedRows", "Input of SelectedRows type Variable.");
     AddComment("This Op is only for IndicateVarDataType interface test.");
   }
@@ -377,7 +377,7 @@ class IndicateOtherDataTypeTest : public OperatorWithKernel {
 };
 class IndicateOtherDataTypeTestProtoMaker : public OpProtoAndCheckerMaker {
  public:
-  void Make() {
+  void Make() override {
     AddInput("Other", "Input of Other type Variable");
     AddComment("This Op is only for IndicateVarDataType interface test.");
   }
@@ -512,7 +512,7 @@ class SetLoDLevelTest : public OperatorWithKernel {
 
 class GetSetLoDLevelTestMaker : public OpProtoAndCheckerMaker {
  public:
-  void Make() {
+  void Make() override {
     AddInput("X", "(phi::DenseTensor) Input Variable.");
     AddOutput("Out", "(phi::DenseTensor) Output Variable.");
     AddComment("This Op is only for Get/SetLoDLevel interface test.");
@@ -592,7 +592,7 @@ class OpUnusedVarTest : public OperatorWithKernel {
 
 class OpUnusedVarTestProtoAndCheckerMaker : public OpProtoAndCheckerMaker {
  public:
-  void Make() {
+  void Make() override {
     AddInput("X", "input of test op");
     AddOutput("Y", "output of test op");
     AddComment("This is test op for unused var check.");
diff --git a/test/cpp/fluid/framework/var_type_inference_test.cc b/test/cpp/fluid/framework/var_type_inference_test.cc
@@ -41,7 +41,7 @@ class NOP : public OperatorBase {
 
 class SumOpMaker : public OpProtoAndCheckerMaker {
  public:
-  void Make() {
+  void Make() override {
     AddInput("X", "").AsDuplicable();
     AddOutput("Out", "");
     AddComment("");
diff --git a/test/cpp/pir/core/add_dialect_parser_test.cc b/test/cpp/pir/core/add_dialect_parser_test.cc
@@ -37,7 +37,7 @@ class TestParserDialect : public pir::Dialect {
 
   static const char* name() { return "tp"; }
 
-  void PrintAttribute(pir::Attribute attr, std::ostream& os) const;
+  void PrintAttribute(pir::Attribute attr, std::ostream& os) const;  // NOLINT
 
   pir::Attribute ParseAttribute(pir::IrParser& parser);  // NOLINT
 
