[clang-tidy] enable cppcoreguidelines-no-malloc check (#57343)

gouzil · web-flow · commit 51cf774bca38 · 2023-09-18T14:30:44.000+08:00
diff --git a/.clang-tidy b/.clang-tidy
@@ -157,7 +157,7 @@ cppcoreguidelines-c-copy-assignment-signature,
 cppcoreguidelines-explicit-virtual-functions,
 -cppcoreguidelines-init-variables,
 cppcoreguidelines-narrowing-conversions,
--cppcoreguidelines-no-malloc,
+cppcoreguidelines-no-malloc,
 -cppcoreguidelines-pro-type-const-cast,
 -cppcoreguidelines-pro-type-member-init,
 -cppcoreguidelines-slicing,
diff --git a/paddle/fluid/framework/data_feed.cc b/paddle/fluid/framework/data_feed.cc
@@ -108,10 +108,10 @@ class BufferedLineFileReader {
         uniform_distribution_(0.0f, 1.0f) {
     total_len_ = 0;
     sample_line_ = 0;
-    buff_ =
-        reinterpret_cast<char*>(calloc(MAX_FILE_BUFF_SIZE + 1, sizeof(char)));
+    buff_ = reinterpret_cast<char*>(
+        calloc(MAX_FILE_BUFF_SIZE + 1, sizeof(char)));  // NOLINT
   }
-  ~BufferedLineFileReader() { free(buff_); }
+  ~BufferedLineFileReader() { free(buff_); }  // NOLINT
 
   int read_file(FILE* fp, LineFunc func, int skip_lines) {
     FILEReader reader(fp);
diff --git a/paddle/fluid/framework/new_executor/workqueue/workqueue.cc b/paddle/fluid/framework/new_executor/workqueue/workqueue.cc
@@ -119,7 +119,7 @@ WorkQueueGroupImpl::WorkQueueGroupImpl(
       tracker_(nullptr) {
   size_t num_queues = queues_options_.size();
   queues_.resize(num_queues);
-  void* buffer = malloc(sizeof(NonblockingThreadPool) * num_queues);
+  void* buffer = malloc(sizeof(NonblockingThreadPool) * num_queues);  // NOLINT
   queues_storage_ = reinterpret_cast<NonblockingThreadPool*>(buffer);
 
   for (size_t idx = 0; idx < num_queues; ++idx) {
@@ -157,7 +157,7 @@ WorkQueueGroupImpl::~WorkQueueGroupImpl() {
     tracker_->~TaskTracker();
     AlignedFree(tracker_);
   }
-  free(queues_storage_);
+  free(queues_storage_);  // NOLINT
   if (destruct_notifier_) {
     destruct_notifier_->NotifyEvent();
   }
diff --git a/paddle/fluid/framework/new_executor/workqueue/workqueue_utils.cc b/paddle/fluid/framework/new_executor/workqueue/workqueue_utils.cc
@@ -32,7 +32,7 @@ void* AlignedMalloc(size_t size, size_t alignment) {
 #elif defined(_WIN32)
   return _aligned_malloc(size, alignment);
 #else
-  void* mem = malloc(size + alignment);
+  void* mem = malloc(size + alignment);  // NOLINT
   if (mem == nullptr) {
     return nullptr;
   }
@@ -51,7 +51,7 @@ void AlignedFree(void* mem_ptr) {
   _aligned_free(mem_ptr);
 #else
   if (mem_ptr) {
-    free(*(reinterpret_cast<void**>(mem_ptr) - 1));
+    free(*(reinterpret_cast<void**>(mem_ptr) - 1));  // NOLINT
   }
 #endif
 }
diff --git a/paddle/fluid/framework/string_array.cc b/paddle/fluid/framework/string_array.cc
@@ -48,7 +48,7 @@ void NFD(const std::string& s, std::string* ret) {
       utf8proc_NFD(reinterpret_cast<const unsigned char*>(s.c_str())));
   if (result) {
     *ret = std::move(std::string(result));
-    free(result);
+    free(result);  // NOLINT
   }
 }
 
diff --git a/paddle/fluid/inference/capi_exp/pd_config.cc b/paddle/fluid/inference/capi_exp/pd_config.cc
@@ -202,7 +202,8 @@ int32_t PD_ConfigCustomDeviceId(__pd_keep PD_Config* pd_config) {
 char* PD_ConfigCustomDeviceType(__pd_keep PD_Config* pd_config) {
   CHECK_AND_CONVERT_PD_CONFIG;
   auto device_type_str = config->custom_device_type();
-  char* c = reinterpret_cast<char*>(malloc(device_type_str.length() + 1));
+  char* c =
+      reinterpret_cast<char*>(malloc(device_type_str.length() + 1));  // NOLINT
   snprintf(c, device_type_str.length() + 1, "%s", device_type_str.c_str());
   return c;
 }
@@ -316,7 +317,7 @@ void PD_ConfigCollectShapeRangeInfo(__pd_keep PD_Config* pd_config,
 const char* PD_ConfigShapeRangeInfoPath(__pd_keep PD_Config* pd_config) {
   CHECK_AND_CONVERT_PD_CONFIG;
   auto shape_str = config->shape_range_info_path();
-  char* c = reinterpret_cast<char*>(malloc(shape_str.length() + 1));
+  char* c = reinterpret_cast<char*>(malloc(shape_str.length() + 1));  // NOLINT
   snprintf(c, shape_str.length() + 1, "%s", shape_str.c_str());
   return c;
 }
diff --git a/paddle/fluid/memory/allocation/auto_growth_best_fit_allocator_test.cc b/paddle/fluid/memory/allocation/auto_growth_best_fit_allocator_test.cc
@@ -30,12 +30,12 @@ class RecordedAllocator : public Allocator {
  protected:
   phi::Allocation *AllocateImpl(size_t size) override {
     allocated_size_ += size;
-    return new Allocation(malloc(size), size, platform::CPUPlace());
+    return new Allocation(malloc(size), size, platform::CPUPlace());  // NOLINT
   }
 
   void FreeImpl(phi::Allocation *allocation) override {
     allocated_size_ -= allocation->size();
-    free(allocation->ptr());
+    free(allocation->ptr());  // NOLINT
     delete allocation;
   }
 
@@ -85,12 +85,12 @@ class LimitedResourceAllocator : public Allocator {
     }
 
     allocated_size_ += size;
-    return new Allocation(malloc(size), size, platform::CPUPlace());
+    return new Allocation(malloc(size), size, platform::CPUPlace());  // NOLINT
   }
 
   void FreeImpl(phi::Allocation *allocation) override {
     allocated_size_ -= allocation->size();
-    free(allocation->ptr());
+    free(allocation->ptr());  // NOLINT
     delete allocation;
   }
 
diff --git a/paddle/fluid/memory/allocation/cpu_allocator.cc b/paddle/fluid/memory/allocation/cpu_allocator.cc
@@ -31,7 +31,7 @@ void CPUAllocator::FreeImpl(phi::Allocation *allocation) {
 #ifdef _WIN32
   _aligned_free(p);
 #else
-  free(p);
+  free(p);  // NOLINT
 #endif
   HOST_MEMORY_STAT_UPDATE(Reserved, 0, -size);
   delete allocation;
diff --git a/paddle/fluid/memory/allocation/system_allocator.cc b/paddle/fluid/memory/allocation/system_allocator.cc
@@ -114,7 +114,7 @@ void CPUAllocator::Free(void* p, size_t size, size_t index) {
 #ifdef _WIN32
   _aligned_free(p);
 #else
-  free(p);
+  free(p);  // NOLINT
 #endif
 }
 
diff --git a/paddle/fluid/operators/detection/mask_util.cc b/paddle/fluid/operators/detection/mask_util.cc
@@ -198,7 +198,7 @@ void Polys2MaskWrtBox(const std::vector<std::vector<float>>& polygons,
     msk = mask;
   } else {
     msk = reinterpret_cast<uint8_t*>(
-        malloc(M * M * polygons.size() * sizeof(uint8_t)));
+        malloc(M * M * polygons.size() * sizeof(uint8_t)));  // NOLINT
   }
   for (size_t i = 0; i < polygons.size(); ++i) {
     int k = static_cast<int>(polygons[i].size() / 2);
@@ -224,7 +224,7 @@ void Polys2MaskWrtBox(const std::vector<std::vector<float>>& polygons,
         }
       }
     }
-    free(msk);
+    free(msk);  // NOLINT
   }
 }
 
diff --git a/paddle/phi/core/enforce.cc b/paddle/phi/core/enforce.cc
@@ -163,7 +163,7 @@ std::string GetCurrentTraceBackString(bool for_signal) {
       }
     }
   }
-  free(symbols);
+  free(symbols);  // NOLINT
 #else
   sout << "Not support stack backtrace yet.\n";
 #endif
diff --git a/paddle/phi/kernels/cpu/multiclass_nms3_kernel.cc b/paddle/phi/kernels/cpu/multiclass_nms3_kernel.cc
@@ -61,13 +61,13 @@ void Array2Poly(const T* box,
                 phi::funcs::gpc_polygon* poly) {
   size_t pts_num = box_size / 2;
   (*poly).num_contours = 1;
-  (*poly).hole = reinterpret_cast<int*>(malloc(sizeof(int)));
+  (*poly).hole = reinterpret_cast<int*>(malloc(sizeof(int)));  // NOLINT
   (*poly).hole[0] = 0;
-  (*poly).contour =
-      (phi::funcs::gpc_vertex_list*)malloc(sizeof(phi::funcs::gpc_vertex_list));
+  (*poly).contour = (phi::funcs::gpc_vertex_list*)malloc(  // NOLINT
+      sizeof(phi::funcs::gpc_vertex_list));
   (*poly).contour->num_vertices = static_cast<int>(pts_num);
-  (*poly).contour->vertex = (phi::funcs::gpc_vertex*)malloc(
-      sizeof(phi::funcs::gpc_vertex) * pts_num);  // NOLINT
+  (*poly).contour->vertex = (phi::funcs::gpc_vertex*)malloc(  // NOLINT
+      sizeof(phi::funcs::gpc_vertex) * pts_num);
   for (size_t i = 0; i < pts_num; ++i) {
     (*poly).contour->vertex[i].x = box[2 * i];
     (*poly).contour->vertex[i].y = box[2 * i + 1];
@@ -79,13 +79,13 @@ void PointVec2Poly(const std::vector<Point_<T>>& vec,
                    phi::funcs::gpc_polygon* poly) {
   int pts_num = vec.size();
   (*poly).num_contours = 1;
-  (*poly).hole = reinterpret_cast<int*>(malloc(sizeof(int)));
+  (*poly).hole = reinterpret_cast<int*>(malloc(sizeof(int)));  // NOLINT
   (*poly).hole[0] = 0;
-  (*poly).contour =
-      (phi::funcs::gpc_vertex_list*)malloc(sizeof(phi::funcs::gpc_vertex_list));
+  (*poly).contour = (phi::funcs::gpc_vertex_list*)malloc(  // NOLINT
+      sizeof(phi::funcs::gpc_vertex_list));
   (*poly).contour->num_vertices = pts_num;
-  (*poly).contour->vertex =
-      (phi::funcs::gpc_vertex*)malloc(sizeof(phi::funcs::gpc_vertex) * pts_num);
+  (*poly).contour->vertex = (phi::funcs::gpc_vertex*)malloc(  // NOLINT
+      sizeof(phi::funcs::gpc_vertex) * pts_num);
   for (size_t i = 0; i < pts_num; ++i) {
     (*poly).contour->vertex[i].x = vec[i].x;
     (*poly).contour->vertex[i].y = vec[i].y;
diff --git a/paddle/phi/kernels/funcs/jit/gen_base.cc b/paddle/phi/kernels/funcs/jit/gen_base.cc
@@ -66,7 +66,9 @@ void* GenBase::operator new(size_t size) {
   return ptr;
 }
 
-void GenBase::operator delete(void* ptr) { posix_memalign_free(ptr); }
+void GenBase::operator delete(void* ptr) {
+  posix_memalign_free(ptr);  // NOLINT
+}
 
 std::vector<int> packed_groups(int n, int k, int* block_out, int* rest_out) {
   int block;
diff --git a/paddle/pir/core/op_info_impl.cc b/paddle/pir/core/op_info_impl.cc
@@ -119,7 +119,7 @@ void OpInfoImpl::Destroy() {
   }
   // (2) free memeory
   VLOG(10) << "Free base_ptr " << reinterpret_cast<void *>(base_ptr);
-  free(base_ptr);
+  delete base_ptr;
 }
 
 }  // namespace pir
diff --git a/paddle/pir/core/utils.cc b/paddle/pir/core/utils.cc
@@ -31,7 +31,7 @@ void *aligned_malloc(size_t size, size_t alignment) {
 #elif defined(_WIN32)
   return _aligned_malloc(size, alignment);
 #else
-  void *mem = malloc(size + alignment);
+  void *mem = malloc(size + alignment);  // NOLINT
   if (mem == nullptr) {
     return nullptr;
   }
@@ -50,7 +50,7 @@ void aligned_free(void *mem_ptr) {
   _aligned_free(mem_ptr);
 #else
   if (mem_ptr) {
-    free(*(reinterpret_cast<void **>(mem_ptr) - 1));
+    free(*(reinterpret_cast<void **>(mem_ptr) - 1));  // NOLINT
   }
 #endif
 }
diff --git a/paddle/testing/paddle_gtest_main.cc b/paddle/testing/paddle_gtest_main.cc
@@ -76,6 +76,6 @@ int main(int argc, char** argv) {  // NOLINT
 
   int ret = RUN_ALL_TESTS();
 
-  if (env_str) free(env_str);
+  if (env_str) free(env_str);  // NOLINT
   return ret;
 }

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ void* AlignedMalloc(size_t size, size_t alignment) {`
`32`	`32`	`#elif defined(_WIN32)`
`33`	`33`	`return _aligned_malloc(size, alignment);`
`34`	`34`	`#else`
`35`		`- void* mem = malloc(size + alignment);`
	`35`	`+ void* mem = malloc(size + alignment); // NOLINT`
`36`	`36`	`if (mem == nullptr) {`
`37`	`37`	`return nullptr;`
`38`	`38`	`}`
`@@ -51,7 +51,7 @@ void AlignedFree(void* mem_ptr) {`
`51`	`51`	`_aligned_free(mem_ptr);`
`52`	`52`	`#else`
`53`	`53`	`if (mem_ptr) {`
`54`		`- free((reinterpret_cast<void*>(mem_ptr) - 1));`
	`54`	`+ free((reinterpret_cast<void*>(mem_ptr) - 1)); // NOLINT`
`55`	`55`	`}`
`56`	`56`	`#endif`
`57`	`57`	`}`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ void NFD(const std::string& s, std::string* ret) {`
`48`	`48`	`utf8proc_NFD(reinterpret_cast<const unsigned char*>(s.c_str())));`
`49`	`49`	`if (result) {`
`50`	`50`	`*ret = std::move(std::string(result));`
`51`		`- free(result);`
	`51`	`+ free(result); // NOLINT`
`52`	`52`	`}`
`53`	`53`	`}`
`54`	`54`
Original file line number	Diff line number	Diff line change
`@@ -30,12 +30,12 @@ class RecordedAllocator : public Allocator {`
`30`	`30`	`protected:`
`31`	`31`	`phi::Allocation *AllocateImpl(size_t size) override {`
`32`	`32`	`allocated_size_ += size;`
`33`		`- return new Allocation(malloc(size), size, platform::CPUPlace());`
	`33`	`+ return new Allocation(malloc(size), size, platform::CPUPlace()); // NOLINT`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`void FreeImpl(phi::Allocation *allocation) override {`
`37`	`37`	`allocated_size_ -= allocation->size();`
`38`		`- free(allocation->ptr());`
	`38`	`+ free(allocation->ptr()); // NOLINT`
`39`	`39`	`delete allocation;`
`40`	`40`	`}`
`41`	`41`
`@@ -85,12 +85,12 @@ class LimitedResourceAllocator : public Allocator {`
`85`	`85`	`}`
`86`	`86`
`87`	`87`	`allocated_size_ += size;`
`88`		`- return new Allocation(malloc(size), size, platform::CPUPlace());`
	`88`	`+ return new Allocation(malloc(size), size, platform::CPUPlace()); // NOLINT`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`void FreeImpl(phi::Allocation *allocation) override {`
`92`	`92`	`allocated_size_ -= allocation->size();`
`93`		`- free(allocation->ptr());`
	`93`	`+ free(allocation->ptr()); // NOLINT`
`94`	`94`	`delete allocation;`
`95`	`95`	`}`
`96`	`96`
Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ void CPUAllocator::Free(void* p, size_t size, size_t index) {`
`114`	`114`	`#ifdef _WIN32`
`115`	`115`	`_aligned_free(p);`
`116`	`116`	`#else`
`117`		`- free(p);`
	`117`	`+ free(p); // NOLINT`
`118`	`118`	`#endif`
`119`	`119`	`}`
`120`	`120`
Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,7 @@ void Polys2MaskWrtBox(const std::vector<std::vector<float>>& polygons,`
`198`	`198`	`msk = mask;`
`199`	`199`	`} else {`
`200`	`200`	`msk = reinterpret_cast<uint8_t*>(`
`201`		`- malloc(M * M * polygons.size() * sizeof(uint8_t)));`
	`201`	`+ malloc(M * M * polygons.size() * sizeof(uint8_t))); // NOLINT`
`202`	`202`	`}`
`203`	`203`	`for (size_t i = 0; i < polygons.size(); ++i) {`
`204`	`204`	`int k = static_cast<int>(polygons[i].size() / 2);`
`@@ -224,7 +224,7 @@ void Polys2MaskWrtBox(const std::vector<std::vector<float>>& polygons,`
`224`	`224`	`}`
`225`	`225`	`}`
`226`	`226`	`}`
`227`		`- free(msk);`
	`227`	`+ free(msk); // NOLINT`
`228`	`228`	`}`
`229`	`229`	`}`
`230`	`230`