[clang-tidy][task 61] enable hicpp-exception-baseclass and fix existing errors (#55847)

SigureMo · web-flow · commit 31a9688868e0 · 2023-08-30T11:45:23.000+08:00
* [clang-tidy] enable `hicpp-exception-baseclass` and fix existing errors

* config

* update error format to pass the ci check (at least 20 chars)
diff --git a/.clang-tidy b/.clang-tidy
@@ -162,7 +162,7 @@ cppcoreguidelines-c-copy-assignment-signature,
 -cppcoreguidelines-pro-type-member-init,
 -cppcoreguidelines-slicing,
 -hicpp-avoid-goto,
--hicpp-exception-baseclass,
+hicpp-exception-baseclass,
 misc-unused-alias-decls,
 misc-unused-using-decls,
 modernize-avoid-bind,
diff --git a/paddle/fluid/framework/ir/mkldnn/reshape_transpose_matmul_mkldnn_fuse_pass.cc b/paddle/fluid/framework/ir/mkldnn/reshape_transpose_matmul_mkldnn_fuse_pass.cc
@@ -99,8 +99,8 @@ void ReshapeTransposeMatmulMkldnnFusePass::Fuse(
     } else if (matmul_desc->Inputs().at("Y").at(0) == input_var_name) {
       matmul_input_name = "Y";
     } else {
-      throw platform::errors::InvalidArgument("Unexpected input to " +
-                                              matmul_type + " encountered.");
+      PADDLE_THROW(platform::errors::InvalidArgument(
+          "Unexpected input to %s encountered.", matmul_type));
     }
 
     // Return if input of fused_matmul is already fused
