[clang-tidy] No.31 enable modernize-use-bool-literals (#56216)

enkilee · web-flow · commit 2c3074572f43 · 2023-08-14T17:43:08.000+08:00
diff --git a/.clang-tidy b/.clang-tidy
@@ -179,7 +179,7 @@ modernize-redundant-void-arg,
 -modernize-replace-random-shuffle,
 -modernize-shrink-to-fit,
 -modernize-unary-static-assert,
--modernize-use-bool-literals,
+modernize-use-bool-literals,
 modernize-use-emplace,
 modernize-use-equals-default,
 -modernize-use-equals-delete,
diff --git a/paddle/fluid/framework/hogwild_worker.cc b/paddle/fluid/framework/hogwild_worker.cc
@@ -213,7 +213,7 @@ void HogwildWorker::TrainFilesWithProfiler() {
 #if defined(PADDLE_WITH_GPU_GRAPH) && defined(PADDLE_WITH_HETERPS)
   device_reader_->InitGraphTrainResource();
 #endif
-  while (1) {
+  while (true) {
     cur_batch = device_reader_->Next();
 #if defined(PADDLE_WITH_GPU_GRAPH)
     if (is_multi_node) {
@@ -348,7 +348,7 @@ void HogwildWorker::TrainFiles() {
 #if defined(PADDLE_WITH_GPU_GRAPH) && defined(PADDLE_WITH_HETERPS)
   device_reader_->InitGraphTrainResource();
 #endif
-  while (1) {
+  while (true) {
     cur_batch = device_reader_->Next();
 #if defined(PADDLE_WITH_GPU_GRAPH)
     if (is_multi_node) {
diff --git a/paddle/fluid/framework/io/shell.cc b/paddle/fluid/framework/io/shell.cc
@@ -152,7 +152,7 @@ static int shell_popen_fork_internal(const char* real_cmd,
 
 static int read_from_pipe(FILE* fp, std::string* output) {
   std::array<char, 4096> buf;
-  while (1) {
+  while (true) {
     int n = fread(buf.data(), 1, 4096, fp);
     if (n <= 0) {
       break;
diff --git a/paddle/fluid/framework/ir/transfer_layout_elim_pass.cc b/paddle/fluid/framework/ir/transfer_layout_elim_pass.cc
@@ -153,7 +153,7 @@ bool TransferLayoutElimPass::AllInputIsTransferlayout(
   for (auto var : op_node->inputs) {
     // If this input is a 1D persistable tensor，we allow transfer_layout not
     // appear before this var, but temporarily diasble this if.
-    if (var->Var()->Persistable() && 0) {
+    if (var->Var()->Persistable() && false) {
       auto var_dims =
           scope->FindVar(var->Name())->GetMutable<phi::DenseTensor>()->dims();
       if (var_dims.size() == 1) {
diff --git a/paddle/fluid/framework/trainer.cc b/paddle/fluid/framework/trainer.cc
@@ -59,7 +59,7 @@ void TrainerBase::DumpWork(int tid) {
   // GetDumpPath is implemented in each Trainer
   std::string path = GetDumpPath(tid);
   std::shared_ptr<FILE> fp = fs_open_write(path, &err_no, dump_converter_);
-  while (1) {
+  while (true) {
     std::string out_str;
     if (!queue_->Get(out_str)) {
       break;
diff --git a/paddle/fluid/inference/analysis/ir_pass_manager.cc b/paddle/fluid/inference/analysis/ir_pass_manager.cc
@@ -328,10 +328,10 @@ void IRPassManager::CreatePasses(Argument *argument,
                     argument->nnadapter_model_cache_token()));
     } else if (pass_name == "fc_fuse_pass") {
       pass->Set("use_gpu", new bool(argument->use_gpu()));
-      bool fc_mkldnn_pass = 0;
+      bool fc_mkldnn_pass = false;
       for (const std::string &pass_n : passes) {
         if (pass_n == "fc_mkldnn_pass") {
-          fc_mkldnn_pass = 1;
+          fc_mkldnn_pass = true;
         }
       }
       bool use_fc_padding = !fc_mkldnn_pass && argument->use_fc_padding();
diff --git a/paddle/fluid/inference/api/analysis_predictor.cc b/paddle/fluid/inference/api/analysis_predictor.cc
@@ -1708,7 +1708,7 @@ CreatePaddlePredictor<AnalysisConfig, PaddleEngineKind::kAnalysis>(
     // TODO(NHZlX): Should add the link to the doc of
     // paddle_infer::CreatePredictor<paddle_infer::Config>
     if (config.glog_info_disabled()) {
-      FLAGS_logtostderr = 1;
+      FLAGS_logtostderr = true;
       FLAGS_minloglevel = 2;  // GLOG_ERROR
     }
 
diff --git a/paddle/fluid/inference/api/onnxruntime_predictor.cc b/paddle/fluid/inference/api/onnxruntime_predictor.cc
@@ -198,7 +198,7 @@ std::unique_ptr<PaddlePredictor>
 CreatePaddlePredictor<AnalysisConfig, PaddleEngineKind::kONNXRuntime>(
     const AnalysisConfig &config) {
   if (config.glog_info_disabled()) {
-    FLAGS_logtostderr = 1;
+    FLAGS_logtostderr = true;
     FLAGS_minloglevel = 2;  // GLOG_ERROR
   }
 
diff --git a/paddle/fluid/memory/allocation/buddy_allocator.cc b/paddle/fluid/memory/allocation/buddy_allocator.cc
@@ -282,7 +282,7 @@ BuddyAllocator::PoolSet::iterator BuddyAllocator::RefillPool(
 BuddyAllocator::PoolSet::iterator BuddyAllocator::FindExistChunk(size_t size) {
   size_t index = 0;
 
-  while (1) {
+  while (true) {
     auto it = pool_.lower_bound(IndexSizeAddress(index, size, nullptr));
 
     // no match chunk memory
diff --git a/paddle/fluid/operators/fused/fused_embedding_eltwise_layernorm_op.cc b/paddle/fluid/operators/fused/fused_embedding_eltwise_layernorm_op.cc
@@ -107,11 +107,11 @@ class EmbeddingEltWiseLayerNormOp : public framework::OperatorWithKernel {
       const framework::ExecutionContext& ctx) const override {
     auto inputs = ctx.MultiInput<phi::DenseTensor>("Embs");
     auto input_data_type = framework::proto::VarType::Type(0);
-    bool flag = 0;
+    bool flag = false;
     for (auto* input : inputs) {
       if (input->IsInitialized() && input->numel() > 0) {
         input_data_type = framework::TransToProtoVarType(input->dtype());
-        flag = 1;
+        flag = true;
         break;
       }
     }
diff --git a/paddle/fluid/operators/fused/fused_seqpool_cvm_op.cc b/paddle/fluid/operators/fused/fused_seqpool_cvm_op.cc
@@ -135,11 +135,11 @@ class FusedSeqpoolCVMOp : public framework::OperatorWithKernel {
       const framework::ExecutionContext& ctx) const override {
     auto inputs = ctx.MultiInput<phi::DenseTensor>("X");
     auto input_data_type = framework::proto::VarType::Type(0);
-    bool flag = 0;
+    bool flag = false;
     for (auto* input : inputs) {
       if (input->IsInitialized() && input->numel() > 0) {
         input_data_type = framework::TransToProtoVarType(input->dtype());
-        flag = 1;
+        flag = true;
         break;
       }
     }
diff --git a/paddle/fluid/operators/generator/get_expected_kernel_func.cc b/paddle/fluid/operators/generator/get_expected_kernel_func.cc
@@ -91,11 +91,11 @@ phi::KernelKey GetConcatExpectedKernelType(
   (void)op_ptr;
   auto inputs = ctx.MultiInput<phi::DenseTensor>("X");
   auto input_data_type = framework::proto::VarType::Type(0);
-  bool flag = 0;
+  bool flag = false;
   for (auto* input : inputs) {
     if (input->IsInitialized()) {
       input_data_type = framework::TransToProtoVarType(input->dtype());
-      flag = 1;
+      flag = true;
       break;
     }
   }
diff --git a/paddle/fluid/operators/partial_concat_op.cc b/paddle/fluid/operators/partial_concat_op.cc
@@ -93,11 +93,11 @@ class PartialConcatOp : public framework::OperatorWithKernel {
       const framework::ExecutionContext &ctx) const override {
     auto inputs = ctx.MultiInput<phi::DenseTensor>("X");
     auto input_data_type = framework::proto::VarType::Type(0);
-    bool flag = 0;
+    bool flag = false;
     for (auto *input : inputs) {
       if (input->IsInitialized()) {
         input_data_type = framework::TransToProtoVarType(input->dtype());
-        flag = 1;
+        flag = true;
         break;
       }
     }
diff --git a/paddle/fluid/operators/partial_sum_op.cc b/paddle/fluid/operators/partial_sum_op.cc
@@ -95,11 +95,11 @@ class PartialSumOp : public framework::OperatorWithKernel {
       const framework::ExecutionContext &ctx) const override {
     auto inputs = ctx.MultiInput<phi::DenseTensor>("X");
     auto input_data_type = framework::proto::VarType::Type(0);
-    bool flag = 0;
+    bool flag = false;
     for (auto *input : inputs) {
       if (input->IsInitialized()) {
         input_data_type = framework::TransToProtoVarType(input->dtype());
-        flag = 1;
+        flag = true;
         break;
       }
     }
diff --git a/paddle/phi/api/profiler/device_tracer.cc b/paddle/phi/api/profiler/device_tracer.cc
@@ -296,7 +296,7 @@ void CUPTIAPI bufferCompleted(CUcontext ctx,
       } else {
         CUPTI_CALL(status);
       }
-    } while (1);
+    } while (true);
 
     size_t dropped;
     CUPTI_CALL(
diff --git a/paddle/phi/kernels/funcs/gpc.cc b/paddle/phi/kernels/funcs/gpc.cc
@@ -2195,7 +2195,7 @@ void gpc_tristrip_clip(gpc_op op,
                                tn->active * sizeof(gpc_vertex),
                                const_cast<char *>("tristrip creation"));
         v = 0;
-        if (0) {
+        if (false) {
           lt = tn->v[RIGHT];
           rt = tn->v[LEFT];
         } else {

Original file line number	Diff line number	Diff line change
`@@ -328,10 +328,10 @@ void IRPassManager::CreatePasses(Argument *argument,`
`328`	`328`	`argument->nnadapter_model_cache_token()));`
`329`	`329`	`} else if (pass_name == "fc_fuse_pass") {`
`330`	`330`	`pass->Set("use_gpu", new bool(argument->use_gpu()));`
`331`		`- bool fc_mkldnn_pass = 0;`
	`331`	`+ bool fc_mkldnn_pass = false;`
`332`	`332`	`for (const std::string &pass_n : passes) {`
`333`	`333`	`if (pass_n == "fc_mkldnn_pass") {`
`334`		`- fc_mkldnn_pass = 1;`
	`334`	`+ fc_mkldnn_pass = true;`
`335`	`335`	`}`
`336`	`336`	`}`
`337`	`337`	`bool use_fc_padding = !fc_mkldnn_pass && argument->use_fc_padding();`
Original file line number	Diff line number	Diff line change
`@@ -1708,7 +1708,7 @@ CreatePaddlePredictor<AnalysisConfig, PaddleEngineKind::kAnalysis>(`
`1708`	`1708`	`// TODO(NHZlX): Should add the link to the doc of`
`1709`	`1709`	`// paddle_infer::CreatePredictor<paddle_infer::Config>`
`1710`	`1710`	`if (config.glog_info_disabled()) {`
`1711`		`- FLAGS_logtostderr = 1;`
	`1711`	`+ FLAGS_logtostderr = true;`
`1712`	`1712`	`FLAGS_minloglevel = 2; // GLOG_ERROR`
`1713`	`1713`	`}`
`1714`	`1714`
Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,7 @@ std::unique_ptr<PaddlePredictor>`
`198`	`198`	`CreatePaddlePredictor<AnalysisConfig, PaddleEngineKind::kONNXRuntime>(`
`199`	`199`	`const AnalysisConfig &config) {`
`200`	`200`	`if (config.glog_info_disabled()) {`
`201`		`- FLAGS_logtostderr = 1;`
	`201`	`+ FLAGS_logtostderr = true;`
`202`	`202`	`FLAGS_minloglevel = 2; // GLOG_ERROR`
`203`	`203`	`}`
`204`	`204`
Original file line number	Diff line number	Diff line change
`@@ -107,11 +107,11 @@ class EmbeddingEltWiseLayerNormOp : public framework::OperatorWithKernel {`
`107`	`107`	`const framework::ExecutionContext& ctx) const override {`
`108`	`108`	`auto inputs = ctx.MultiInput<phi::DenseTensor>("Embs");`
`109`	`109`	`auto input_data_type = framework::proto::VarType::Type(0);`
`110`		`- bool flag = 0;`
	`110`	`+ bool flag = false;`
`111`	`111`	`for (auto* input : inputs) {`
`112`	`112`	`if (input->IsInitialized() && input->numel() > 0) {`
`113`	`113`	`input_data_type = framework::TransToProtoVarType(input->dtype());`
`114`		`- flag = 1;`
	`114`	`+ flag = true;`
`115`	`115`	`break;`
`116`	`116`	`}`
`117`	`117`	`}`