[clang-tidy] enable bugprone-misplaced-widening-cast check (#56635)

gouzil · web-flow · commit 114217055e5d · 2023-08-29T10:38:13.000+08:00
diff --git a/.clang-tidy b/.clang-tidy
@@ -17,7 +17,7 @@ bugprone-exception-escape,
 bugprone-integer-division,
 -bugprone-macro-repeated-side-effects,
 -bugprone-misplaced-operator-in-strlen-in-alloc,
--bugprone-misplaced-widening-cast,
+bugprone-misplaced-widening-cast,
 -bugprone-move-forwarding-reference,
 -bugprone-multiple-statement-macro,
 -bugprone-narrowing-conversions,
diff --git a/paddle/phi/kernels/coalesce_tensor_kernel.cc b/paddle/phi/kernels/coalesce_tensor_kernel.cc
@@ -203,8 +203,9 @@ void CoalesceTensorKernel(const Context &dev_ctx,
   if (copy_data) {
     for (auto item : input) {
       size_t len = static_cast<size_t>(item->numel());
-      auto sub_tensor = fused_output->Slice(static_cast<int64_t>(offset),
-                                            static_cast<int64_t>(offset + len));
+      auto sub_tensor = fused_output->Slice(
+          static_cast<int64_t>(offset),
+          static_cast<int64_t>(offset) + static_cast<int64_t>(len));
       phi::Copy(dev_ctx, *item, dev_ctx.GetPlace(), false, &sub_tensor);
 
       offset += use_align
@@ -219,8 +220,9 @@ void CoalesceTensorKernel(const Context &dev_ctx,
   } else if (persist_output) {
     for (auto &item : output) {
       size_t len = static_cast<size_t>(item->numel());
-      auto sub_tensor = fused_output->Slice(static_cast<int64_t>(offset),
-                                            static_cast<int64_t>(offset + len));
+      auto sub_tensor = fused_output->Slice(
+          static_cast<int64_t>(offset),
+          static_cast<int64_t>(offset) + static_cast<int64_t>(len));
       // some var may not persistable, or persistable var may not init
       if (item->initialized()) {
         phi::Copy(dev_ctx, *item, dev_ctx.GetPlace(), false, &sub_tensor);
@@ -243,8 +245,9 @@ void CoalesceTensorKernel(const Context &dev_ctx,
     auto dim = output[i]->dims();
     VLOG(4) << len << " " << dim << " " << offset;
     output[i]
-        ->ShareDataWith(fused_output->Slice(static_cast<int64_t>(offset),
-                                            static_cast<int64_t>(offset + len)))
+        ->ShareDataWith(fused_output->Slice(
+            static_cast<int64_t>(offset),
+            static_cast<int64_t>(offset) + static_cast<int64_t>(len)))
         .Resize(dim);
     len = use_align ? phi::Alignment(
                           len * size_of_dtype, dev_ctx.GetPlace(), align_size) /
