| CARVIEW |
Select Language
HTTP/2 302
date: Tue, 15 Jul 2025 16:25:24 GMT
content-length: 0
location: https://github.com/NLnetLabs/unbound/pull/987
server-timing: nginx;desc="NGINX";dur=1.338862,glb;desc="GLB";dur=95.178964
x-voltron-version: 6a3bf42
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=ymQnCvc64AYE9D3GqnIX0CVZ88plI1hi0%2FQoY0B%2FuGZPQGYlvw7S2wdZhKVlccXrSypMsMKKdgXoo7pUWTHQxNAt9tikMZ2pQA%2FCQRq2EXybx%2BYCSG1k59S%2BIcx5wv4C6BMc5XYwWRMvDMkMO4McmqhVvHHhvk9%2BuFiRGjdikrrN65boWqr6hOarSX3qZLFieAaioOiAQl7bzOnPjdkZHINZxFG3YTuPFMgFikBlxhZaEpZ%2FLLMQcAPKUgWkooY3px2wU0xvTtAnbA3rYuXblg%3D%3D--MIwGDdc6caPg8DEb--%2BJvvCIYydY1kUUZj%2BfhSqA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1436246992.1752596723; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 16:25:23 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 16:25:23 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8A32:1CBC5F:4323E:4FA24:687680F3
HTTP/2 200
date: Tue, 15 Jul 2025 16:25:24 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=522.581791,conversation_content-fragment;desc="conversation_content fragment";dur=472.438279,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=305.007754,nginx;desc="NGINX";dur=0.907863,glb;desc="GLB";dur=98.322893
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: 8A32:1CBC5F:43290:4FA69:687680F3
skip edns frag retry if advertised udp payload size is not smaller by borisVanhoof · Pull Request #987 · NLnetLabs/unbound · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 397
skip edns frag retry if advertised udp payload size is not smaller #987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wcawijngaards
merged 1 commit into
NLnetLabs:master
from
borisVanhoof:skip_edns_frag_retry
Jan 5, 2024
Merged
skip edns frag retry if advertised udp payload size is not smaller #987
wcawijngaards
merged 1 commit into
NLnetLabs:master
from
borisVanhoof:skip_edns_frag_retry
Jan 5, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If serviced query is in UDP_EDNS_FRAG mode, and EDNS_ADVERTISED_SIZE is 1232 (the default) or more, then the retry will have the same edns udp payload size with the same result.
wcawijngaards
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is neat and well written. The reuse of the function makes is easier to read. Moving to retry at a smaller size that then is going to be the same value as before, is not useful for resolving the query. So this code change looks good to have.
|
Thank you for the patch! That should avoid unnecessary retries, since the flag day changes made the default edns size drop from 4096 to 1232, the size is not smaller in that retry any more. The code has been merged into the code repository. |
wcawijngaards
added a commit
that referenced
this pull request
Jan 5, 2024
- Merge #987: skip edns frag retry if advertised udp payload size is not smaller.
wcawijngaards
added a commit
that referenced
this pull request
Jan 5, 2024
|
Thank you. |
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Jan 7, 2024
* nlnet/master: (40 commits) - Fix unit test for NLnetLabs#987 change in udp1xxx retry packet send. Changelog note for NLnetLabs#987 - Merge NLnetLabs#987: skip edns frag retry if advertised udp payload size is not smaller. skip edns frag retry if advertised udp payload size is not smaller - Remove unneeded newlines and improve indentation in remote control code. - Fix NLnetLabs#983: Sha1 runtime insecure change was incomplete. Changelog note for NLnetLabs#985. - Merge NLnetLabs#985: Add DoH and DoT to dnstap message. Changelog note for NLnetLabs#979 and NLnetLabs#980. - Merge NLnetLabs#980: DoH: reject non-h2 early. To fix NLnetLabs#979: Improve errors for non-HTTP/2 DoH clients. Add DoH and DoT to dnstap message - Update example.conf with cookie options. DoH: reject non-h2 early Fixup doc/Changelog. - Fix root_zonemd unit test, it checks that the root ZONEMD verifies, now that the root has a valid ZONEMD. Changelog note for NLnetLabs#975 - Merge NLnetLabs#975: Fixed some syntax errors in rpl files. Fixed some syntax errors in rpl files. - Fix NLnetLabs#974: doc: default number of outgoing ports without libevent. - Use the origin (DNAME) TTL for syntesized CNAMEs as per RFC 6672. - Fix tests to use new common.sh functions, wait_logfile and kill_from_pidfile. - Update test script file common.sh. - Updated IPv4 and IPv6 address for b.root-servers.net in root hints. - iana portlist update. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Hi,
If a serviced query is in UDP_EDNS_FRAG mode, and EDNS_ADVERTISED_SIZE is 1232 (the default) or less, then the retry will have the same edns udp payload size with the same result.
This patch will, if the advertised udp payload size is not smaller, increase the retry count and continue until answer or no more targets to forward to.
I used this conf to test and the following firewall rule to drop responses and cause timeout net event.
I have added pre and post patch pcap files in pcapfiles.tar.gz. The pre file has 9 (I was expecting 10) requests to 8.8.8.8 and the post file has the expected 5 requests before servfail.
Kind regards and a happy new year 2024!