| CARVIEW |
Select Language
HTTP/2 302
date: Fri, 18 Jul 2025 19:55:28 GMT
content-length: 0
location: https://github.com/NLnetLabs/unbound/pull/826
server-timing: nginx;desc="NGINX";dur=1.430904,glb;desc="GLB";dur=95.935801
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=pBjBVJk9mJwLzIhpbCdHvQkaP6rr%2Buik6BhE1nz3nt2hTYEVvOL3uv3%2BiPzxdxlbGWnswFPYO9qOghVTeVbaltAHMb%2Bl75AzHtsRkk4n5DVoZ3i5PK9X7Kpo4nuE2gK5CoCJ6SX650wPphivyCKYUKtobkfgFxNVrBjj1jPsM44a97Zl0PQV2%2BGZJnVJnVPytleCWMq6b4A%2Buz4FWtW8qViQCCV2GGBOblrZar1rKKZl0nMsKU4SKABJb78EtkyAad8jSn2EvCd39F6dg2GXHQ%3D%3D--9nbPLCZlyClMKzLC--puRNfEHZ7P3N8GQQbzG56A%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1600078484.1752868528; Path=/; Domain=github.com; Expires=Sat, 18 Jul 2026 19:55:28 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 18 Jul 2026 19:55:28 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BA1E:115935:12A028:17B3D0:687AA6B0
HTTP/2 200
date: Fri, 18 Jul 2025 19:55:28 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=316.859233,conversation_content-fragment;desc="conversation_content fragment";dur=490.994472,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=248.761249,nginx;desc="NGINX";dur=0.595562,glb;desc="GLB";dur=95.886676
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: BA1E:115935:12A044:17B3F7:687AA6B0
Аdd a metric about the maximum number of collisions in lrushah by sakateka · Pull Request #826 · NLnetLabs/unbound · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 396
Аdd a metric about the maximum number of collisions in lrushah #826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wcawijngaards
merged 1 commit into
NLnetLabs:master
from
sakateka:lruhash_max_collisions
Jan 13, 2023
Merged
Аdd a metric about the maximum number of collisions in lrushah #826
wcawijngaards
merged 1 commit into
NLnetLabs:master
from
sakateka:lruhash_max_collisions
Jan 13, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcawijngaards
approved these changes
Jan 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good. This code can be added.
wcawijngaards
added a commit
that referenced
this pull request
Jan 13, 2023
- Merge #826: Аdd a metric about the maximum number of collisions in lrushah.
|
Thanks for the additional performance counter! Perhaps it can prevent other issues like this. I have merged it in to the code repository. Also documentation is added, for the statistics entries, do you like the text for it; it can be seen in the commit 469133e ? |
|
It looks very good, thank you! Perhaps it was worth writing |
wcawijngaards
added a commit
that referenced
this pull request
Jan 13, 2023
|
Okay, improved the wording to add that detail! Useful to know what amount is trouble. |
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Jan 15, 2023
* nlnet/master: - Improve documentation for NLnetLabs#826, describe the large collisions amount. Changelog note and documentation for NLnetLabs#826 - Merge NLnetLabs#826: Аdd a metric about the maximum number of collisions in lrushah. add a metric about the maximum number of collisions in lrushah Code repository continues with version 1.17.2. - Fix python version detection in configure. - Fix python module install path detection. Changelog note for 1.17.1rc2 fix. - Fix wildcard in hyperlocal zone service degradation, reported by Sergey Kacheev. This fix is included in 1.17.1rc2. - Fix wildcard in hyperlocal zone service degradation, reported by Sergey Kacheev. - Fix NLnetLabs#823: Response change to NODATA for some ANY queries since 1.12, tested on 1.16.1. Changelog note for tag for 1.17.1rc1. - Tag for 1.17.1 release. Add Mastodon link Add Mastodon - Update github workflows to use checkout v3. - Fix windows compile for libunbound subprocess reap comm point closes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
In continuation of the fix added here 90831af
I would like to suggest adding a metric about the maximum number of collisions that happened in lruhash.
This will be the best indicator of a similar problem in the future.