CARVIEW |
Select Language
HTTP/2 302
date: Tue, 15 Jul 2025 12:13:51 GMT
content-length: 0
location: https://github.com/NLnetLabs/unbound/pull/802
server-timing: nginx;desc="NGINX";dur=0.900668,glb;desc="GLB";dur=95.404757
x-voltron-version: 6a3bf42
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=masaWjYU2S4ZOQMRjk%2FWw3IiNSdTdqeXDsDH8CP36QuPhnT5m9cX8CzH8C0DMwh%2Bfq7Vv124Ej%2FAX8RAu6FLKlmgRrCbs0NzAvEdCCgnqnn3KAlkXw4uCTfZJopQNf9JIkeVS%2FUhulVtTOQaK0iChiY69Ma9Z3Gcw28aggyL%2FIdgAKw33UmbjIBueHvCtBvVtQ8AnywOxwDXZ1kXXqqmVoqoA99G4MUHbJKfVro%2BlLH0lC9Qw56QKicahT8%2BjICot9gWWm4aJtFL1GS4ogLHhA%3D%3D--ikyEpx5%2BX8NgU1H0--KVQd8THsdW39%2BuowhwpUyw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.770839790.1752581631; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 12:13:51 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 12:13:51 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E32C:18B7F5:8566C7:95EC77:687645FF
HTTP/2 200
date: Tue, 15 Jul 2025 12:13:52 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=320.040085,conversation_content-fragment;desc="conversation_content fragment";dur=473.438084,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=307.235314,nginx;desc="NGINX";dur=1.055481,glb;desc="GLB";dur=95.053519
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: E32C:18B7F5:856745:95ED09:687645FF
add validation EDEs to queries where the CD bit is set by TCY16 · Pull Request #802 · NLnetLabs/unbound · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 397
add validation EDEs to queries where the CD bit is set #802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcawijngaards
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me. Does not look like the cache-response code path adds a EDE when CD is set, but perhaps that is not an issue for this code change.
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Jul 15, 2023
* nlnet/master: (43 commits) - More clear description of the different auth-zone behaviors on the man page. - Merge NLnetLabs#880 from chipitsine: services/authzone.c: remove redundant check. - Merge NLnetLabs#664 from tilan7763: Add prefetch support for subnet cache entries. - For NLnetLabs#664: Easier code flow for subnetcache prefetching. - For NLnetLabs#664: Add testcase. - For NLnetLabs#664: Rename subnet_prefetch tests to subnet_global_prefetch to differentiate from the new subnet prefetch support. - For NLnetLabs#664: easier code flow for subnetcache prefetching. - For NLnetLabs#664: add testcase. - Skip the 00-lint test. splint is not maintained; it either does not work or produces false positives. Static analysis is handled in the clang test. - For NLnetLabs#802: Cleanup comments and add RCODE check for CD bit test case. - Fix dereference of NULL variable warning in mesh_do_callback. - Code cleanup for sldns_str2wire_svcparam_key_lookup. - Fix NLnetLabs#906: warning: ‘Py_SetProgramName’ is deprecated. - For NLnetLabs#739: minor cleanup for testcases. - More fixes for reference counting for python module and clean up failure code. - Fix python modules with multiple scripts, by incrementing reference counts. - Remove warning about unknown cast-function-type warning pragma. Add changelog and contrib/README mention for NLnetLabs#903 - Merge NLnetLabs#903: contrib: add yocto compatible init script. contrib: add yocto compatible init script Changelog for NLnetLabs#887 and NLnetLabs#516 - Properly handle all return values of worker_check_request during early EDE code. - Do not check the incoming request more than once. - Fix for uncertain unit test for doh buffer size events. Changelog note for NLnetLabs#895 - Fix NLnetLabs#895: python + sysconfig gives ANOTHER path comparing to distutils. - Merge NLnetLabs#896: Fix: NLnetLabs#895: pythonmodule: add all site-packages directories to sys.path. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
at the request of @rijswijk :)