You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* nlnet/master:
Fix use after free issue with edns options (NLnetLabs#663)
Change log entry for lines with blanks issue
- Remove unused LDNS function check for GOST Engine unloading.
- Note in the unbound.conf text that NOTIFY is allowed from the url: addresses for auth and rpz zones.
Changelog entry for NLnetLabs#688 - Merge PR NLnetLabs#688: Rpz url notify issue.
- Add testcase for allowing NOTIFY on URL addresses.
Test loading a zone with blank lines over https
Avoid network traffic during test, a bit of cleanup
Fix issue with lines that only consist of blanks with optional comment
Test loading a cached zone that has lines consisting of blanks
Add url 'master' to allow notify list
allow-notify doesn't work for url on rpz zones (NLnetLabs#679)
With unbound 1.16.2, using url: https://some.IP.v.4/path/filename.stuff
I can observe that this doesn't work and that I am still obliged to include an allow-notify line in the config for the rpz zone.
This should work without specifying an allow-notify if the IP the NOTIFY comes from is the same IP as "some.IP.v.4".
Also the qname of the NOTIFY needs to match the configured rpz zone name (I believe that is not your problem).
The testcase for this issue still works btw.
With verbosity 2 and above you would see something like the following in the log that may shed more light:
info: received NOTIFY for rpz. from 127.0.0.1 port 35684
info: refused NOTIFY for . from 127.0.0.1 port 34962
This is what I had in the config: url: https://a.b.c.d/mypath/myfile
Received a REJECT for the notify I sent from the same IP a.b.c.d.
Added an allow-notify: no error and the file was downloaded.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #679