| CARVIEW |
Select Language
HTTP/2 302
date: Wed, 16 Jul 2025 15:03:15 GMT
content-length: 0
location: https://github.com/NLnetLabs/unbound/pull/671
server-timing: nginx;desc="NGINX";dur=1.445855,glb;desc="GLB";dur=95.044963
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=87nuSl9zSjs6Pf%2FzYaWu1jL%2FyiPIexd5vzPi3R4IyzOwH0FFCZnrNdHSn3CttO0ADv4Tt%2FdSVe13iAEi5HHNTlXFA8nvpzUYGwGBMH1TYJJ%2FO5gbjAFAZM1mQB7brVUeFo1VAp6hScs5rpQ6gWzHJbgaejmvUd2WibNly7fnKvsSDXp3BiXJs0Yk034d4nrN49O0lOYMO3vDFcHy2qJNjzx3dCDKflahYJKy7v2BoTNOqTBwt2r80%2BGJJt1eUa4Z7RG67Q7suK4lYAdl62nA%2Bg%3D%3D--KF5fOLF5cj%2BKddlw--O565kN0p5SXPHHQZXb0Kvw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.581408159.1752678195; Path=/; Domain=github.com; Expires=Thu, 16 Jul 2026 15:03:15 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 16 Jul 2026 15:03:15 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: AE68:34075D:D8269E:10019F7:6877BF33
HTTP/2 200
date: Wed, 16 Jul 2025 15:03:16 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=336.386178,conversation_content-fragment;desc="conversation_content fragment";dur=578.063785,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=248.895269,nginx;desc="NGINX";dur=1.579861,glb;desc="GLB";dur=95.649845
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: AE68:34075D:D826D6:1001A49:6877BF33
Disable ED25519 and ED448 in FIPS mode on openssl3 by pemensik · Pull Request #671 · NLnetLabs/unbound · GitHub
pemensik
force-pushed
the
fips-mode-algo-ed25519
branch
from
April 27, 2022 18:57
pemensik
force-pushed
the
fips-mode-algo-ed25519
branch
from
May 11, 2022 14:23
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 397
Disable ED25519 and ED448 in FIPS mode on openssl3 #671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gthess
merged 1 commit into
NLnetLabs:master
from
InfrastructureServices:fips-mode-algo-ed25519
Jul 3, 2022
Merged
Disable ED25519 and ED448 in FIPS mode on openssl3 #671
gthess
merged 1 commit into
NLnetLabs:master
from
InfrastructureServices:fips-mode-algo-ed25519
Jul 3, 2022
+4,784
−6,519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pemensik
force-pushed
the
fips-mode-algo-ed25519
branch
from
7b2e3d2 to
32cce8a
Compare
|
What is FIPS mode for and how can it be used is written in RHEL documentation: https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/security_hardening/assembly_installing-a-rhel-8-system-with-fips-mode-enabled_security-hardening |
Both crypto functions are not allowed by FIPS 140-3. Use openssl 3.0 function to check FIPS mode presence and use it to make those algorithms unsupported.
pemensik
force-pushed
the
fips-mode-algo-ed25519
branch
from
32cce8a to
917c30a
Compare
|
Any comments for this change? |
|
Although the code LGTM, I find the change very implicit i.e., if "just fips" is set, disable those algorithms. |
Merged
|
It works around the resolution failure in FIPS mode: After this change the result in FIPS mode would switch just to insecure, but still to successful resolution. Of course unbound itself would be affected too. |
|
I expect FIPS mode is not enabled in openssl unless there is a reason for it to be. This might change once those algorithms are accepted by FIPS 140-3. It is expected they might and would be, but not clear when. This change can be reverted once they are acceptable. |
|
Making security worse for "compliance" is sad. |
gthess
added a commit
that referenced
this pull request
Jul 3, 2022
- Merge PR #671 from Petr Menšík: Disable ED25519 and ED448 in FIPS mode on openssl3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Both crypto functions are not allowed by FIPS 140-3. Use openssl 3.0
function to check FIPS mode presence and use it to make those algorithms
unsupported.
Would allow flawless fallback to insecure results for ED25519, ED448 and also SHA-1 algorithms.