CARVIEW |
Select Language
HTTP/2 302
date: Fri, 18 Jul 2025 04:46:34 GMT
content-length: 0
location: https://github.com/NLnetLabs/unbound/pull/605
server-timing: nginx;desc="NGINX";dur=0.723776,glb;desc="GLB";dur=95.206718
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=ubeQ9MslqCTsSVg5BNSvi9gTc9jr3GpHJ%2Blt66UpHr%2FvS8HLJkkmEoRQqMVM%2BS%2BkjnGL%2FgMcu%2F%2F5XUElalxlFZCuxmJPc6P8mulEfvo9%2B5922cx7G1qHiI3OZhqtH9kFI7FwD7ZxJ9n3Om34XdqyHwcdI48cPK6GuM253kl4xmENRHA%2B9aYKfZuuuUZjnU9tt%2BYmYB4yvHvjlEDwNVRbePGRJHhoQzS23MAIRvKu04H6XKMTbUo2NOUpPBnd4wI%2FbU3Px04Alz%2BvLGyQpMpaZw%3D%3D--MKdZ76TtFKT1xb3V--bEzpdoc5s99ABaY2sWocDA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.541875643.1752813994; Path=/; Domain=github.com; Expires=Sat, 18 Jul 2026 04:46:34 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 18 Jul 2026 04:46:34 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C4CA:99904:770EEC:962B6F:6879D1AA
HTTP/2 200
date: Fri, 18 Jul 2025 04:46:35 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=287.444718,conversation_content-fragment;desc="conversation_content fragment";dur=366.862756,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=203.382924,nginx;desc="NGINX";dur=1.274445,glb;desc="GLB";dur=95.424416
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: C4CA:99904:770F2E:962BBD:6879D1AA
Fix EDNS to upstream where the same option could be attached more than once by gthess · Pull Request #605 · NLnetLabs/unbound · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 397
Fix EDNS to upstream where the same option could be attached more than once #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+194
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
once. - Add a region to serviced_query for allocations.
gthess
added a commit
that referenced
this pull request
Jan 14, 2022
- Merge PR #605: Fix EDNS to upstream where the same option could be attached more than once.
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Jan 25, 2022
* nlnet/master: Changelog note for NLnetLabs#612: - Merge PR NLnetLabs#612: TCP race condition. - Fix NLnetLabs#588: Unbound 1.13.2 crashes due to p->pc is NULL in serviced_udp_callback. - Better bookkeeping when reclaiming the TCP buffer. - Mark waiting_tcp and serviced_query as being in the cb_and_decommission stage to signal later code about their state; prevents premature item deletion. Changelog note for NLnetLabs#610 - Fix NLnetLabs#610: Undefine-shift in sldns_str2wire_hip_buf. - Fix NLnetLabs#610: Undefine-shift in sldns_str2wire_hip_buf. - Add serviced_query timer to send upstream queries outside of the mesh flow to prevent race conditions. - For dnstap, do not wakeupnow right there. Instead zero the timer to force the wakeup callback asap. - For NLnetLabs#602: Allow the module-config "subnetcache validator cachedb iterator". - Add rpz: for-downstream: yesno option, where the RPZ zone is authoritatively answered for, so the RPZ zone contents can be checked with DNS queries directed at the RPZ zone. Changelog note for NLnetLabs#605: - Merge PR NLnetLabs#605: Fix EDNS to upstream where the same option could be attached more than once. - Make sure callback changes for EDNS are not lost. - Fix EDNS to upstream where the same option could be attached more than once. - Add a region to serviced_query for allocations.
wcawijngaards
added a commit
that referenced
this pull request
Feb 28, 2022
so that it is not state dependent, after the state fix of #605 for double EDNS options.
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Mar 14, 2022
* nlnet/master: (27 commits) Changelog note for NLnetLabs#644, move commands together for library binary. Make `install-lib` make target install the pkg-config file. - Fix configure for python to use sysutils, because distutils is deprecated. It uses sysutils when available, distutils otherwise. - Fix for NLnetLabs#637: fix integer overflow checks in sldns_str2period. - Fix NLnetLabs#637: Integer Overflow in sldns_str2period function. - Fix compile warnings for printf ll format on mingw compile. - Various fixes for NLnetLabs#632: variable initialisation, convert the qinfo to str once, accept trailing dot in the local-zone ipset option. Changelog entry for NLnetLabs#632 - Merge PR NLnetLabs#632 from scottrw93: Match cnames in ipset. - Added tests for ipset. - Fix pythonmod for change in iter_dp_is_useless function prototype. - Fix for edns client subnet option add fix in removal code, from review. - Fix edns client subnet to add the option based on the option list, so that it is not state dependent, after the state fix of NLnetLabs#605 for double EDNS options. Changelog entry for NLnetLabs#623: - Merge NLnetLabs#623 from rex4539: Fix typos. - Fix NLnetLabs#630: Unify the RPZ log messages. - Fix for NLnetLabs#633: updated fix with new text. - Fix NLnetLabs#633: Document unix domain socket support for unbound-control. - Fix check interface existence for support detection in remote lookup. - update Makefile dependencies. - Fix to detect that no IPv6 support means that IPv6 addresses are useless for delegation point lookups. Match cnames in ipset ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Also adds a region to serviced_query for allocations.