| CARVIEW |
Select Language
HTTP/2 302
date: Tue, 15 Jul 2025 06:01:04 GMT
content-length: 0
location: https://github.com/NLnetLabs/unbound/pull/521
server-timing: nginx;desc="NGINX";dur=0.885967,glb;desc="GLB";dur=107.148075
x-voltron-version: 6a3bf42
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=QuxAiVBtQlEXQXo8VUlWlOyspmWsG%2B9u1nWYViGf1Hy9vsLNnCWIp%2BzVe%2B70bZvhtC%2BiGxpjMnD3sqLWYvu2Hq57IXYX3ffOTHOhp%2BmPNWWIngTWm6KaRx%2BWZ9nVj8aFkBnyOtsbJPsp3hPyibEYvFReHYaEd%2FjSCjPZpUa4dB8lPPn8y8GekhLqDh4vIF9Fu5C2LzZ8o009VBlk7IkXX45Ha4%2F9gH4TkszYVkOpz%2BI%2Bb4r92FX8W9ju38XgqgqtQqEOxGdg%2F91cmzoedh%2BktA%3D%3D--yStvyV%2F7Rk0XwvqS--zmflr8KapBcGTAq0hTOezA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1611055221.1752559264; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 06:01:04 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 06:01:04 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C096:34F64F:1F85F2:24CC6E:6875EEA0
HTTP/2 200
date: Tue, 15 Jul 2025 06:01:05 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=308.224869,conversation_content-fragment;desc="conversation_content fragment";dur=439.74465,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=288.491931,nginx;desc="NGINX";dur=0.538959,glb;desc="GLB";dur=107.196894
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: C096:34F64F:1F8676:24CD07:6875EEA0
Update mini_event.c by liheng562653799 · Pull Request #521 · NLnetLabs/unbound · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 397
Update mini_event.c #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update mini_event.c #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When in heavy load, unbound opens many outside_network sockets for out going queries to delegation servers, which may result in a big fd(maxfd) value(for thread A 65500, for thread B 65501, for thread C ...). There are situations when thread A has a max fd num 65500 where maxfd is of course 65500, thread B has max fd num 20 for now but maxfd is still 65501. Though linux kernel checks whether maxfd+1 passed by select syscall is really the process' maxfd+1. Linux kernel can not tell maxfd+1 passed by thread B select syscall is much bigger(65501+1 or 65500+1 after trimed by kerne) than it should be (20+1). In this situation, when kernel do_select() for thread B, much work is wasted.
wcawijngaards
approved these changes
Aug 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to reduce the fd value when no longer high.
wcawijngaards
added a commit
that referenced
this pull request
Aug 12, 2021
- Merge #521: Update mini_event.c.
|
Thank you for the patch. That would help keep the maxfd lower value. |
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Aug 12, 2021
* nlnet/master: (37 commits) - Fix to print error from unbound-anchor for writing to the key file, also when not verbose. - For NLnetLabs#519: fix comments for doxygen. - For NLnetLabs#519: yacc and lex. And fix python bindings, and test program unbound-dnstap-socket. Changelog note for NLnetLabs#519 and example.conf edit - Merge NLnetLabs#519: Support for selective enabling tcp-upstream for stub/forward zones. - For NLnetLabs#519: note stub-tcp-upstream and forward-tcp-upstream in the example configuration file. Changelog note for NLnetLabs#523 - Merge NLnetLabs#523: fix: free() call more than once with the same pointer. Changelog note for NLnetLabs#521 - Merge NLnetLabs#521: Update mini_event.c. - Add test tool readzone to .gitignore. - And 1.13.2rc1 became the 1.13.2 with the fix for the python module build. The current code repository continues with version 1.13.3. fix: free() call more than once with the same pointer Update mini_event.c - Fix NLnetLabs#520: Unbound 1.13.2rc1 fails to build python module. Add (stub|forward)-tcp-upstream options which enable using tcp transport only for specified stub/forward zones For 1.13.2rc1. - Tag for 1.13.2 release. - Fix unit test zonemd_reload for use in run_vm. - Fix libnettle zonemd unit test. - Fix out of sourcedir run of zonemd unit tests. - Fix readzone compile under debug config. - Fix missing locks in zonemd unit test. - Fix static analysis warnings about localzone locks that are unused. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
When in heavy load, unbound opens many outside_network sockets for out going queries to delegation servers, which may result in a big fd(maxfd) value(for thread A 1200, for thread B 1201, for thread C ...).
There are situations when thread A has a max fd num 1200 where maxfd is of course 1200, thread B has max fd num 20 for now but maxfd is still 1201. Though linux kernel checks whether maxfd+1 passed by select syscall is really the process' maxfd+1. Linux kernel can not tell maxfd+1 passed by thread B select syscall is much bigger(1201+1 or 1200+1 after trimed by kerne) than it should be (20+1).
In this situation, when kernel do_select() for thread B, much work is wasted.