You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've prepared Dockerfile which enable to run tests in isolated environment with all needed tools. I hope it helps newbies like me to verify their PR.
While i was running
make longtest
i noticed some undeterministic behaviour (some tests ie. auth_https.tdir sometimes failed due to connection timeout to petal).
I found some problem in util/netevent.c which cause switching to reading phase before send http request due to incomplete ssl_handshake.
I have some comments for changes before being able to merge.
If something is not clear let me know.
I was hunting an ssl bug in windows and came to the same conclusion for the ssl handshake. May I ask how you stumbled upon this?
Thank You for review my PR. I observed problem with handshake while launching longtests in docker, i started digging and found ssl connection was waiting for response despite request wasn't send due to not finished handshake.
I merged actual master to my branch and verified that change ca67691 fixed also above problem - so i've reverted my changes in netevent.c. I've adjusted my code to other suggestions. Please let me know if i can improve something else.
Thanks, looks good to me!
Currently we are in code freeze for the upcoming release but I will merge this right after that.
Something that just came to mind, I am not sure about the portability of the -E option to grep. In most man pages I find online I see support for it but we will find out when testing on different platforms for the release. Worst case we convert it back to regular regular expression.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've prepared Dockerfile which enable to run tests in isolated environment with all needed tools. I hope it helps newbies like me to verify their PR.
While i was running
i noticed some undeterministic behaviour (some tests ie. auth_https.tdir sometimes failed due to connection timeout to petal).
I found some problem in util/netevent.c which cause switching to reading phase before send http request due to incomplete ssl_handshake.