| CARVIEW |
Select Language
HTTP/2 302
date: Tue, 15 Jul 2025 20:11:11 GMT
content-length: 0
location: https://github.com/NLnetLabs/unbound/pull/493
server-timing: nginx;desc="NGINX";dur=1.118315,glb;desc="GLB";dur=95.678299
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=kR%2BfCJhTHKbhj4Pk4u4qkDZKkgBodU4oKXDZDLGwNFZwZ2Dla72ImQ%2B3BVu%2FJg1wkCR8thvhfH%2BVOlNJuZgE7%2BL3MYKAsV8TiJxs0VQe6TbOPjnFdLMKGKr1gP%2BR9JVgGgkgpLKoYDV4rAWq%2FHQ%2FRhmTgQ1ekc2Os%2Ff53yprAAaB3xUgtoGFlVAxSl9XVpKIUqzodxaCxnYPD6dYese4QfIBZiwimy%2BfIBD8zqlDgJkkM9P6ncZQGyR%2BNENdkoegBsxvOSYE2%2BSqPkq%2B3UhPjw%3D%3D--z68v0V1v3C%2F8NFhm--8QunHr%2FZqiKNs5Iu5D8LHw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.917272476.1752610271; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 20:11:11 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 20:11:11 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C270:221E2C:115339:15F931:6876B5DF
HTTP/2 200
date: Tue, 15 Jul 2025 20:11:12 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=268.518713,conversation_content-fragment;desc="conversation_content fragment";dur=446.104996,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=209.066314,nginx;desc="NGINX";dur=1.291574,glb;desc="GLB";dur=95.374619
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: C270:221E2C:11535A:15F95E:6876B5DF
Fix generation of libunbound.pc by Jakker · Pull Request #493 · NLnetLabs/unbound · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 397
Fix generation of libunbound.pc #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcawijngaards
requested changes
Sep 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot just remove these flags for everyone, that would be wrong. From the link you cite, it seems like it needs to be removed if libcrypto and openssl are from the FreeBSD base system. And it should be present when openssl is from ports or on other systems. Thus also the patch, if deployed in the code repository of unbound, has to detect whether this is the FreeBSD base system openssl, before selecting the value of PC_CRYPTO_DEPENDENCY. In the link cited, the developer seems to suggest putting this diff in the package system of FreeBSD; and I guess that sort of detects what openssl is used; but may also be a Makefile that is used for both base system openssl and ports installed openssl.
|
However, is a requires line, and not the LIBS line, I misread that. Much less harmful if we remove that for everyone; they may compile without proper requirements, but the linking works fine if they have openssl somehow. So I guess, since it just drops the requirement checks from pkg-config, it won't fail the compile for a whole bunch of systems; so if you want I do not mind applying this change so the pkg-config file, in our contrib/ that is requested. |
wcawijngaards
approved these changes
Sep 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it solves matters as people suggest, I do not see compile failure inducing blockers.
gthess
added a commit
that referenced
this pull request
Dec 1, 2021
- Merge PR #493 from Jaap: Fix generation of libunbound.pc.
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Jan 13, 2022
* nlnet/master: (36 commits) - Add missing configure flags for optional features in the documentation. - Fix Unbound capitalization in the documentation. - Fix to pick up other class local zone information before unlock. - Allow local-data for classes other than IN to inherit a configured local-zone's type if possible, instead of defaulting to type transparent as per the implicit rule. - Add code similar to fix for ldns for tab between strings, for consistency, the test case was not broken. Continue with version 1.14.1 - Fix validator debug output about DS support, print correct algorithm. Changelog note for NLnetLabs#581 Fix -Wshadow Fix -Wmissing-prototypes by declaring functions static. - Fix compile warning for if_nametoindex on windows 64bit. - Fix doc/unbound.doxygen to remove obsolete tag warning. - configure is set to 1.14.0, and release branch. - Fix NLnetLabs#574: Review fixes for size allocation. - Fix NLnetLabs#454: listen_dnsport.c:825: error: ‘IPV6_TCLASS’ undeclared. Changelog note for NLnetLabs#530: - Merge PR NLnetLabs#530 from Shchelk: Fix: dereferencing a null pointer. Changelog note for NLnetLabs#522: - Merge PR NLnetLabs#522 from sibeream: memory management violations fixed. Changelog note for NLnetLabs#562: - Merge PR NLnetLabs#562 from Willem: Reset keepalive per new tcp session. Changelog note for NLnetLabs#555: - Merge PR NLnetLabs#555 from fobser: Allow interface names as scope-id in IPv6 link-local addresses. Changelog note for NLnetLabs#493: - Merge PR NLnetLabs#493 from Jaap: Fix generation of libunbound.pc. Changelog note for NLnetLabs#511: - Merge PR NLnetLabs#511 from yan12125: Reduce unnecessary linking. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
According to a PR at FreeBSD ports a broken libunbound.pc file is installed.
This is the proposed patch for it.