| CARVIEW |
Select Language
HTTP/2 302
date: Tue, 15 Jul 2025 06:01:29 GMT
content-length: 0
location: https://github.com/NLnetLabs/unbound/pull/491
server-timing: nginx;desc="NGINX";dur=1.412534,glb;desc="GLB";dur=97.455486
x-voltron-version: 6a3bf42
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=MKVcV8EPceM6hfR2XbDNh571q6fxhjgxvC09BSpuagho4wP5LdYO3jxOeHPWv4lOBtbDHPC2desvyzFuikKIA0LqOZMNyZMsmJW0b2syaTBWanxDloQnl42n9%2FOQlZu7mXuVw%2FVnuh8eAwPihCFDkl3zuEWNgQjJ9wbQ5esQMED%2Fh5RXHfY1jlijHi7fwyxt%2F5slZ6ioaBDneTMhrOyj%2BLgnNOnIvKWCe2CKcXg9CBrYnqgNHdvdZtVmHJwlHmrA2BnO7uj7Bnl1f6XgUSWMQA%3D%3D--h8ywH7Ilue3rv%2FL4--2G9itMpk82IAz2aX%2FoRiiw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1039867329.1752559289; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 06:01:29 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 06:01:29 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CC7E:6EAB:1FA176:24EACE:6875EEB9
HTTP/2 200
date: Tue, 15 Jul 2025 06:01:32 GMT
content-type: text/html; charset=utf-8
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
cache-control: no-cache
etag: W/"543889d39d78a59c29f8863ec1c21d12"
strict-transport-security: max-age=31536000; includeSubdomains; preload
x-frame-options: deny
x-content-type-options: nosniff
x-xss-protection: 0
referrer-policy: no-referrer-when-downgrade
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: CC7E:6EAB:1FA217:24EB7A:6875EEB9
Add SVCB and HTTPS types and handling according to draft-ietf-dnsop-svcb-https by TCY16 · Pull Request #491 · NLnetLabs/unbound · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 397
Add SVCB and HTTPS types and handling according to draft-ietf-dnsop-svcb-https #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtoorop
reviewed
May 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here a few things that I noticed immediately.
I'll continue review later...
wtoorop
requested changes
May 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issues with str2ipv4hint
Co-authored-by: Willem Toorop <willem@nlnetlabs.nl>
wtoorop
reviewed
May 21, 2021
wtoorop
reviewed
May 21, 2021
wtoorop
reviewed
May 21, 2021
Co-authored-by: Willem Toorop <willem@nlnetlabs.nl>
Also make internal auxilary functions static
wtoorop
reviewed
Jun 23, 2021
Co-authored-by: Willem Toorop <willem@nlnetlabs.nl>
wtoorop
reviewed
Jun 24, 2021
wtoorop
reviewed
Jun 24, 2021
wtoorop
reviewed
Jun 24, 2021
Co-authored-by: Willem Toorop <willem@nlnetlabs.nl>
wcawijngaards
approved these changes
Jul 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go ahead with this code, for some of the fixup, the stack overflow and shadowed variable, I would want to check if the nsd svcb code has the same issue and fix it there similarly.
Co-authored-by: Wouter Wijngaards <wcawijngaards@users.noreply.github.com>
…rams >= MAX_NUMBER_OF_SVCPARAMS)
wtoorop
reviewed
Jul 2, 2021
wtoorop
reviewed
Jul 2, 2021
wtoorop
reviewed
Jul 2, 2021
Co-authored-by: Willem Toorop <willem@nlnetlabs.nl>
wtoorop
approved these changes
Jul 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to go!
gthess
added a commit
that referenced
this pull request
Jul 5, 2021
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Jul 27, 2021
* nlnet/master: (175 commits) - Fix for older parsers for function call in serve expired get cached. - Another fix from lint for ignored return value. - Fix from lint for ignored return value. - Insert header into testcode/readzone.c, it was missing. - Introduce 'http-user-agent:' and 'hide-http-user-agent:' options. Revert "- With hide-version unbound also omits the version from http headers." - With hide-version unbound also omits the version from http headers. - review fix to remove duplicate error printout. - Fix unbound-control local_data and local_datas to print detailed syntax errors. - Fix spelling in localzone.h comment. - Fix spelling in doc/unbound.doxygen comment. - Fix for NLnetLabs#510: in depth, use ifdefs for windows api event calls. Don't call a function which hasn't been defined - iana portlist update. - Fix clang-analysis warnings for testcode/readzone.c. - Fix compiler warnings for NLnetLabs#491. - Fix Wunused-result compile warnings. changelog PR NLnetLabs#491 rename var to remove shadow variable Apply suggestions from code review ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Draft pull request for draft-ietf-dnsop-svcb-https