You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
val-max-restart is a bit awkward, maybe val-max-retries or val-retries-max would be nicer.
For now I went with how the #define was named. Let me know what you think, I'm happy to rename the option.
I did not regenerate the lexer and parser, I don't have the right versions for flex and bison around and it should be a separate commit anyway I guess?
I've also checked what other resolvers are doing by asking for sigexpired.bad-dnssec.wb.sidnlabs.nl A
bind: similar to unbound, seems to do even more work
powerdns-recursor: gives up after encountering the DNSKEY with expired RRSIG. This is what unbound will do with val-max-restart: 0.
knot-recurser: gives up after encountering the expired RRSIG for A, doesn't bother with the DNSKEY.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unbound tries very hard (up to 6 authoritative servers) to find a
validating answer. This is not always desirable, for example on high
latency links.