You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a proposed new option to allow a user to override the hardcoded MAX_RESTART_COUNT limit.
I looked at other PRs that added config options, please let me know if I'm missing anything. I've verified that with a test config file test.conf containing max-query-restarts: 9, I'm able to successfully resolve logincdn.msauth.net with unbound-host -C test.conf.
I keep running into the bug in #438 on the latest version of pfSense (CE 2.6.0 as of this writing). This pull request would let me resolve the issue myself. My only choice now is to use a different DNS resolver - other resolvers do not have this issue. I'm happy to replace unbound but I prefer to just tweak it to work with Microsoft logins.
Unbound users cannot control what Microsoft and CDNs do with CNAMEs. You've left us out in the cold with no solution. You need to allow this or create a real solution for #438. As it stands I cannot use Unbound with Microsoft services.
I have been running into this MAX_RESTART_COUNT issue for long. Silly enough, I have to create forward-zones for domains affected by this issue and forward the queries to external DNS resolver. This new option is very important and essential in my opinion, since I encounter this issue more and more frequently. Although not a scientific research, it seems a lot of CDNs are using longer and longer cname chain.
In the related issue #438, contributor of this project showed their reluctant to this change in Aug 2021. However, I would encourage the team to review this decision and hopefully merge this pull soon.
* nlnet/master:
- Updates for NLnetLabs#461 (Add max-query-restarts option).
- Expose 'max-sent-count' as a configuration option; the default value retains Unbound's behavior.
- Expose 'statistics-inhibit-zero' as a configuration option; the default value retains Unbound's behavior.
- Fix to wrap Makefile scripts directory in quotes for uninstall.
Changelog note for NLnetLabs#808 - Merge NLnetLabs#808: Wrap Makefile script's directory variables in quotes.
wrap directory variables in quotes
Fix date.
- FixNLnetLabs#773: When used with systemd-networkd, unbound does not start until systemd-networkd-wait-online.service times out.
- Clear documentation for interactivity between the subnet module and the serve-expired and prefetch configuration options.
- Add SVCB and HTTPS to the types removed by 'unbound-control flush'.
- FixNLnetLabs#782: Segmentation fault in stats.c:404.
Changelog entry for NLnetLabs#720
Document max-query-restarts option
Use max-query-restarts in iterative resolver
Add max-query-restarts to grammar and lexer
Add max-query-restarts config parameter
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #438
This is a proposed new option to allow a user to override the hardcoded MAX_RESTART_COUNT limit.
I looked at other PRs that added config options, please let me know if I'm missing anything. I've verified that with a test config file
test.conf
containingmax-query-restarts: 9
, I'm able to successfully resolve logincdn.msauth.net withunbound-host -C test.conf
.