You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"unbound-control stats" lists only query types that has been seen
after unbound restart. Munin requires list of all types ever seen,
or the generated graphs are mostly empty after restart.
Fix this by adding a state file with list of seen query types etc.
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time for this!
I have some questions inline before accepting this.
Not a munin user but I am worried if this change catches other users by surprise or if it is not relevant to other users.
Do you see value in having an environment variable to toggle this new behavior? Then based on the environment variable update_seentags() could just write the state content (filtered) to the seentags file and the old behavior is also kept by default.
Not a munin user but I am worried if this change catches other users by surprise or if it is not relevant to other users.
Do you see value in having an environment variable to toggle this new behavior? Then based on the environment variable update_seentags() could just write the state content (filtered) to the seentags file and the old behavior is also kept by default.
Old behavior has two fatal errors:
Munin reports error if you restart unbound (tag vanishes).
New tags will not be included to Munin's graph if they are not present at the first run of munin-async. So basically graph stays empty if you reboot and are using munin-async.
New behavior might include some tags that stays zero forever, but that should not matter. So no, I don't see any point including config option for switching between old/new.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most important fix is "fix statistics after unbound restart / server reboot". Other changes are mostly cosmetic.