CARVIEW |
Select Language
HTTP/2 302
date: Mon, 14 Jul 2025 23:51:16 GMT
content-length: 0
location: https://github.com/NLnetLabs/unbound/pull/420
server-timing: nginx;desc="NGINX";dur=1.090481,glb;desc="GLB";dur=97.441419
x-voltron-version: 6a3bf42
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=3KwKaWpmVi72MrL%2FD9fu%2B9szXlH0d3aSs4Xgsl8W8zqasQnmQ7Qr9FxB30YZyMSbenvoBeyXsvy7KHM3EdbWTzGhZ8hrqzLVNBDb1G571cTJ8JNXb49rL9rMqMb7e6SlffaCV0rCNCGn8%2Bh1n9WbjNb2XW5vOWy%2BTPgTWF%2BEENqoOnRKV3vhWEO8R5gF4Ou1GYj%2BNoo1TpV9r2BdzI%2BbCqCIGWllZvYfiQk84yrGDsVLYBYA4xMuCMDVkRu5v%2FTLdVv77e5r1CCfKInaAhYbFQ%3D%3D--v2f6bQfLwMkq9L%2BR--2%2BF4E87WodB%2BA4YhwJoDsQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.321680737.1752537076; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 23:51:16 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 23:51:16 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9E26:3151B:FB0FE:175DC6:687597F4
HTTP/2 200
date: Mon, 14 Jul 2025 23:51:17 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=242.04556,conversation_content-fragment;desc="conversation_content fragment";dur=403.747702,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=227.846917,nginx;desc="NGINX";dur=1.289366,glb;desc="GLB";dur=95.798335
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: 9E26:3151B:FB110:175DE8:687597F4
DOH not responsing with "http2_query_read_done failure" logged by dyunwei · Pull Request #420 · NLnetLabs/unbound · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 396
DOH not responsing with "http2_query_read_done failure" logged #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#386 I found the root cause of this issue. r_buffer is r->query_reply.c->buffer, used to fill the reply in the mesh_send_reply function, then call comm_point_send_reply, and then call http2_submit_dns_response to send the DOH response. However, the buffer is not cleared after use. If the query length is greater than the last response length, the next dns query in the same H2 session will encounter an error. This is bug!!! Clear the buffer after use.
synchronize the code.
wcawijngaards
added a commit
that referenced
this pull request
Feb 10, 2021
- Merge PR #420 from dyunwei: DOH not responsing with "http2_query_read_done failure" logged.
Thanks! That looks good, merged it into the code repository. |
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Feb 17, 2021
* nlnet/master: Fix NLnetLabs#426: Replace _Py_fopen() with fopen() in pythonmod.c - Fix to make tests work with support indicators set for iterator. - Fix NLnetLabs#422: IPv6 fallback issues when IPv6 is not properly enabled/configured. Changelog note for PR NLnetLabs#420 - Merge PR NLnetLabs#420 from dyunwei: DOH not responsing with "http2_query_read_done failure" logged. Update netevent.c
dyunwei
pushed a commit
to dyunwei/unbound
that referenced
this pull request
Aug 3, 2021
clear the c->buffer in the comm_point_send_reply does resolve the "can't fit qbuffer in c->buffer" issue, but it breaks the mesh reply list function that need to reuse the answer. because the c->buffer is cleared in the comm_point_send_reply, it cannot be resued again. it means that it is not inappropriate to clear c->buffer in the comm_point_send_reply. After some investigation, i found it is appropriate to clear c->buffer before use in the http2_query_read_done.
wcawijngaards
added a commit
that referenced
this pull request
Aug 3, 2021
#420 breaks the mesh reply list function that need to reuse the dns answer.
hanazuki
added a commit
to ruby-no-kai/rubykaigi-net
that referenced
this pull request
Apr 14, 2023
v1.13.1 has a problem in DoH connection handling. See NLnetLabs/unbound#420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
I found that Unbound will drop normal queries when DOH is enabled. After some investigation i have found the root cause.
In function mesh_query_done, assign r->query_reply.c->buffer to r_buffer, and then call mesh_send_reply. The r_buffer is used to fill the dns reply in the mesh_send_reply function. then call comm_point_send_reply, and then call http2_submit_dns_response to send the DOH response. However, the buffer is not cleared after use. If the query length is greater than the last response length, the next dns query in the same H2 session will be dropped, and then the debug message "http2_query_read_done failure: can't fit qbuffer in c->buffer" be logged.
Clear the buffer after use can fix the issue.