CARVIEW |
Navigation Menu
-
-
Notifications
You must be signed in to change notification settings - Fork 397
Add start_time to reply callbacks so modules can compute the response⦠#391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The struct timeval should be passed with a ptr instead of a structure function argument. This is much easier for function signature, also for dynamic libraries and different compilers. The python start time calculation has a casting issue, losing fractions. Indentation (but that may be because of the view here). I approve of the changes, allows modules to access more information. The callbacks get either 0 or the value from the packet if also packets exist for that query, but that seems fine now, not really a need to add a timer value to the callbacks.
- Merge PR #391 from fhriley: Add start_time to reply callbacks so modules can compute the response time.
Thanks for the patch! Applied with a number of small changes. |
As an aside, the cast in the python start time looks like it was fine upon a further look; but I added explicit casts. |
* nlnet/master: (33 commits) rpl tests for nsid example.conf.in entry for nsid - Fix declaration before statement and signed comparison warning in dns64. - Fix NLnetLabs#404: DNS query with small edns bufsize fail. Changelog entry for NLnetLabs#402. - Merge NLnetLabs#402 from fobser: Implement IPv4-Embedded addresses according to RFC6052. Implement IPv4-Embedded addresses according to RFC6052. - Fix for NLnetLabs#93: dynlibmodule import library is named libunbound.dll.a. - Fix for NLnetLabs#93: dynlibmodule link fix for Windows. Nicer changelog note for NLnetLabs#399 - Merge NLnetLabs#399 from xiangbao227: The lock of lruhash table should unlocked after markdel entry. Changelog note for NLnetLabs#399 - Merge NLnetLabs#399 from xiangbao227: The function rrset_cache_touch can touch an entry to the lru while markdelling the entry in lruhash_remove. I found that in function lruhash_remove, table was locked at first ,then lru_remove the entry , then unlock the table, and then markdel entry , but in function rrset_cache_touch , the entry will be touched to lru again before markdelling entry in function lruhash_remove. This is a bug! And man page documentation for them. - Fix so local zone types always_nodata and always_deny can be used from the config file. - Fix NLnetLabs#397: [Feature request] add new type always_null to local-zone similar to always_nxdomain. - Fix clang analysis warning. - Add comment documentation. - For NLnetLabs#391: more double casts in python start time calculation. - For NLnetLabs#391: fix indentation. - For NLnetLabs#391: use struct timeval* start_time for callback information. Changelog note for NLnetLabs#391 - Merge PR NLnetLabs#391 from fhriley: Add start_time to reply callbacks so modules can compute the response time. ...
β¦ time.