| CARVIEW |
Select Language
HTTP/2 302
date: Mon, 14 Jul 2025 23:52:53 GMT
content-length: 0
location: https://github.com/NLnetLabs/unbound/pull/284
server-timing: nginx;desc="NGINX";dur=1.267891,glb;desc="GLB";dur=95.760007
x-voltron-version: 6a3bf42
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=pUOCs886PsW%2F%2FVxVSkFoSKicqn0vCfvxhf4Xn9%2F7G%2B6aIbkwP4Rif4WSbOHN6aDOsn59PsPKRq%2F1erhASQ0phcogZlRvB76WUr87TDFZKFcCOJyrtDNFNAbHgbeuclU%2F1NEEjJIls0W1dxpMKHUIwZYY%2FBYsA0omhec1IY2YF3nYbRbqvY14cNb8dlTzK7OS78kdWrnpv5f8ZqHwp4bsZc4rH%2Fe2M6sKDyExNYvUwgCK6Cq9syqMumDkFsEbhiKwZZTgOz8pmIalDwA4EWjyGQ%3D%3D--S2zAPgGqPrkXtawn--waIrY2cVywHH%2FHShA2TiLg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1604073547.1752537173; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 23:52:53 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 23:52:53 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9C5C:1BAFF9:F9E86:1757E1:68759855
HTTP/2 200
date: Mon, 14 Jul 2025 23:52:54 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=241.496317,conversation_content-fragment;desc="conversation_content fragment";dur=474.528324,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=216.51367,nginx;desc="NGINX";dur=1.164818,glb;desc="GLB";dur=97.452901
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: 9C5C:1BAFF9:F9E9B:175803:68759855
DLV removal by wcawijngaards · Pull Request #284 · NLnetLabs/unbound · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 396
DLV removal #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
DLV removal #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gthess
approved these changes
Aug 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I especially like the warnings for the configuration options.
ralphdolmans
approved these changes
Aug 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
val_stub_noroot.rpl still sets a dlv-anchor. No big deal as it is not needed for the test to succeed.
No other comments, looks good to me.
|
Thanks for the reviews, fixed the comments and merged it. |
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Sep 2, 2020
* nlnet/master: (37 commits) - Fix NLnetLabs#296: systemd nss-lookup.target is reached before unbound can successfully answer queries. Changed contrib/unbound.service.in. - Refactor to use sock_strerr shorthand function. - Merge PR NLnetLabs#293: Add missing prototype. Also refactor to use the new shorthand function to clean up the code. Add missing prototype. - Review fix, doxygen and assign null in case of error free. Please doxygen, quote the characters to stop it from parsing a doxygen command. - Similar to NSD PR#113, implement that interface names can be used, eg. something like interface: eth0 is resolved at server start and uses the IP addresses for that named interface. - Update documentation in python example code. - Change configure to use EVP_sha256 instead of HMAC_Update for openssl-3.0.0. - Fix to apply chroot to dnstap-socket-path, if chroot is enabled. - Fix that dnstap reconnects do not spam the log with the repeated attempts. Attempts on the timer are only logged on high verbosity, if they produce a connection failure error. - Fix stats double count issue (NLnetLabs#289). - Create and init edns tags data for libunbound. Changelog note. - Rerun autoconf Rerun autoconf and autoheader on configure.ac, with libtool Add changlog entry for PR NLnetLabs#277. - Check for existence 'EVP_MAC_CTX_set_params' function (openssl >= 3.0.0-alpha5) - Fix NLnetLabs#287: doc typo: "Additionaly". Changelog note for NLnetLabs#246 and NLnetLabs#284 - Merge PR NLnetLabs#284 and Fix NLnetLabs#246: Remove DLV entirely from Unbound. The DLV has been decommisioned and in unbound 1.5.4, in 2015, there was advise to stop using it. The current code base does not contain DLV code any more. The use of dlv options displays a warning. dlv removal, remove DLV reference from unused use in test case. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This set of commits removes DLV support from Unbound. DLV has been decommissioned and we advised to stop using it, now it is removed. The config options for it print a warning.