CARVIEW |
Select Language
HTTP/2 302
date: Tue, 15 Jul 2025 08:10:32 GMT
content-length: 0
location: https://github.com/NLnetLabs/unbound/pull/269
server-timing: nginx;desc="NGINX";dur=0.965521,glb;desc="GLB";dur=95.358408
x-voltron-version: 6a3bf42
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=a0eVew3eFHgv6O4Srt7GXUQjENKPra4ryxovrDxaZ7GOOf3QkPLM8P16CJq2mgKnklIYSOU9z1AC%2Bdt1NSlAlK4Ur38oOPOZYWllvDGCBRJoec4LuXw9SqxLHLvV%2BIp9hwkODYYHnGZ5zxOtE15Jg2UuB1lo84mZFdhG5oFr0CvQZdlhsE8xP0lmGp%2FN8YdwMhiCdPl6fbOsUqG%2B7yaCIeaVDOZYySWCRLGAUllXVJoxAZpZkmW9mo1PNdfd90xdgFPzmGecENzV4QI5PpbZFA%3D%3D--GL%2FpLKWqZIx8Y9d9--hai4SdI2J6dBF3VX7CFFJw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.83836989.1752567032; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 08:10:32 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 08:10:32 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B6A4:23A3E6:4296D2:4B9577:68760CF8
HTTP/2 200
date: Tue, 15 Jul 2025 08:10:33 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=261.563182,conversation_content-fragment;desc="conversation_content fragment";dur=345.033806,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=209.58371,nginx;desc="NGINX";dur=0.736054,glb;desc="GLB";dur=107.43804
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: B6A4:23A3E6:429736:4B95E9:68760CF8
Fix python module len() implementations by tobbez · Pull Request #269 · NLnetLabs/unbound · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 397
Fix python module len() implementations #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were all missing the 'self.' prefix when accessing the 'obj' instance variable, causing the following exception when attempting to call len() on (for example) a ReplyInfo_RRSet: File "/usr/lib/python3.7/site-packages/unboundmodule.py", line 377, in __len__ def __len__(self): return obj.rrset_count NameError: name 'obj' is not defined
Thanks! I'll merge this after the 1.11 release. |
ralphdolmans
added a commit
that referenced
this pull request
Jul 27, 2020
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Jul 27, 2020
* nlnet/master: (30 commits) Changelog note for PR NLnetLabs#270 - Merge PR NLnetLabs#270 from cgzones: munin plugin: always exit 0 in autoconf - Merge PR NLnetLabs#269, Fix python module len() implementations, by Torbjörn Lönnemark - branch now named 1.11.1. 1.11.0rc1 became the 1.11.0 release. munin plugin: always exit 0 in autoconf Fix python module len() implementations draft-ietf-dnsop-serve-stale-10 has become RFC 8767 on March 2020 - branch now named 1.11.0 and 1.11.0rc1 tag. - Fix contrib/fastrpz.patch to apply cleanly. It fixes for changes due to added libdynmod, but it does not compile, it conflicts with new rpz code. - Fix contrib/fastrpz.patch to apply cleanly. - Fix contrib/fastrpz.patch to apply cleanly. - Fix streamtcp to print packet data to stdout. This makes the stdout and stderr not mix together lines, when parsing its output. - Fix lock dependency cycle in rpz zone config setup. - Fix libnettle compile for session ticket key callback function changes. - Merge PR NLnetLabs#234 - Ensure proper alignment of cmsg buffers by Jérémie Courrèges-Anglas. - Fix PR NLnetLabs#234 log_assert sizeof to use union buffer. - Fix unused variable warning for clang analyzer. - Fix check conf test for referencing installation paths. - Changelog entry for PR NLnetLabs#265; include-toplevel. Change unbound-dnstap-socket void cast for unused parameter - Add changelog entry for bidirectional frame streams support. correct byte count in comment ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
They were all missing the
self.
prefix when accessing theobj
instance variable, causing the following exception when attempting to
call
len()
on (for example) aReplyInfo_RRSet
: