| CARVIEW |
Select Language
HTTP/2 302
date: Thu, 17 Jul 2025 00:33:57 GMT
content-length: 0
location: https://github.com/NLnetLabs/unbound/pull/200
server-timing: nginx;desc="NGINX";dur=1.047864,glb;desc="GLB";dur=95.823793
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=nr49cggjCeIcrWM%2Be3msc0zkYWS0vq060xi%2BOc0cT5HzIanT%2Fbt%2BNET%2F5SUCY7p51jI%2BxPaxX%2FoFIeLhkpzXgl%2BehCRFwrHCqFahnrEvsauMs%2BAREiNFPw0vWV9M6N5DDJN5wEnW%2FfwEBcOSBxXLvCivI%2Fagz3g4aT93qiatYHDDFsqYGA7T1YhlfuhQN4FiITpf2VjmXI6lA7OoR%2FDqfFbgNtx39FMzzeUqFxlPB2xRtWJNyhCixUp78JiX64vcMmbzSI%2FM8JSaAujZZptYcw%3D%3D--EhwjH%2BZ6e9nc%2FU7W--V%2FzOMylR7oF8BEdjaQVmBQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.366010284.1752712437; Path=/; Domain=github.com; Expires=Fri, 17 Jul 2026 00:33:57 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 17 Jul 2026 00:33:57 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B7CE:D1CE1:2B760:4480E:687844F5
HTTP/2 200
date: Thu, 17 Jul 2025 00:33:58 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=326.473551,conversation_content-fragment;desc="conversation_content fragment";dur=514.125002,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=226.745978,nginx;desc="NGINX";dur=1.286517,glb;desc="GLB";dur=96.158486
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: B7CE:D1CE1:2B772:4482A:687844F5
add ip-dscp option to specify the DSCP tag for outgoing packets by yarikk · Pull Request #200 · NLnetLabs/unbound · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 397
add ip-dscp option to specify the DSCP tag for outgoing packets #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcawijngaards
approved these changes
Mar 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, I'll make some modifications after merge. What is it useful for to set the DSCP tag on DNS traffic?
wcawijngaards
added a commit
that referenced
this pull request
Mar 24, 2020
- Merge PR #200 from yarikk: add ip-dscp option to specify the DSCP tag for outgoing packets.
|
Did you really mean with the case fallthrought to set both IPv6 and IPv4 TOS on IPv6 sockets? I now fixed it to set IPv6 for IPv6 sockets and IPv4 for IPv4 sockets. But the initial code has a case statement fallthrough which makes IPv4 TOS for IPv6 sockets in addition to the IPv6 socket TCLASS. |
wcawijngaards
added a commit
that referenced
this pull request
Mar 24, 2020
wcawijngaards
added a commit
that referenced
this pull request
Mar 24, 2020
|
Thanks for the contribution! Merged it and some code alterations. Please let me know about the fallthrough so we can be sure to set the right socket options. I am also curious what it is used for. |
|
@wcawijngaards Thanks for accepting and the follow-up fixes! It is useable in QoS settings to differentiate the control-plane traffic like DNS and ensure is not pushed off the queues by the regular data traffic. As for the fall though, thanks for the catch: it went under the radar. Let me verify if it works the same way with the breaks in place. |
|
@wcawijngaards Back-ported the fall-through fix – confirmed to work as intended. Thanks! |
|
Cool that you tested it, that is very nice. Another bug removed by code review :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Summary
DSCP, the Differentiated Services codepoint, is a field in the IP header packets used for QoS. It replaces the obsolete TOS field in IPv4 and the Traffic Class field in IPv6, per RFC 3260.
Let's add ip-dscp server option to specify an integer value to be passed to
setsockopt(…, IP_TOS, …)for every internet-family socket created, effectively enabling the QoS tagging of all outgoing packets.Testing
Parsing of the new option confirmed with unbound-checkconf on
testdata/04-checkconf.tdir/good.allandtestdata/04-checkconf.tdir/bad.dscp.A back-port to 1.9.6 was baked on production systems; the fact the outgoing traffic gets tagged is confirmed with tcpdump and other network monitoring tools:
cc @ralphdolmans @chantra