CARVIEW |
Select Language
HTTP/2 302
date: Thu, 17 Jul 2025 00:42:46 GMT
content-length: 0
location: https://github.com/NLnetLabs/unbound/pull/1078
server-timing: nginx;desc="NGINX";dur=0.564973,glb;desc="GLB";dur=96.39294
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=d0HWP9du%2ByMFdYPH9GBQ0jUicozl98yOfpQiILhtbdZvmQmxMQWLocrvymJ54XmVzms5gyXDe7gewDgEncCnOB7iDLChQSlE2pQuPJI8w55uT9Yfhrs7ZlxXBuCngxWNNF4fVahRIDMqdKUyO023NqidHeVoruCIBXzcYj35%2BtPFSBR47LrNoLMFl36kZCfV4KSnaIlOcV8BbG%2FkYMeYEO5NN6086OLpd%2F3MeTKzVx7IcbimNHY81qyhExyEuKep9%2BMt7c4%2FCora5QHu2Q9qWA%3D%3D--spK2rFzNan81ASEW--aIC0kk1i9xR3Y3ow0ls0SA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1939804139.1752712966; Path=/; Domain=github.com; Expires=Fri, 17 Jul 2026 00:42:46 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 17 Jul 2026 00:42:46 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 89C4:802AE:3169B:4EFAC:68784706
HTTP/2 200
date: Thu, 17 Jul 2025 00:42:47 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=212.045323,conversation_content-fragment;desc="conversation_content fragment";dur=367.703302,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=217.275823,nginx;desc="NGINX";dur=1.012976,glb;desc="GLB";dur=95.012014
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: 89C4:802AE:316B6:4EFD5:68784706
Only check old pid if no username by vopatek · Pull Request #1078 · NLnetLabs/unbound · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 397
Only check old pid if no username #1078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do as the comment says and only check old pid if there is no username configured.
wcawijngaards
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is good, and fixes an oversight.
wcawijngaards
added a commit
that referenced
this pull request
May 29, 2024
- Merge #1078: Only check old pid if no username.
Thank you for the fix! The comment was correct and indicates what should happen, the bugfix helps detect past failures. |
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Jun 16, 2024
* nlnet/master: (35 commits) - Add unit test for validation of repeated use of a DNAME record. - Fix validation for repeated use of a DNAME record. - Fix typos for 'the the' in text. - Fix memory leak in setup of dsa sig. - Skip unbound-dnstap-socket unit test when not compiled with --enable-debug. - Fix to squelch connection reset by peer errors from log. And fix that the tcp read errors are labeled as initial for the first calls. - Fix memory leak on exit for unbound-dnstap-socket; creates false negatives during testing. - Fix memory leak when reload_keep_cache is used and num-threads changes. - Enable AddressSanitizer error detection in tdir tests. - Fix for NLnetLabs#1079: fix RPZ taglist in iterator callback that no client info is like no taglist intersection. - Fix NLnetLabs#1079: tags from tagged rpz zones are no longer honored after upgrade from 1.19.3 to 1.20.0. Changelog note for NLnetLabs#1078. - Merge NLnetLabs#1078: Only check old pid if no username. Only check old pid if no username - Update patch to remove 'command' shell builtin and update error text. unbound-control-setup: check openssl - Fix unused variable warning on compilation with no thread support. - Fix spelling of tcp-idle-timeout docs, from Michael Tokarev. - Fix to enable that SERVFAIL is cached, for a short period, for more cases. In the cases where limits are exceeded. Changelog entry for NLnetLabs#1059: - Fix NLnetLabs#1059: Intermittent DNS blocking failure with local-zone and always_nxdomain. Addition of local_zones dynamically via unbound-control was not finding the zone's parent correctly. Proper parent identification for dynamically entered local zones (NLnetLabs#1076) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Do as the comment says and only check old pid if there is no username configured.