You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commits adjust the fix to have a different error text, for the user. Also the same check is repeated at the other code path where the port number is parsed and inserted into the array. It then also adds a check so that high numbers are limited to the 65536 array size, to stop it from taking a long time.
Thank you for the fixes! This stops unbound from having trouble with malformed input causing invalid accesses.
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Apr 4, 2024
* nlnet/master: (24 commits)
- FixNLnetLabs#369: dnstap showing extra responses; for client responses right from the cache when replying with expired data or prefetching.
- FixNLnetLabs#1035: Potential Bug while parsing port from the "stub-host" string; also affected forward-zones and remote-control host directives.
- For NLnetLabs#1040: adjust error text and disallow negative ports in other parts of cfg_mark_ports.
Changelog note for NLnetLabs#1040 - FixNLnetLabs#1040: fix heap-buffer-overflow issue in function cfg_mark_ports of file util/config_file.c.
fix heap-buffer-overflow issue in function cfg_mark_ports of file util/config_file.c
- Fix for crypto related failures to have a better error string.
- FixNLnetLabs#1034: DoT forward-zone via unbound-control.
- Fix that the server does not chown the pidfile.
- Fix that when the server truncates the pidfile, it does not follow symbolic links.
- Fix to add unit test for lruhash space that exercises the routines.
- Fix comment in lruhash space function.
- Fix for NLnetLabs#1032, add safeguard to make table space positive.
- FixNLnetLabs#1032: The size of subnet_msg_cache calculation mistake cause memory usage increased beyond expectations.
- Fix name of unit test for subnet cache response.
- For NLnetLabs#831: Format text, use exclamation icon and explicit label names.
Changelog entry for NLnetLabs#831 - Merge NLnetLabs#831 from Pierre4012: Improve Windows NSIS installer script (setup.nsi).
Improve Windows NSIS installer script (setup.nsi) (NLnetLabs#831)
- Fix localdata and rpz localdata to match CNAME only if no direct type match is available.
- Fix rpz so that rpz CNAME can apply after rpz CNAME. And fix that clientip and nsip can give a CNAME.
- Fix rpz for qtype CNAME after nameserver trigger.
...
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1039