| CARVIEW |
Select Language
HTTP/2 302
date: Mon, 14 Jul 2025 23:54:38 GMT
content-length: 0
location: https://github.com/NLnetLabs/unbound/pull/1028
server-timing: nginx;desc="NGINX";dur=0.933425,glb;desc="GLB";dur=96.606413
x-voltron-version: 6a3bf42
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=mx8bs9vQ6%2B1FqdeIpj6CJ%2F66r0z3CyrxslYr%2Bx351DfnQdhFZ6bAzORodddYVPWQA0dddMcpq058oGnAPMSdkzie53qvKjBsq4WBX9yebS3xS8nJdvS8RS8qfC%2FPsSgH3PKqd64lOHuRQihphXrJ3ECb%2FjIm4nQWQcG053715BrNmjvutja8%2F%2FZlneUbQcd%2FlWSGEi%2B1V%2FG62eXxNHk8ufOC1Z4gb8DVl4wVb1kCVE49w%2BI5gnwvj4svoiGDSwPBnddnZPFGE2eRCeyqYofi6Q%3D%3D--VOZMXSg3xBF2LQco--svExbfU56bvGTMe6Sb8G1A%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.622161939.1752537278; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 23:54:38 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 14 Jul 2026 23:54:38 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D0B4:2140BE:FBA96:1781F3:687598BE
HTTP/2 200
date: Mon, 14 Jul 2025 23:54:39 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=278.103436,conversation_content-fragment;desc="conversation_content fragment";dur=596.038404,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=219.527278,nginx;desc="NGINX";dur=0.970657,glb;desc="GLB";dur=96.576769
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: D0B4:2140BE:FBAAA:178216:687598BE
Clearer documentation for tcp-idle-timeout and edns-tcp-keepalive-timeout by gthess · Pull Request #1028 · NLnetLabs/unbound · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 396
Clearer documentation for tcp-idle-timeout and edns-tcp-keepalive-timeout #1028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edns-tcp-keepalive-timeout.
wcawijngaards
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text looks good to me. And also accurately describes what the option configures.
ximon18
reviewed
Mar 12, 2024
doc/unbound.conf.5.in
Outdated
| The period Unbound will wait for a query on a TCP connection when | ||
| EDNS TCP Keepalive is active. If this timeout expires Unbound closes | ||
| the connection. If the client supports the EDNS TCP Keepalive option, | ||
| Overrides \fBtcp\-idle\-timeout\fR when EDNS TCP Keepalive is active. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps "active" is a word commonly used in the Unbound documentation and its meaning is clear, but my concern here would be is it clear that "active" means "edns-tcp-keepalive = yes" rather than say "the current request included an edns-tcp-keepalive option or some other interpretation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ximon18 fair comment, is the new text better?
ximon18
approved these changes
Mar 12, 2024
ximon18
approved these changes
Mar 12, 2024
gthess
added a commit
that referenced
this pull request
Mar 12, 2024
- Merge #1028: Clearer documentation for tcp-idle-timeout and edns-tcp-keepalive-timeout.
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Mar 17, 2024
* nlnet/master: - For windows build, persist the openssl and expat directories for repeated builds while debugging. - Fix that addrinfo is not kept around but copied and freed, so that log-destaddr uses a copy of the information, much like NSD does. - The code repository continues with version 1.19.4. - Fix rpz for cname override action after nsdname and nsip triggers. - Fix to unify codepath for local alias for rpz cname action override. - Fix rpz that the rpz override is taken in case of clientip triggers. Fix that the clientip passthru action is logged. Fix that the clientip localdata action is logged. Fix rpz override action cname for the clientip trigger. - Fix NLnetLabs#1029: rpz trigger clientip and action rpz-passthru not working as expected. Changelog entry for NLnetLabs#1028: - Merge NLnetLabs#1028: Clearer documentation for tcp-idle-timeout and edns-tcp-keepalive-timeout. Clearer documentation for tcp-idle-timeout and edns-tcp-keepalive-timeout (NLnetLabs#1028) - Fix NLnetLabs#1021 Inconsistent Behavior with Changing rpz-cname-override and doing a unbound-control reload. Update doc/Changelog to note the fixes included in 1.19.3rc2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
No description provided.