| CARVIEW |
Select Language
HTTP/2 302
date: Tue, 15 Jul 2025 16:21:45 GMT
content-length: 0
location: https://github.com/NLnetLabs/unbound/pull/1019
server-timing: nginx;desc="NGINX";dur=1.116549,glb;desc="GLB";dur=95.699438
x-voltron-version: 6a3bf42
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=%2Bxza7vetPHrbwZtFBUZpqFGbDrJisUKuZeW51Z5yu4pkrLOKJt4G80kV9w4PHkGt54mOq21aZsNSldmcZOWZE%2FkyJrWd8bvNYqMb9gcjTudXJ%2BbkswzZth1fa5Y6zdwvt9I9TcbuqgRnWlUSr7YTKFTDmVXTZHbx%2BVswQ%2FoRliPC7sCgjtVI0KUCL8PHlIbcN9usmoN3500HHQqDUtcp1AMIZCjE6I3mJ%2FRAex20C80f3fGKVJZdW1%2Fq1%2FbcqnMQvB%2Bnm6JakPb4qpXW%2BzMqiQ%3D%3D--rk3Fyp2PIampzxJ2--o314SGMRHw0lX4Nm8EM3GA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1167753685.1752596505; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 16:21:45 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 16:21:45 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A8EA:15B66D:3AF59:458FF:68768019
HTTP/2 200
date: Tue, 15 Jul 2025 16:21:46 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=340.476196,conversation_content-fragment;desc="conversation_content fragment";dur=1005.591226,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=274.955781,nginx;desc="NGINX";dur=0.683232,glb;desc="GLB";dur=94.963275
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: A8EA:15B66D:3AF8D:45945:68768019
Redis read-only replica support by gthess · Pull Request #1019 · NLnetLabs/unbound · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 397
Redis read-only replica support #1019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gthess, does this imply this workaround for dockerized Unbound ain't necessary anymore then? |
|
Hi @madnuttah, I am not sure what the workaround is in that link but I see no relation with this feature. This feature adds support for Unbound to issue all read commands to a Redis replica server, offloading most of the of the work from the main Redis server which will only be issued write commands. |
|
Thanks for making it clear! |
|
There was some time investment to bring this up to speed with recent changes so I think it is time to merge to avoid the same time investment in the future. |
wcawijngaards
approved these changes
Apr 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks okay! Nice to have a unit test for redis.
Co-authored-by: Wouter Wijngaards <wcawijngaards@users.noreply.github.com>
|
Thanks for the review and catching the context bug! |
gthess
added a commit
that referenced
this pull request
Apr 4, 2025
- Merge #1019: Redis read-only replica support. Introduces new 'redis-replica-*' options for the Redis cache backend.
jedisct1
added a commit
to jedisct1/unbound
that referenced
this pull request
Apr 24, 2025
* nlnet/master: (49 commits) - Tag for 1.23.0rc2. This became the release of 1.23.0 on 24 April 2025. The code repository continues with 1.23.1 in development. - Increase default to `num-queries-per-thread: 2048`, when unbound is compiled with libevent. It makes saturation of the task queue more resource intensive and less practical. Thanks to Shiming Liu, Network and Information Security Lab, Tsinghua University for the report. Changelog entry for NLnetLabs#1265: - Merge NLnetLabs#1265: Fix WSAPoll. Fix WSAPoll (NLnetLabs#1265) Changelog entry for NLnetLabs#1265: - Merge NLnetLabs#1265: Fix WSAPoll. Fix WSAPoll (NLnetLabs#1265) - Fix for print of connection type in log-replies for dot and doh. - Fix NLnetLabs#1264: unbound 1.22.0 leaks memory when doing DoH. - Fix to detect if atomic_store links in configure. - Fix fast_reload to print chroot with config file name. - Update to the manpage for the fast_reload part. - Tag for 1.23.0rc1. - More explicit text about memory usage during fast_reload. Changelog entry for NLnetLabs#902: - Merge NLnetLabs#902: DNS Error Reporting (RFC 9567). Introduces new configuration option 'dns-error-reporting' and new statistics for 'num.dns_error_reports'. DNS Error Reporting (RFC 9567) (NLnetLabs#902) - Fix to update common.sh for speed of kill_pid. - Fix test to speed up common.sh script kill_pid. Fix typo in Changelog entry. Changelog entry for NLnetLabs#1019: - Merge NLnetLabs#1019: Redis read-only replica support. Introduces new 'redis-replica-*' options for the Redis cache backend. - Fix redis_replicat test for unused option defaults and log printout. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This PR introduces a Redis replica server next to an Redis server that is assumed to be in read-only mode.
If configured, Redis read commands will go there while write commands will go to the non-replica server.
All connectivity options are duplicated for the replica server.
Redis tests are not yet implemented.