| CARVIEW |
Select Language
HTTP/2 302
date: Thu, 17 Jul 2025 02:51:49 GMT
content-length: 0
location: https://github.com/NLnetLabs/nsd/pull/91
server-timing: nginx;desc="NGINX";dur=0.653968,glb;desc="GLB";dur=94.80792
x-voltron-version: fd8fbbc
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=rwyqo0gel3hLi%2FNmkvIwdjAXl6AjI6mR1YnzNQeC9XMrGqcwAVxeQp5MbN1%2Fp%2FaqM%2BGpGOY7%2FMxAsQ%2B%2FvZ2e5UPUhqq8%2FagruXxNTiHCUvI4ZzVx7giaVlBi1rMqce%2FdGZbEoXqvys4O%2Fj7gVsuUyrVH%2BzPm0wRcPeu%2BVZnF9w00I09LdSTqK%2FXzVnu28t89Dm6yrT59NQVC6BA05ZNDJWzvGxFogoBaEsjf%2FNiOby4Q5dmQS9fIwm8ufIgeEaJ19ns1a3%2BYWCf0Ir0plJfw5w%3D%3D--Z4GA89CXxeQ%2FBpex--ePxHkd3Uem3jo3vEIURTdw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1127579272.1752720709; Path=/; Domain=github.com; Expires=Fri, 17 Jul 2026 02:51:49 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 17 Jul 2026 02:51:49 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E268:26D0D3:BE313:11DEEE:68786545
HTTP/2 200
date: Thu, 17 Jul 2025 02:51:50 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=267.849685,conversation_content-fragment;desc="conversation_content fragment";dur=634.991321,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=236.431557,nginx;desc="NGINX";dur=0.741503,glb;desc="GLB";dur=95.129506
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: E268:26D0D3:BE331:11DF15:68786545
nsd-control-setup recreate certificates by gearnode · Pull Request #91 · NLnetLabs/nsd · GitHub
gearnode
changed the title
fix nsd-control-setup is not idempotent
nsd-control-setup recreate certificates
Apr 3, 2020
gearnode
force-pushed
the
idempotent-nsd-control-setup
branch
3 times, most recently
from
April 6, 2020 23:25
gearnode
force-pushed
the
idempotent-nsd-control-setup
branch
from
April 6, 2020 23:41
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 112
nsd-control-setup recreate certificates #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wcawijngaards
merged 3 commits into
NLnetLabs:master
from
gearnode:idempotent-nsd-control-setup
Apr 7, 2020
Merged
nsd-control-setup recreate certificates #91
wcawijngaards
merged 3 commits into
NLnetLabs:master
from
gearnode:idempotent-nsd-control-setup
Apr 7, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gearnode
changed the title
|
Not a bad idea, but the resign is so that it is again valid for $DAYS. The change would make it so people cannot resign. Not sure why to have it then? |
|
The intent is to make |
|
Sure that would work fine. Why do you need it to be idempotent, then? What needs to run this script again and again? Trying to understand what you need from it, the solution looks fine (or an option for that use case, if that is somehow different from create certificates or resign certificates). |
|
I have idempotent script to bootstrap my servers, and this script exec |
gearnode
force-pushed
the
idempotent-nsd-control-setup
branch
3 times, most recently
from
629e2b9 to
0b840bc
Compare
gearnode
force-pushed
the
idempotent-nsd-control-setup
branch
from
0b840bc to
23d7858
Compare
|
I have add |
wcawijngaards
approved these changes
Apr 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The -r option is good to have and otherwise it'll create the certificates until they all exist, which is what a lot of startup, or, install, scripts need.
wcawijngaards
added a commit
that referenced
this pull request
Apr 7, 2020
- Merge PR #91 by gearnode: nsd-control-setup recreate certificates. The '-r' option recreates certificates. Without it it creates them if they do not exist, and does not modify them otherwise.
gearnode
pushed a commit
to gearnode/nsd
that referenced
this pull request
May 3, 2020
- Merge PR NLnetLabs#91 by gearnode: nsd-control-setup recreate certificates. The '-r' option recreates certificates. Without it it creates them if they do not exist, and does not modify them otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
The current behavior do not recreate private keys, but the script recreate certificate. I propose to not recreate the certificate (like private key) when certificate already exist.
If you are ok with the patch, i will open the same patch on unbound.