| CARVIEW |
Select Language
HTTP/2 302
date: Tue, 15 Jul 2025 08:44:47 GMT
content-length: 0
location: https://github.com/NLnetLabs/nsd/pull/86
server-timing: nginx;desc="NGINX";dur=0.673776,glb;desc="GLB";dur=100.412871
x-voltron-version: 6a3bf42
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=rHj%2FRswO6RpHy0PlWhY7RcPhvE67HZZ2QPv%2Fq%2BpTLYWNaaVadyN2Qzqxg93PtMHl3r6k5OY4o6cKbcwKZhJqoxhZMABdTSyquUvyfyhZSGETkUdPmJT9YwmQgaYffel1p7K71bH7zPqluiXkadYBuXB4fSCkPQNW0LTx%2Fx3ZMl6cH%2FHov44hv%2BH%2FHZrcpN3VTdw2grGDoet7lYovKUUwfi45g0BdgW4HZY%2BnjoxI0W2kkIBYHJwrt7hg0YXqBDqK4DpciF%2FJDIJ0DB3W40FMcg%3D%3D--MgI%2B4rtwlWUkakss--97zRmxt1riNQfmTw5a3OMg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.451826928.1752569087; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 08:44:47 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 08:44:47 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BF44:1D9B45:4A5098:5459CB:687614FF
HTTP/2 200
date: Tue, 15 Jul 2025 08:44:48 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=325.039423,conversation_content-fragment;desc="conversation_content fragment";dur=571.676097,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=238.687626,nginx;desc="NGINX";dur=1.294774,glb;desc="GLB";dur=109.097714
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: BF44:1D9B45:4A510A:545A42:687614FF
Use precious variables for GREP, EGREP, SED, AWK, LEX and YACC by noloader · Pull Request #86 · NLnetLabs/nsd · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 112
Use precious variables for GREP, EGREP, SED, AWK, LEX and YACC #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcawijngaards
added a commit
that referenced
this pull request
Mar 25, 2020
- Merge PR #86 from noloader: Use precious variables for GREP, EGREP, SED, AWK, LEX and YACC. - For PR #86: Fix that programs loaded after CFLAGS and stuff is set, specifically the compiler, so that it can work if it needs special flags from that. Fix that lex only needs to support -i if actually defined, otherwise the output included in the source tarball can be used.
wcawijngaards
approved these changes
Mar 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review is okay, but want changes (which I committed already).
|
Thanks for the PR! This is nice to have these tests, I wanted to change two things. The C compiler want to test that later so that environment can continue to get set up, in case it needs special variables, CFLAGS. So I moved those lines down a bit. For the -i test, only if LEX is there, otherwise if it is "" or ":" we can use the flex and bison output included in source tarballs that we distribute for NSD. |
|
No problems @wcawijngaards. The code keeps improving. That's what matters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This PR uses precious variables for GREP, EGREP, SED, AWK, LEX and YACC. The PR eases building NSD on platforms like Solaris. The PR will make no difference on platforms like Linux.
The precious variables means
configurewill allow the user to override them in the environment, or find the best replacement usingAC_PROG_SED,AC_PROG_AWK,AC_PROG_GREPand friends. The variables are then used in theMakefile.in.Sun managed to provide some tools that are more anemic then Posix. Avoiding the anemic tools (like
egrep) and using the more featured tools (likeggrep -E) resolves most build errors on Solaris.Also see Issue 85, configure.ac and Makefile.in hard codes tools.