CARVIEW |
Select Language
HTTP/2 302
date: Tue, 15 Jul 2025 13:01:13 GMT
content-length: 0
location: https://github.com/NLnetLabs/nsd/pull/59
server-timing: nginx;desc="NGINX";dur=1.070769,glb;desc="GLB";dur=101.422673
x-voltron-version: 6a3bf42
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=YNr3QflgmthlDU2uTNFTkHc%2B2hG8PrI%2BnG4ilqJB6A2DpLQcfsc1m52EUEBzwcovBF5hX1vc53%2B2HqLZpfE6h57s7H4BDT30daClOgsTksw8x7m3zdNFgUkjylR7pWvIi0QrtV4TX7C9OchBoWeO5PKjZqcdW9GarXWvXIJ0f94eHD4k9SyycPUuzvq3JwRzC0yDNsp6MZf3UThE6xu5zAvAz80FdpMOVA0%2FXDvZRXdRZIX9fY%2BQQNf4ZhOPcnnwpM8aIrdIhMxlRKZpHXZpFg%3D%3D--5Y%2FsDPpuTXZVSboy--Hz0Q16ujOJRhmPYyi23S0w%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1515380513.1752584473; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 13:01:13 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 13:01:13 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 926C:1B37C1:917BE5:A37917:68765119
HTTP/2 200
date: Tue, 15 Jul 2025 13:01:14 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=328.837606,conversation_content-fragment;desc="conversation_content fragment";dur=536.541647,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=296.408908,nginx;desc="NGINX";dur=1.19818,glb;desc="GLB";dur=95.759069
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: 926C:1B37C1:917C6F:A379A9:68765119
add FreeBSD support for conf key ip-transparent by buddyns · Pull Request #59 · NLnetLabs/nsd · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 112
add FreeBSD support for conf key ip-transparent #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcawijngaards
approved these changes
Jan 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me. Thank you for the platform portable code!
wcawijngaards
added a commit
that referenced
this pull request
Jan 13, 2020
- Merge pull request #59 from buddyns: add FreeBSD support for conf key ip-transparent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This patch implements configuration option "ip-transparent" on FreeBSD (IPv4 and IPv6). Please notice the following:
setsockopt()
lines for each different name. This wasn't scalable; this patch uses one linear implementation based on generic macro name, which are resolved to platform-specific socket option names by some pre-processor code upfront. (see comment in code for more details). To add support for a platform with yet a different socket option name, simply define macros the respective macros accordingly.NSD_SOCKET_OPTION_TRANSPARENT6
andNSD_SOCKET_OPTION_TRANSPARENT_OPTLEVEL6
accordingly.nsd.conf
describes theip-freebind
andip-transparent
options, seemingly for the same purpose. They are also implemented with same code. This patch only refactors theip-transparent
implementation. Admittedly we did not put much effort into reversing what difference :) if equivalent, consider removing one of the options; if not, consider clarifying the difference in the man page.