| CARVIEW |
Select Language
HTTP/2 302
date: Tue, 15 Jul 2025 06:17:23 GMT
content-length: 0
location: https://github.com/NLnetLabs/nsd/pull/281
server-timing: nginx;desc="NGINX";dur=1.084168,glb;desc="GLB";dur=107.095105
x-voltron-version: 6a3bf42
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=hoPC8BmZ5H8W8MoVpsJivPPDjGeefouf6342v8Os8DoOsGNfnCOZqUfPDUOO9w0CGoWqmQJtdyFdTvoHpqK5sza0ir3p2UUaT3P6%2FmZexewr9TYEoxkIGdwb%2FSxGuAw%2BxHV5LJPoUEsOfok69dVimErxoVPPKL%2F4Pi7eOj6A8K0S1ynZ934Zmk05EVs%2BkMaNTF48vsTuidfOTG289s4RY2zJLhzQumZzZUfw4vJwsDKoHzZfs9xx3kaZcR2ATS57o48I3RFXkbnVmDRx7O%2BNTQ%3D%3D--67gXdya4NabedB2J--VDMQ2gTaqOtFJgp6kY3hVg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.711451677.1752560243; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 06:17:23 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 15 Jul 2026 06:17:23 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D010:292D83:22DC7F:285D93:6875F273
HTTP/2 200
date: Tue, 15 Jul 2025 06:17:25 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=406.998486,conversation_content-fragment;desc="conversation_content fragment";dur=1785.873018,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=442.864392,nginx;desc="NGINX";dur=0.882983,glb;desc="GLB";dur=109.246011
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 6a3bf42
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: D010:292D83:22DD11:285E2D:6875F273
Proxy protocol by wcawijngaards · Pull Request #281 · NLnetLabs/nsd · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 112
Proxy protocol #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Proxy protocol #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c and proxy_protocol.h.
…address. Fix for printout of refusal in log.
k0ekk0ek
approved these changes
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small remarks about things that stood out. Nothing blocking.
|
Hi, |
|
Hi @pettai, it's waiting for one more review to complete. Expect this to be merged soon. |
|
I noted an issue #297 then merging this branch to the latest git version of NSD, so apart from the review, this also needs to be fixed before merging. Thx |
…r_remaining(data->query->packet) > 0' failed.
|
The commit dfcdadb fixes the issue. The buffer was not reset properly between queries, the commit fixes that. |
gthess
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks nice!
Just replied on @k0ekk0ek 's suggestions.
- more generic switch statement for address families; - comment the protocol values as such in their definitions; - less hardcoded values for address family and protocol combinations.
wcawijngaards
added a commit
that referenced
this pull request
Oct 3, 2023
- Merge #281: Proxy protocol. An implementation of PROXYv2 for NSD. It can be configured with proxy-protocol-port: portnum with the port number of the interface on which proxy traffic is handled. The interface can support proxy traffic for UDP, TCP and TLS.
|
So it has been done 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This is an implementation of PROXYv2 for NSD.
It can be configured with
proxy-protocol-port: <portnum>with the port number of the interface on which proxy traffic is handled. The interface can support proxy traffic for UDP, TCP and TLS.It uses code from Unbound, that implements the proxy protocol specs, in NLnetLabs/unbound#881 .