You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IXFR support to provide IXFR going out, towards requestors. The implementation can store downloaded IXFRs, with store-ixfr: yes and create IXFRs from zonefiles with create-ixfr: yes.
The ixfr-number:5 and ixfr-size: 1048576 settings specify the maximum amount to store for IXFR data.
IXFRs are stored next to the zonefile in '.ixfr' files.
NSD already supports downloading IXFRs and using them, this change also makes it possible to provide IXFRs to requestors.
The reason will be displayed to describe this comment to others. Learn more.
I've looked quite a bit at the PR. There's some places where the parameters/variables can be const (I'm sure I haven't marked all of them). But I haven't found anything that's obviously wrong and the tests pass. My mind is really not a compiler, so I can only trust all the buffer writes at certain offsets are correct. Personally, in places like that I'd combine some portions, e.g. maybe reuse the packet compression code that's currently already in and make it somewhat more generic. Then write a bunch of unit tests to test it more extensively. But I'm fine with it either way.
The reason will be displayed to describe this comment to others. Learn more.
Yes, I can see that we don't need an EDE code here because the rcode is unambiguous, but how is that different from here: https://github.com/NLnetLabs/nsd/blob/ixfr-out/query.c#L1299 . Should we not also set the NOAUTH rcode without the EDE there too? WDYT?
I know it is only moved code b.t.w. So I'm perfectly fine ignoring it. Just wanted to know your opinion.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IXFR support to provide IXFR going out, towards requestors. The implementation can store downloaded IXFRs, with
store-ixfr: yesand create IXFRs from zonefiles withcreate-ixfr: yes.The
ixfr-number:5andixfr-size: 1048576settings specify the maximum amount to store for IXFR data.IXFRs are stored next to the zonefile in '.ixfr' files.
NSD already supports downloading IXFRs and using them, this change also makes it possible to provide IXFRs to requestors.